Commit Graph

69 Commits

Author SHA1 Message Date
James McCoy ff96b898f9 RSS._getConverter: Encode strings before handing them off to other functions
When the feed has a specified encoding, we'll be dealing with unicode objects
in the response from feedparser.parse().  To avoid possible UnicodeErrors, we
need to encode() before handing the string off to other functions, so the
other functions are always dealing with bytestrings instead of bytestrings and
unicode objects.  Mixing unicode and bytestrings will cause implicit
conversions of the unicode objects, which will most likely use the wrong
encoding.

Signed-off-by: James McCoy <jamessan@users.sourceforge.net>

Conflicts:

	plugins/RSS/plugin.py
2011-12-19 01:32:05 +01:00
nyuszika7h 1c6ff67cee RSS: Fix l10n-hu. 2011-11-06 21:25:10 +08:00
Valentin Lorentz 8b616d2f59 RSS: update l10n-de l10n-fi l10n-it. fix l10n-fr. 2011-10-29 17:10:58 +02:00
Valentin Lorentz 8add66511e Update l10n-fr. 2011-10-29 16:52:29 +02:00
Florian Besser 21b73bfbed RSS: internationalized announcementPrefix default value 2011-10-29 16:24:08 +02:00
Florian Besser 9ac667082f RSS: Add l10n-de 2011-10-29 10:38:17 +02:00
Valentin Lorentz dda08e0648 RSS: Fix typo (fnor -> for). 2011-08-27 13:58:14 +00:00
Valentin Lorentz 08a28214b8 RSS: bug fix. (Bad import from gribble?) 2011-08-26 17:16:13 +02:00
nyuszika7h 1577cc8bf9 RSS: Fix l10n-hu. 2011-08-19 16:23:27 +02:00
Daniel Folkinshteyn dd040f830d RSS: add channel-specific blacklist and whitelist.
also fix bug introduced with the initialannounce feature, which overwrote newheadlines
list when doing channel-specific things with it.
2011-08-14 10:53:58 +02:00
Mika Suomalainen 5d4da873a2 RSS: added l10n-fi. 2011-08-07 20:15:47 +03:00
skizzhg 7e88bb1ce3 Update l10n-it for many plugins. 2011-08-07 11:16:04 +02:00
Mika Suomalainen 5cf4534dbf RSS: l10n-fi 18% 2011-08-05 18:20:17 +03:00
Mika Suomalainen 0e5f473b05 RSS: l10n-fi 23% 2011-08-03 22:37:27 +03:00
Mika Suomalainen fd53269e22 RSS: l10n-fi 14%. 2011-08-02 15:47:26 +03:00
Mika Suomalainen d4eed76740 Merge remote-tracking branch 'progval/testing' into testing 2011-07-31 12:16:20 +03:00
nyuszika7h 6e3bdccf17 RSS: Add l10n-hu. 2011-07-31 00:13:59 +02:00
Mika Suomalainen d36bdcd209 RSS: l10n-fi: 0%. 2011-07-30 17:27:07 +03:00
Valentin Lorentz fac7f9b379 AutoMode & Conditional & Misc & Network & Owner & Plugin & RSS & Relay & Services & String & Unix: Add l10n-it. 2011-07-12 15:04:13 +02:00
Valentin Lorentz aef0b6865d Filter & Format & Later & Plugin & RSS & Reply & Status & Topic & Unix & Web: update French translation 2011-02-26 11:19:32 +01:00
Valentin Lorentz 0d7e3d3759 (Re)generate all plugin's .pot file 2011-02-26 10:40:50 +01:00
Daniel Folkinshteyn 7c3bc67c86 Add some sanity checks to RSS plugin:
First: if an rss feed is called without the number of headlines argument,
we now have a default number of items it will output.
before, it tried to stuff the whole rss feed into the channel, which is quite
floody, if more than one 'mores' is set, or if oneToOne is false.

Second: when adding a new feed to announce, it again, tried to stuff the
whole rss feed into the channel, which ran into the same floody conditions
as above. now we have a default number of feeds to output when there's no
cached history.
2011-02-25 19:15:41 +01:00
Valentin Lorentz 6e6fd58ea7 Fix RSS encoding problem 2011-01-01 17:24:13 +01:00
Valentin Lorentz eb8b16f8fb Localize Misc, MoobotFactoids, Network, News, NickCapture, Nikometer, Note, Owner, Plugin, Praise, Protector, Quote, QuoteGrabs, RSS, Relay, Reply, Scheduler, and Seen 2010-10-29 18:10:32 +02:00
Valentin Lorentz db977bf5d2 Fix Python2.5 issue (class decorators)
Issue S-fr#5
2010-10-26 09:32:12 +02:00
Valentin Lorentz 4aff05f361 RSS: fix mislocated decorator 2010-10-26 09:27:09 +02:00
Valentin Lorentz aaa0c480af Internationalize Relay, Reply, RSS, Scheduler 2010-10-19 19:50:41 +02:00
James Vega 0c62204809 Use conf.registerGlobalValue to ensure generated values are properly setup.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-06-24 00:37:40 -04:00
Daniel Folkinshteyn 40941e044a fix bug in RSS.announce.list:
Because the 'channel' argument was declared optional, calling announce.list
off-channel without a channel argument caused an error.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-05-24 14:46:04 -04:00
James Vega eff20402ac Change canonize => normalize
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2009-08-27 16:41:34 -04:00
James Vega 54dda880d4 Add a pluginCommands kwarg to Commands.listCommands.
Plugins which implement their own listCommands method should pass their
non-typically discoverable commands to Commands.listCommands via this
mechanism.  This means that the de-duplication of commands is performed in one
spot instead of having each plugin implement it on their on in their
listCommands method.

This reverts commits 0ce829af6215b97e725f4d6d580d1151950be869 and
09fb0e6fc974445a3414fb03a94625f8538d4570.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2009-05-22 18:52:15 -04:00
James Vega 7b906fbf54 Fully qualify the call to universalImport so we don't get a NameError.
Also added some ImportError handlers to aid letting users of distribution
packages know if the distributions strip out the local module copies.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2009-03-19 20:33:17 -04:00
James Vega 0b65c483dc Update RSS's README with the new announce syntax
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2009-03-15 19:19:14 -04:00
Jeremy Fincher ce8b3a556f Merge branch 'master' of ssh://jemfinch@supybot.git.sourceforge.net/gitroot/supybot 2009-03-12 13:49:15 -05:00
Jeremy Fincher d73b1eecf7 Moved BadWords's kick-check to an inFilter rather than doPrivmsg, so ignored people can still be kicked. 2009-03-12 13:47:12 -05:00
James Vega 3fd92e7f24 RSS: Move feedparser to the local directory
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2009-03-11 19:43:23 -04:00
Jeremy Fincher 5076241bcd Fixed RSS to include a feedparser which doesn't override the globally-installed one, using universalImport. 2009-03-11 14:06:16 -04:00
James Vega 62acb0c998 Make RSS.announce a nested plugin
This simplifies the interface for dealing with announced feeds by providing
separate "announce add", "announce remove", "announce list" commands as
opposed to the one "announce" command with confusing syntax.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2009-02-28 00:10:10 -05:00
James Vega 0e05fe67c7 No need to define RSS.listCommands
Doing so can lead to RSS feeds being listed multiple times.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2009-02-27 23:36:29 -05:00
James Vega 9cc917bd36 Guard feedparser import and warn the user if it's not available 2009-03-11 13:37:26 -04:00
James Vega 0ade3a0a4d Remove feedparser from RSS/ and update RSS/README.txt 2009-03-11 13:37:26 -04:00
James Vega 7bb3b1ec60 Merge the changes from the python25compat branch into the trunk 2009-03-11 13:37:24 -04:00
James Vega 8111c48a49 Switch from rssparser 3.3 to (the renamed) feedparser 4.1 in order to properly handle Bugzilla RSS feeds. 2007-05-09 02:30:18 +00:00
James Vega 4064da76aa plugins/RSS: UTF-8 encode the RSS' URL to prevent an encoding error when including the URL in the reply. 2006-08-28 13:18:12 +00:00
James Vega 73d7fd3a2d plugins/RSS/plugin.py: Refactor the character encoding detection and conversion so it can be used in more places. Hopepfully this will cause fewer UnicodeDecodeErrors. 2006-05-02 12:22:11 +00:00
James Vega 6722a856d8 plugins/RSS/test.py: A missing step in testAnnounce was causing other tests to unexpectedly fail. 2006-05-01 17:49:37 +00:00
James Vega 53e88a67c2 plugins/RSS/test.py: Remove a comment that doesn't apply anymore and add a test for another encoding problem. 2006-04-06 15:00:53 +00:00
James Vega a3e4fc5b1d Change the modeline to use softtabstop instead of tabstop. 2006-02-11 15:52:51 +00:00
James Vega 1edb4e13bf plugins/RSS: Colons are pretty. 2005-07-22 12:20:11 +00:00
James Vega 45c7f773ac plugins/RSS: Fix info so it works again. 2005-07-19 21:32:54 +00:00