Commit Graph

218 Commits

Author SHA1 Message Date
Valentin Lorentz
dcf55cf6de RSS: Use an explicit timeout for assertNoResponse, because it defaults to 0.
Which means there may be a command/update thread running and returning after assertNoResponse returns.
In particular, that's an issue when assertNoResponse is called right before
setting feedparser._open_resource, because the running thread might still
be holding the lock but have fetched the new version already, so the
thread announces the new feed elements earlier than expected.
2019-10-05 15:57:01 +02:00
Valentin Lorentz
a4665803fa News + RSS: Mock time.time() instead of using time.sleep() in tests.
Saves 40s over the ~5min test suite.
2019-10-05 12:22:30 +02:00
Valentin Lorentz
c1ae3f5c81 all plugins: Use msg.channel instead of msg.args[0] + give network name to self.registryValue. 2019-08-24 23:35:01 +02:00
Valentin Lorentz
696254ff1b Use irc.isChannel instead of ircutils.isChannel when possible.
It's aware of the network's 'chantypes'.
2019-08-04 21:52:40 +02:00
James Lu
c7716de887 RSS: add a quick test for a malformed feed that has no entries
(Only both of these combined gives new output so far.)
2018-10-14 12:42:15 -07:00
James Lu
2fdc433cb3 RSS: show soft errors set by feedparser when no entries are found
Hopefully this will ease debugging - e.g. a bad TLS certificate will now show
"Error: Couldn't get RSS feed. Parser error: <urlopen error
 [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:720)>"
instead of only a generic message.
2018-10-14 12:41:22 -07:00
Tasos Sahanidis
b900a369a4 RSS: Fix feeds with missing description or title
An AttributeError would be raised when a blacklist or a whitelist
would be set on feeds that miss either a title or a description.
2018-03-13 23:50:47 +01:00
Valentin Lorentz
3ab226c129 RSS: Only defer feed loading at plugin load while the bot is starting.
Defering it if the plugin is (re)loaded while already running is useless.
Closes GH-922.
2017-12-10 09:39:20 +01:00
James Lu
bdd0adfef5 RSS: add missing configuration help for feed URL options
This fixes confusing "That configuration group exists, but seems to have no help." errors on the URL
options for feeds, when these options are actually relevant and settable.
2017-12-09 23:03:42 -08:00
Valentin Lorentz
e08e899134 Fix test 2017-10-21 17:11:21 +02:00
Valentin Lorentz
e16faab805 RSS: On startup, only delay feeds loading for 10 seconds instead of the whole of supybot.plugins.RSS.waitPeriod. 2017-10-21 16:48:44 +02:00
Valentin Lorentz
eaa5a5523e RSS: Add var supybot.plugins.RSS.maximumAnnounceHeadlines. 2017-10-12 21:21:50 +02:00
Valentin Lorentz
d73de5e512 Fix potential bug due to mutability of lists as default argument. 2017-03-30 21:38:18 +00:00
Valentin Lorentz
3633a2b2e3 RSS: Only keep the most recent entries in the initial announce. 2017-01-27 21:00:58 +01:00
Valentin Lorentz
d7099794bc Fix Python 2 support of last commit. 2016-09-20 23:22:13 +02:00
Valentin Lorentz
2cfe0f679f Fix previous commit on some Python versions. 2016-09-20 23:09:29 +02:00
Valentin Lorentz
d39647142c RSS: Fix shadowing of any/all. 2016-09-20 22:54:11 +02:00
Valentin Lorentz
4f280599e1 RSS: use the original FeedParserDict for substitution
instead of building a new keyword arguments dict by iteration.

'description' is a field in FeedParserDict, but is not present when iterating,
which made it unavailable as a substitution variable.
2016-09-08 21:42:31 +02:00
Valentin Lorentz
3776404628 RSS: Use HTTP(S) proxy. Closes GH-1234. 2016-08-16 10:56:29 +02:00
Valentin Lorentz
3f66dbc3d5 Channel & Dunno & Misc & RSS & Scheduler: Let the logging facility perform string templating to avoid extra format chars in argument. 2015-11-03 17:25:13 +01:00
Valentin Lorentz
fb52b16429 RSS: Allow @announce add to take URLs as feed names. 2015-10-10 20:40:25 +02:00
Valentin Lorentz
4498548cb3 RSS: Add supybot.plugins.RSS.notice. Closes GH-1151. 2015-09-23 11:27:20 +02:00
Valentin Lorentz
82332ff87c RSS: Add feed-specific waitPeriod. 2015-09-23 11:05:25 +02:00
Valentin Lorentz
1c218592af RSS: Add fallback on sorting by update timestamp + add outdatedFirst and updatedFirst sorts. Closes GH-1139. 2015-09-02 10:04:04 +02:00
Valentin Lorentz
29ca3eb5e4 RSS: Sort on time tuples instead of formatted dates. 2015-09-02 09:43:29 +02:00
Valentin Lorentz
c3a2c800f1 Remove need for 2to3. 2015-08-11 16:50:23 +02:00
Valentin Lorentz
c0ac84bb53 Remove need for fix_import, fix_types, and fix_urllib. 2015-08-10 17:55:25 +02:00
Valentin Lorentz
216c5d213f Replace sys.version_info[0] usages with minisix.PY{2,3}. 2015-08-09 00:23:03 +02:00
Valentin Lorentz
7c4a28d7fd RSS: Remove illegal characters from entries. 2015-06-01 19:32:40 +02:00
Valentin Lorentz
ac0e6b86c0 RSS: Fix typo. 2015-05-23 11:48:32 +02:00
Valentin Lorentz
34138b9185 RSS: Don't crash on load if there is an invalid feed name. Closes GH-1116. 2015-05-23 11:40:26 +02:00
Valentin Lorentz
2008956968 RSS: Reove broken (and probably irrelevant) link in the README. 2015-05-10 09:57:11 +00:00
a5cfad3a05 RSS: rewrite basic usage in README 2015-01-27 09:13:30 +02:00
Valentin Lorentz
aa89a2dd72 Trying to make the tests fail less… 2015-01-05 20:39:22 +01:00
Valentin Lorentz
d06d744f11 Squashed commit of the following:
commit 47ede7f658c17857fd291a1a40df3b3c18e36473
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:51:45 2014 +0200

    Misc: update l10n-fi

    Sorry, I forgot to commit this before PR.

commit 6b5d61e5a5ae323dcc2c8366ea68236fd09bccae
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:42:37 2014 +0200

    Web: update l10n-fi

    [CI SKIP]

commit e103515083d9448bd80520c02c895ea8a1f33107
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:41:15 2014 +0200

    URL: update l10n-fi

commit 942d1db0aa1deb8e5d2a4f81a62edefc30a6ce27
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:33:52 2014 +0200

    Factoids: update l10n-fi

    [CI SKIP]

commit dae8da0c7568c63ebc3986503ac86a5d6466c6e9
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:32:46 2014 +0200

    Conditional: update l10n-fi

commit 7bd2d8cc65b3908c6ffe5b1eb9250987484c247a
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:20:23 2014 +0200

    Todo: update l10n-fi

commit ee37330b8fdd3a32fd5156ab0e792d76176b0515
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:19:17 2014 +0200

    Nickometer: update l10n-fi

commit 81271aa71846469de61d1be4b5cb442a26f955b9
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:16:30 2014 +0200

    NickAuth: update l10n-fi

commit 7d9bfeaffaef0c1f1fee7ed7d84064ba02bfdfb1
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:14:04 2014 +0200

    Note: update l10n-fi

commit 9ab5c2c3803413b1e775121a733ddf0408065764
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:10:09 2014 +0200

    Google: update l10n-fi

    "This is a simple plugin to provide access to the Google services we
    all know and love from our favorite IRC bot." :D

commit 897a7b79c45108e70b2ba1a4f7156029a043a17d
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:07:13 2014 +0200

    Herald: update l10n-fi

commit 2825cd6a32d4cc843a748d0ea6162760064cdc77
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 14:00:59 2014 +0200

    Misc: update l10n-fi

    [SKIP CI]

commit fba930cd3982d5ba92ba1b1ec1c194911a01e875
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:58:51 2014 +0200

    Utilities: update l10n-fi

commit 21c875b3fc66176f2c65fd1291e3a6360e8708f3
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:57:25 2014 +0200

    Aka: update l10n-fi

commit 05005f464db107f8ad18becc3855e263f04634c8
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:51:15 2014 +0200

    Config: update l10n-fi

commit 8e57df072c9af0dda1ac2b048712f5e973163c7d
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:50:20 2014 +0200

    Karma: add l10n-fi

commit d2f6c6802fc327d2f308ef71ac2640df244463d1
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:47:28 2014 +0200

    Alias: update l10n-fi

    [CI SKIP]

commit b97484dd74e553606de26cab987c69bc160781a9
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:45:23 2014 +0200

    Topic: update l10n-fi

commit 6dc04aca97a2a107821f53c5d067133122323df3
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:43:41 2014 +0200

    Time: update l10n-fi

commit e0f04cb4334f854524da711993ae7041f151b1c8
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:38:44 2014 +0200

    Scheduler: update l10n-fi

commit bcd8ede5ad263963b6fa67fac204cf8f2ab3cafa
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:37:28 2014 +0200

    Filter: update l10n-fi

commit 32619add01f26332f3c5b559003c94711c4a299b
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:26:11 2014 +0200

    Internet: update l10n-fi

commit a3c3342db39ae8404df8d89478b5c23f6642847d
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:12:05 2014 +0200

    Web: update l10n-fi

    [CI SKIP]

commit 77476fd14b970969ef6d64cfe6930e3812e6f88e
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:10:23 2014 +0200

    Unix: update l10n-fi

commit db5d59b4514becf128b6ec0dbec8f4543cb069ea
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:09:19 2014 +0200

    ChannelStats: update l10n-fi

commit 827c225fe5141cd3fa5060b19e8e19aafc8a2895
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:08:02 2014 +0200

    Quote: update l10n-fi

commit 615019735eae74f95413622d0e42a7cd7d610da1
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:06:22 2014 +0200

    Seen: update l10n-fi

commit 36c4606fd82b207f93658fda320890eb26bec6d4
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 13:03:52 2014 +0200

    MoobotFactoids: update l10n-fi

commit c1c958a6dbb14b2f039771cb4179c5ba36d10026
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:23:33 2014 +0200

    Dict: update l10n-fi

    [CI SKIP]

commit 9d98da8e3d3fdd0f2204bd92e5c57313e8fc3477
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:21:58 2014 +0200

    ShrinkURL: update l10n-fi

commit a5d6a7325b753e4ea2bfbb29374be89207fc59fd
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:20:04 2014 +0200

    String: update l10n-fi

commit 95f88c750ebcbaf66512d940b089298a67e19851
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:19:06 2014 +0200

    Admin: update l10n-fi

commit ba52e93038468f785148ba31cb87c974fe64cddb
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:17:45 2014 +0200

    Relay: update l10n-fi

commit 0ae032bf4d4562c91164560cefe2e4d88be1ed74
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:16:42 2014 +0200

    Math: update l10n-fi

commit c16cc0fa114d063d75c3b043dc5b357a470ce46e
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:14:54 2014 +0200

    Channel: update l10n-fi

    [CI SKIP]

commit 738a3c91d66cfc822697bc4d35f0bc3ea44a8191
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:13:28 2014 +0200

    ChannelLogger: update l10n-fi

commit 843dc98cea02cc4027d2ea6824258e12a69cb828
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:12:14 2014 +0200

    RSS: update l10n-fi

commit 903b50150d42202c382cb20f18fefd17d62ae0ad
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:09:44 2014 +0200

    Protector: add l10n-fi

    [CI SKIP]

commit d5488599151814e0a26ab43d4e2d0545a2910a0c
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:08:08 2014 +0200

    QuoteGrabs: update l10n-fi

commit 2586497f74555a092969e07190e544374effa634
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:04:30 2014 +0200

    Lart: update l10n-fi

    [CI SKIP]

commit 276d76eb3c6ba64d6b5bccd54897d01059a86fcd
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 12:03:18 2014 +0200

    Anonymous: update l10n-fi

commit b98c6a51c9f2e12b0207d68baa7f4311e7c276be
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 11:44:16 2014 +0200

    User: update l10n-fi

    [CI SKIP]

commit 218a53ffcbfc854678cac3a4af033753f1f48fa6
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 11:42:13 2014 +0200

    News: update l10n-fi

commit 0b68eda84131448fbe585983f4320c163574e2d2
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 11:40:41 2014 +0200

    Format: update l10n-fi

commit 9c390ed244c2b152f343d56837e56bedab7d7698
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 11:39:03 2014 +0200

    AutoMode: update l10n-fi

commit 4523e154792fdead7a26b19a3178c1c1e86082a7
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 11:37:49 2014 +0200

    Status: update l10n-fi

commit 28d6c4b0c5072273d8d37c9bf87b671aba6d5df4
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 11:36:33 2014 +0200

    Games: update l10n-fi

    [CI SKIP]

commit 52e21367d99e908b1c650f2f379659037251c4eb
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 11:34:22 2014 +0200

    Network: update l10n-fi

    [CI SKIP]

commit 7876a8f1e1ae35a13df9299e24c996a887542481
Author: Mikaela Suomalainen <mikaela.suomalainen@outlook.com>
Date:   Sat Dec 20 11:28:18 2014 +0200

    core: update l10n-fi
2014-12-20 14:37:27 +01:00
Valentin Lorentz
1650860032 RSS: Do no block commands calling while loading a feed. 2014-10-14 20:59:00 +00:00
Valentin Lorentz
d2046a81a2 RSS: Prevent errors if users do not use @announce add correctly. Closes GH-869. 2014-10-10 14:41:45 +00:00
Valentin Lorentz
44707374c0 RSS: Fix support of feeds that do no have guid fields. Closes GH845. 2014-09-14 10:06:45 +00:00
Valentin Lorentz
15fb16a8ae RSS: Make the cache bigger in order to prevent duplicated announces. 2014-09-12 22:37:06 +00:00
Valentin Lorentz
e51e45de4d RSS: Fix typo. 2014-08-13 17:04:35 +02:00
Valentin Lorentz
c08a480f11 RSS: Honor supybot.plugins.RSS.initialAnnounceHeadlines. 2014-08-13 16:43:43 +02:00
Valentin Lorentz
96ba33a296 RSS: Fix bad usage of safe_substitute. 2014-08-13 14:17:06 +00:00
Mikaela Suomalainen
58f3649f58 RSS: update l10n-fi & messages.pot
[SKIP CI]
2014-08-10 18:10:20 +02:00
Valentin Lorentz
1d4a1b13d8 RSS: Internationalize feed-specific format config doc. 2014-08-10 15:29:47 +02:00
Valentin Lorentz
3b2382d2f9 RSS: Remove debug output. 2014-08-05 11:49:13 +02:00
Valentin Lorentz
8efcc4a009 RSS: Display nice error if an announced feed does not exist. 2014-08-04 17:01:30 +02:00
Valentin Lorentz
d431c2992b Factoids: Fix compatibility of web server with Python 3. Closes GH-784. 2014-08-04 13:21:40 +00:00
Valentin Lorentz
ab1ac2aa8e RSS: Remove use of deprecated property. Closes GH-807. 2014-08-04 15:02:46 +02:00
Mikaela Suomalainen
cae6799fe5 RSS: update l10n-fi & messages.pot 2014-08-01 20:03:49 +03:00
Valentin Lorentz
ddcbc151b6 RSS: Fix listing of commands (show names, not URLs). 2014-08-01 09:17:58 +00:00