Previously, SASL was failing on networks like freenode, as the connection completed before a CAP response was received.
(cherry picked from commit 9420f21680)
This was previously trying to update the state based on the user's nick, but we use PUIDs internally. In other words, make sure that we don't replace the internal target when sending the outgoing text...
For example, 'remote net1 remote net2 echo hi' was problematic if the source network was 'net1'.
It's a good thing this command is restricted by default...
Previously, the Irc.reply_lock check was in the reply() function itself: replacing it with another function checking for the same lock would delay execution,
but then run the wrong reply() code if another module used irc.reply() while 'remote' was executing.
Squashed commit of the following:
commit b03e5f82405343d54015a40c1655d54f0fc5ce90
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Mon Mar 27 16:04:51 2017 -0700
.travis: install pandoc, disable docs and email
commit 25cd4ad2a07686f7a196b151070efe3fd31a94e3
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Mon Mar 27 15:55:36 2017 -0700
wrap python as a subprocess
commit 749177ac7b13921f8a04b023b54c1716ff0ce0b0
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Mon Mar 27 15:53:37 2017 -0700
oops, do proper matching
commit 98f90c15fd5be91b70ecf70bdff3a005d1fedc94
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Mon Mar 27 15:52:15 2017 -0700
i am not dealing with this shell.
commit 8b3dcb6c59617e7ca85363bf485dc295ff22a012
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Mon Mar 27 15:37:28 2017 -0700
More .travis.yml tweaks
commit 49346bef1b7794eefd251d27e846a184c0569dad
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Mon Mar 27 15:28:30 2017 -0700
.travis.yml: add missing directory to compileall
commit 7eb1d464481c958ef007b51234045a13f1a8c06e
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Mon Mar 27 15:23:21 2017 -0700
Make travis do syntax verification on all modules
commit 0331356e91e22cd85859a4ebbaf1973f21db1650
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Mon Mar 27 15:19:24 2017 -0700
Revert ".travis.yml: remove duplicate python version restriction"
This reverts commit 51c74cedff78aa204813743e1a738e3aa63fe3c6.
commit 51c74cedff78aa204813743e1a738e3aa63fe3c6
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Wed Feb 22 16:23:14 2017 -0800
.travis.yml: remove duplicate python version restriction
commit 04087af09a29e2f825545cdc36be55f86a7c7d10
Author: James Lu <GLolol@overdrivenetworks.com>
Date: Wed Feb 22 16:07:51 2017 -0800
Test travis-ci deployment
socket.error is aliased to OSError since Python 3.3, and ConnectionError is actually a subclass of OSError.
So, it makes more sense to just catch the more generic type here.
Also, make ProtocolError derive from RuntimeError instead of Exception.
(cherry picked from commit 397df48efd)
