mirror of
https://github.com/jlu5/PyLink.git
synced 2024-12-25 04:02:45 +01:00
updateTS: remove usage of mutable as function default argument
This may subtly break things: https://docs.quantifiedcode.com/python-anti-patterns/correctness/mutable_default_value_as_argument.html
This commit is contained in:
parent
9d50a4363b
commit
6d96dd21ac
@ -1450,7 +1450,7 @@ class Protocol():
|
||||
log.debug('Removing client %s from self.irc.servers[%s].users', numeric, sid)
|
||||
self.irc.servers[sid].users.discard(numeric)
|
||||
|
||||
def updateTS(self, sender, channel, their_ts, modes=[]):
|
||||
def updateTS(self, sender, channel, their_ts, modes=None):
|
||||
"""
|
||||
Merges modes of a channel given the remote TS and a list of modes.
|
||||
"""
|
||||
@ -1461,6 +1461,9 @@ class Protocol():
|
||||
# mode origin is us | OVERWRITE | MERGE | IGNORE
|
||||
# mode origin is uplink | IGNORE | MERGE | OVERWRITE
|
||||
|
||||
if modes is None:
|
||||
modes = []
|
||||
|
||||
def _clear():
|
||||
log.debug("(%s) Clearing local modes from channel %s due to TS change", self.irc.name,
|
||||
channel)
|
||||
|
Loading…
Reference in New Issue
Block a user