* Based on `ssf-formula` (v0.3.0) - https://github.com/myii/ssf-formula/pull/5 * Unable to use `pillar.example` directly for testing - Used it as a basis for `test/salt/pillar/default.sls` - Brought useful changes back to `pillar.example` * Fix: avoid `users/googleauth.sls` for `RedHat` & `Suse` * Close #203
5.0 KiB
How to contribute
This document will eventually outline all aspects of guidance to make your contributing experience a fruitful and enjoyable one. What it already contains is information about commit message formatting and how that directly affects the numerous automated processes that are used for this repo. It also covers how to contribute to this formula's documentation.
Table of Contents
Overview
Submitting a pull request is more than just code! To achieve a quality product, the tests and documentation need to be updated as well. An excellent pull request will include these in the changes, wherever relevant.
Commit message formatting
Since every type of change requires making Git commits, we will start by covering the importance of ensuring that all of your commit messages are in the correct format.
Automation of multiple processes
This formula uses semantic-release for automating numerous processes such as bumping the version number appropriately, creating new tags/releases and updating the changelog. The entire process relies on the structure of commit messages to determine the version bump, which is then used for the rest of the automation.
Full details are available in the upstream docs regarding the Angular Commit Message Conventions. The key factor is that the first line of the commit message must follow this format:
type(scope): subject
- E.g.
docs(contributing): add commit message formatting instructions
.
Besides the version bump, the changelog and release notes are formatted accordingly. So based on the example above:
Documentation
- contributing: add commit message formatting instructions
- The
type
translates into aDocumentation
sub-heading. - The
(scope):
will be shown in bold text without the brackets. - The
subject
follows thescope
as standard text.
Linting commit messages in Travis CI
This formula uses commitlint
for checking commit messages during CI testing. This ensures that they
are in accordance with the semantic-release
settings.
For more details about the default settings, refer back to the
commitlint
reference
rules.
Relationship between commit type and version bump
This formula applies some customisations to the defaults, as outlined in the table below, based upon the type of the commit:
Type | Heading | Description | Bump (default) | Bump (custom) |
---|---|---|---|---|
build |
Build System | Changes related to the build system | – | |
chore |
– | Changes to the build process or auxiliary tools and libraries such as documentation generation | – | |
ci |
Continuous Integration | Changes to the continuous integration configuration | – | |
docs |
Documentation | Documentation only changes | – | 0.0.1 |
feat |
Features | A new feature | 0.1.0 | |
fix |
Bug Fixes | A bug fix | 0.0.1 | |
perf |
Performance Improvements | A code change that improves performance | 0.0.1 | |
refactor |
Code Refactoring | A code change that neither fixes a bug nor adds a feature | – | 0.0.1 |
revert |
Reverts | A commit used to revert a previous commit | – | 0.0.1 |
style |
Styles | Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) | – | 0.0.1 |
test |
Tests | Adding missing or correcting existing tests | – | 0.0.1 |
Use
BREAKING CHANGE
to trigger a major
version
change
Adding BREAKING CHANGE
to the footer of the extended
description of the commit message will always trigger a
major
version change, no matter which type has been used.
This will be appended to the changelog and release notes as well. To
preserve good formatting of these notes, the following format is
prescribed:
BREAKING CHANGE: <explanation in paragraph format>.
An example of that:
...
BREAKING CHANGE: With the removal of all of the `.sls` files under
`template package`, this formula no longer supports the installation of
packages.