Commit Graph

4868 Commits

Author SHA1 Message Date
Mikaela Suomalainen
3fc64abe93 Web: update l10n-fi. 2014-03-22 13:05:49 +02:00
Mikaela Suomalainen
cefc20c0fe Topic: update l10n-fi. 2014-03-22 12:59:43 +02:00
Mikaela Suomalainen
ff75622725 Ctcp: update l10n-fi. 2014-03-22 12:49:57 +02:00
Mikaela Suomalainen
3dc7316588 Admin: update l10n-fi. 2014-03-22 12:47:03 +02:00
Mikaela Suomalainen
93f470185f NickAuth: update l10n-fi. 2014-03-22 12:44:23 +02:00
Mikaela Suomalainen
aa59a98767 Aka: add l10n-fi. 2014-03-22 12:39:48 +02:00
Mikaela Suomalainen
0d62257d79 update messages.pot files && Unix: update l10n-fi. 2014-03-22 12:22:54 +02:00
Mikaela Suomalainen
f88e8e20b9 My name is Mikaela!
Thanks @nyuszika7h :) ☺
2014-03-22 12:01:11 +02:00
Valentin Lorentz
bfb305e2b8 Utilities: Use number comparison for integers and floats in @sort. 2014-03-20 21:17:18 +00:00
Valentin Lorentz
bfa45a6da8 Utilities: Add @sort. 2014-03-20 17:46:47 +00:00
nyuszika7h
9186162b1a Ctcp: Fix regex for PING
The bot shouldn't treat a request such as "PING1234" as "PING 1234".
2014-03-20 11:57:12 +01:00
nyuszika7h
8a3ea3d5c8 Ctcp: Don't reply to malformed CTCP requests 2014-03-20 09:57:33 +01:00
nyuszika7h
3b07c3d0ec PluginDownloader: Update URL of my repo
I also kept the old one as nyuszika7h-old for now, as I don't have an
ETA on updating those plugins.
2014-03-16 22:45:22 +01:00
Valentin Lorentz
a28560c267 Merge pull request #567 from nyuszika7h/plugin-remove-list
Plugin: Remove duplicate !list command
2014-03-16 16:14:06 +01:00
nyuszika7h
a9b36719ba Remove test case for !plugin list 2014-03-16 16:12:03 +01:00
nyuszika7h
1a7e584a53 Plugin: Remove duplicate !list command
It also exists in Misc.
2014-03-16 14:12:53 +01:00
Valentin Lorentz
f191e21970 Channel: Add command @ban hostmask. 2014-03-09 18:40:02 +00:00
Valentin Lorentz
77e6de6bba Fix errors detected by PyLint. 2014-03-05 14:14:36 +01:00
Valentin Lorentz
4f7caa78e4 Misc: Update @version to match the new version format. 2014-03-03 16:22:32 +00:00
nyuszika7h
fb8d929cc8 Clarify help text for !shell
I should stop using @, poor @shell getting notified by commits
irrelevant to his interests. :P

[skip ci]
2014-03-01 18:23:04 +01:00
nyuszika7h
322023c011 Unix: Add @shell command 2014-02-27 16:01:21 +01:00
nyuszika7h
bc4cfb96dd Unix: Fix FD leaks and Windows compatibility 2014-02-27 15:36:05 +01:00
nyuszika7h
4d5889e873 ChannelStats: Remove useless space.
Closes #170.
[ci skip]
2014-02-26 18:47:04 +01:00
Valentin Lorentz
427033d8e8 ChannelLogger: Fix Python 2 compatibility (again). 2014-02-17 21:30:15 +00:00
Valentin Lorentz
0c58ab2e98 ChannelLogger: Fix Python 2 compatibility (again). 2014-02-17 19:24:41 +00:00
Valentin Lorentz
98076482b6 ChannelLogger: Fix Python 2 compatibility. 2014-02-17 16:01:51 +00:00
GLolol
b8ada98df1 Fix incorrect error on loading nonexistent plugin 2014-02-06 18:52:33 -08:00
Iota Spencer
b8fa70172a Fix coding style and remove unneeded command 2014-02-06 06:19:02 +00:00
Iota Spencer
974dc00d29 Fix cmdall / Add the wrap() 2014-02-06 06:19:02 +00:00
Ken Spencer
051b0e8994 Add command to do specific command on all networks
Helps with Announce and other commands that may be need to go multiple networks.
2014-02-06 06:19:02 +00:00
Valentin Lorentz
29944234e4 ChannelLogger: Fix Python 2 compatibility. 2014-02-03 23:40:54 +00:00
Valentin Lorentz
38405e8d87 Seen: Allow wildcards for @seen. 2014-02-03 15:08:58 +00:00
Valentin Lorentz
5d301b653f Merge remote-tracking branch 'origin/speed-up-2to3' into testing
Conflicts:
	locales/fr.po
	plugins/Misc/plugin.py
	sandbox/check_trans.py
	src/i18n.py
2014-02-02 22:28:19 +01:00
Valentin Lorentz
552d814f2f Remove useless class. 2014-02-02 22:22:36 +01:00
Valentin Lorentz
c52b454b27 Aka: Use automatic incrementation when adding an alias. 2014-02-02 22:22:25 +01:00
Valentin Lorentz
18708a2678 Aka: Add SQLite3 backend. 2014-02-02 22:22:20 +01:00
Valentin Lorentz
4fe74ed397 Merge branch 'aka-sqlite3' into speed-up-2to3 2014-02-02 22:15:43 +01:00
Valentin Lorentz
fb0ef31d94 PluginDownloader: Add GLolol's repository. 2014-02-02 17:39:40 +00:00
Valentin Lorentz
b026cfd197 Misc: Add tests for “list --unloaded” and command flood. 2014-01-26 20:47:34 +01:00
Valentin Lorentz
74a36c8cfc Misc: Fix count of invalid commands introduced in c91916ae. Closes GH-439. 2014-01-26 20:47:27 +01:00
Valentin Lorentz
40e6f789cf Misc: Remove dead code. 2014-01-26 20:47:21 +01:00
Valentin Lorentz
8aa7e781a4 ChannelStats & Conditional & Format & Karma & Web: Update l10n-fr. 2014-01-26 20:45:28 +01:00
Valentin Lorentz
b3b077c065 ChannelStats: Fix typo. 2014-01-26 20:45:28 +01:00
Valentin Lorentz
f6aa48f393 Admin & Alias & Later & String: Update l10n-fr. 2014-01-26 20:45:28 +01:00
Valentin Lorentz
d4f9187b89 Remove a message.pot that should not have been there. 2014-01-26 20:45:28 +01:00
Valentin Lorentz
fe57cdb4dc ChannelStats & MessageParser & PluginDownloader & RSS & User: Update l10n-fr. 2014-01-26 20:45:27 +01:00
Valentin Lorentz
99a734323f AutoMode & Factoids & Google & Math & Network & Seen & Status & Topic: Update l10n-fr. 2014-01-26 20:45:27 +01:00
Valentin Lorentz
736c615605 Time: Update l10n-fr. 2014-01-26 20:45:27 +01:00
Valentin Lorentz
a3dbece402 All plugins: Update .pot files and rename Supybot-fr to Limnora in French translation files. 2014-01-26 20:45:27 +01:00
Valentin Lorentz
d25a3c0724 Remove useless class. 2014-01-23 10:20:38 +01:00
Valentin Lorentz
e4ce7356c6 Aka: Use automatic incrementation when adding an alias. 2014-01-22 16:44:17 +01:00
Valentin Lorentz
5aa0c8cfbd Aka: Add SQLite3 backend. 2014-01-22 15:16:12 +01:00
Valentin Lorentz
1c617ea742 ChannelStats & Conditional & Format & Karma & Web: Update l10n-fr. 2014-01-22 13:53:03 +01:00
Valentin Lorentz
a0ca3450f1 ChannelStats: Fix typo. 2014-01-22 13:46:42 +01:00
Valentin Lorentz
ed919ba2d5 Admin & Alias & Later & String: Update l10n-fr. 2014-01-22 13:45:29 +01:00
Valentin Lorentz
16dc9ea7a3 Remove a message.pot that should not have been there. 2014-01-22 13:45:01 +01:00
Valentin Lorentz
5cfa7828ea ChannelStats & MessageParser & PluginDownloader & RSS & User: Update l10n-fr. 2014-01-22 08:02:03 +01:00
Valentin Lorentz
ca6ee1fcb1 AutoMode & Factoids & Google & Math & Network & Seen & Status & Topic: Update l10n-fr. 2014-01-21 22:41:11 +01:00
Valentin Lorentz
12e652f7db Time: Update l10n-fr. 2014-01-21 16:56:44 +01:00
Valentin Lorentz
8b06bd52f0 All plugins: Update .pot files and rename Supybot-fr to Limnora in French translation files. 2014-01-21 16:48:13 +01:00
Valentin Lorentz
06fdaa792f Continue accelerating the 2to3 step (remove fix_map). 2014-01-21 10:57:38 +01:00
Valentin Lorentz
1fbdedc7e0 Continue accelerating the 2to3 step (remove fix_funcattrs, fix_itertools, and fix_itertools_imports). 2014-01-21 10:50:55 +01:00
Valentin Lorentz
35a62b4e77 Continue accelerating the 2to3 step (remove fix_ws_comma, fix_xreadlines, and fix_zip). 2014-01-21 10:40:18 +01:00
Valentin Lorentz
ca419f6485 Continue accelerating the 2to3 step (remove fix_reduce, fix_renames, fix_repr, fix_set_literal, fix_standarderror, fix_sys_exc, fix_throw, and fix_tuple_params). 2014-01-20 16:04:53 +01:00
Valentin Lorentz
bb7db3ab21 Continue accelerating the 2to3 step (remove fix_except). 2014-01-20 15:49:15 +01:00
Valentin Lorentz
2fda69b4d6 Continue accelerating the 2to3 step (remove fix_raise). 2014-01-20 15:43:55 +01:00
Valentin Lorentz
c1c23f66f4 Continue accelerating the 2to3 step (remove fix_print). 2014-01-20 15:31:09 +01:00
Valentin Lorentz
d1649a44ac Continue accelerating the 2to3 step (remove fix_idioms, fix_imports2, fix_input, fix_intern, fix_isinstance, fix_ne, fix_next, and fix_raw_input). 2014-01-20 15:13:01 +01:00
Valentin Lorentz
4652c9ce51 Start accelerating the 2to3 step (remove fix_apply, fix_buffer, fix_callable, fix_exec, fix_execfile, fix_exitfunc, fix_filter, fix_funcattrs, fix_future, fix_getcwdu, and fix_has_key). 2014-01-20 14:49:47 +01:00
Valentin Lorentz
5e894b5f39 User: Fix previous commit. 2014-01-17 19:38:59 +00:00
Valentin Lorentz
b7bfd64bc4 User: Fix GPG auth on Python 3. Closes GH-541. Closes GH-542. 2014-01-17 19:15:28 +00:00
Valentin Lorentz
1f2d51dfc5 Merge pull request #540 from esplinr/master
ChannelLogger: Improvements to file handling.
2014-01-15 23:11:26 -08:00
Richard Esplin
5ecb154186 Ensure log files are UTF-8 encoded
The default encoding is platform specific, so problems can arise if we do not
make it explicit. Especially on Windows. Freenode appears to be all UTF-8, and
irclib is giving us UTF-8 strings, so let's standardize on UTF-8.
2014-01-15 23:15:09 -07:00
Richard Esplin
ba0ba71bf4 Eliminate unnecessary closing of the log file.
Name returns a string that is the log file name: the channel plus the timestamp.
But on my system log.name returns the fully qualified path to the currently open file. This is because log is a file handle, so if you declare it with a path, it will be included in the name.
On systems were logging is not in the current directory, the two will never match, and the file is closed and then reopened.
Only taking the basename solves this problem.
2014-01-15 16:15:11 -07:00
Valentin Lorentz
5341df0254 Google: *copy* the utils.web.defaultHeaders before adding items to it. 2014-01-14 20:55:56 +00:00
nyuszika7h
c3dcc4f416 Do the previous commit in a more clean way 2014-01-13 18:27:52 +01:00
nyuszika7h
6dd179f9e9 Later: Always prefix nick if telling in channel 2014-01-13 18:07:49 +01:00
James McCoy
949c093952 Correct the URL reported by Misc.source
Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2014-01-05 22:35:28 -05:00
Valentin Lorentz
9457f4dbe7 Misc: Add command @noticetell to replace “@notice [tell ]” which is no longer possible since f0233c37. 2014-01-01 20:46:09 +00:00
Valentin Lorentz
43e1b55506 Misc: Fix @version on Python 2. 2014-01-01 11:40:49 +00:00
Valentin Lorentz
9ff1483da2 Time: Make argument to @at optional. (Replacement for GH-533 that does not need nesting.) 2013-12-28 23:05:23 +00:00
Valentin Lorentz
df375e075a AutoMode: Fix alternative capabilities handling. 2013-12-27 15:04:50 +00:00
Valentin Lorentz
f1c13054fe Revert "AutoMode: Disable overriding rights of auto* capabilities."
This reverts commit 4a20270655.
2013-12-27 14:21:12 +00:00
nyuszika7h
b5a9aee7a6 Web: Fix exception on timeout 2013-12-25 16:43:41 +01:00
Valentin Lorentz
47409b11a0 NickAuth: Fix argument order in @remove. Closes GH-530. 2013-12-24 16:31:45 +00:00
Valentin Lorentz
162b9ef709 Aka: Add length limit of command names in order to limit the number of database queries.
There were a lot of database queries (as much as words in the whole command) for non-aka commands.
2013-12-24 14:38:26 +00:00
Valentin Lorentz
83e1d1b91b Fix previous commit. 2013-12-23 17:51:15 +01:00
Valentin Lorentz
764c788aa6 Revert "Aka: Allow optional arguments and $* together, and also multiple instances of $*."
This reverts commit 774285ef03.

Conflicts:
	plugins/Aka/plugin.py
2013-12-23 17:41:56 +01:00
Valentin Lorentz
4a20270655 AutoMode: Disable overriding rights of auto* capabilities. 2013-12-22 17:10:02 +00:00
Valentin Lorentz
19066b62a3 AutoMode: Add 'auto*' capabilities to override the configuration values (which apply to capabilities also used elsewhere). 2013-12-22 15:32:09 +01:00
Valentin Lorentz
ee4690ea18 Math: Skip tests of negative integers exponentiation on Python 2. 2013-12-15 18:44:11 +00:00
Valentin Lorentz
3cc52aefca Math: Fix handling of negative integers in @calc. 2013-12-15 18:29:34 +00:00
Valentin Lorentz
01278dc56c Aka: Fix 'factorial-complexity' recursion and command overriding. 2013-12-11 16:01:01 +00:00
Valentin Lorentz
56570b3c9c Aka: Make sure the length of the 'args' list is always strictly decreasing when making a recursive call. 2013-12-05 12:35:02 +00:00
Valentin Lorentz
4ad9e83a11 Alias & Factoids & Plugin: Fix typos. 2013-12-01 08:45:40 +01:00
spline
be2ad1f11f Google: Fix @calc. 2013-11-29 16:09:37 +01:00
Valentin Lorentz
e99ad36667 Aka: Fix commit ddbadcafff (again). 2013-11-27 17:57:30 +01:00
Valentin Lorentz
feebaca292 Aka: Fix commit ddbadcafff. 2013-11-27 17:49:03 +01:00
Valentin Lorentz
ddbadcafff Alias & Aka: Add memory and nesting limits. Closes GH-525. 2013-11-27 17:38:24 +01:00
Valentin Lorentz
13d2746454 ChannelStats & Conditionnal & Format & Karma & Limiter & MessageParser & Misc & Network & PluginDownloader & Seen & ShrinkUrl & Status & String & Time & Topic & User & Web: Update messages.pot. 2013-11-27 00:02:05 +01:00
Valentin Lorentz
b882b449ec PluginDownloader: If bot is running on Python 3, run 2to3 on installed plugins if they are detected as being designed for Python 2. 2013-11-26 18:13:56 +01:00
Valentin Lorentz
b673cdb037 Merge branch 'testing' of github.com:ProgVal/Limnoria into testing 2013-11-26 16:59:05 +01:00
Valentin Lorentz
b8abbd1e36 Make dependency on python-dateutil optionnal. 2013-11-24 14:47:26 +00:00
Valentin Lorentz
a0c5e06445 PluginDownloader: Add skgsergio's repository. 2013-11-19 18:18:28 +00:00
Valentin Lorentz
289f614bfa Web: Make choice of displayed domain (origin/target) configurable. 2013-11-19 10:20:32 +00:00
Valentin Lorentz
11d8f4655b Web: Display the target domain in snarfer. Re-implements pull request GH-523. 2013-11-19 10:16:43 +00:00
Valentin Lorentz
bdec243909 ChannelStats: Fix error when using @channelstats on a channel the bot did not join. 2013-11-18 20:44:56 +00:00
Valentin Lorentz
6c9b03f70c PluginDownloader: Fix traceback printing. 2013-11-10 17:48:09 +01:00
Valentin Lorentz
fed2bcf9d3 PluginDownloader: Display plugin description on one line. 2013-11-10 17:46:30 +01:00
Valentin Lorentz
2b12a33d82 Tell the users to use the list command if they use the help command without any arguments. Closes GH-516. 2013-11-10 11:27:42 +01:00
Valentin Lorentz
25dc7e092e Fix precedence of shorter Aka commands in Aka. 2013-11-09 21:19:19 +00:00
Valentin Lorentz
3883b3dfd3 Fix infinite recursion in Aka when calling a command in Aka which has a
prefix that is another Aka command.
2013-11-09 20:45:44 +00:00
Valentin Lorentz
cc9f1f0a2c Misc: Fix output of @version. 2013-10-29 17:10:59 +01:00
Valentin Lorentz
5846059c3f Merge branch 'testing' of github.com:ProgVal/Limnoria into testing 2013-10-28 14:17:23 +01:00
Valentin Lorentz
b6ea53b07a Add Python version to 'supybot --version' and @version. 2013-10-27 11:40:10 +01:00
Valentin Lorentz
a67b31c9ea Aka: Fix typo (Error, not error). 2013-10-23 13:42:02 +00:00
James McCoy
4d677dbcf5 Seen: Fix any to work with wildcards when protocols.irc.strictRfc is true
Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2013-10-13 10:00:33 -04:00
Terje Hoås
599f80ec5f Google: Filter out [, before attempting to interpret Googles response as json. 2013-09-25 10:20:43 +02:00
Valentin Lorentz
83a2895e18 Format: Add command @stripformatting. 2013-09-21 12:09:37 +00:00
Valentin Lorentz
26d7fd7aa1 Seen: Fix docstring of @since. 2013-09-14 20:24:13 +02:00
Valentin Lorentz
dfafee3ff2 Misc: Adapt GitHub's version format to the new one (introduced in 0fb2ee1bf7). 2013-09-11 17:17:32 +00:00
Valentin Lorentz
cf975227ba Factoids: Fix help of @random.
Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2013-08-26 21:38:03 -04:00
Valentin Lorentz
81ce98656f Alias: Allow interrogation mark. 2013-08-25 15:41:56 +02:00
Valentin Lorentz
d78ae3de7b Aka: Fix encoding issue with Python 2. 2013-08-25 15:41:06 +02:00
Valentin Lorentz
d26a1a5be9 Aka: Fix typo. 2013-08-25 01:23:53 +02:00
Valentin Lorentz
fba38a5df9 Aka: Prevent overriding of other plugins commands. 2013-08-25 01:07:45 +02:00
James McCoy
0283bb7f9a ShrinkUrl: Fix the check for ur1ca results.
Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2013-08-24 08:51:33 -04:00
Valentin Lorentz
40675ffdfa Merge remote-tracking branch 'supybot/master' into testing
Conflicts:
	plugins/Admin/plugin.py
	plugins/BadWords/config.py
	plugins/Filter/plugin.py
	plugins/Google/plugin.py
	plugins/Math/plugin.py
	plugins/Misc/plugin.py
	plugins/Note/plugin.py
	plugins/RSS/plugin.py
	plugins/Seen/test.py
	plugins/ShrinkUrl/config.py
	plugins/ShrinkUrl/plugin.py
	plugins/ShrinkUrl/test.py
	plugins/Status/plugin.py
	plugins/String/config.py
	plugins/String/plugin.py
	plugins/Time/plugin.py
	plugins/Todo/plugin.py
	plugins/Web/plugin.py
	plugins/__init__.py
	scripts/supybot-botchk
	setup.py
	src/__init__.py
	src/callbacks.py
	src/commands.py
	src/conf.py
	src/drivers/Socket.py
	src/ircdb.py
	src/irclib.py
	src/ircutils.py
	src/questions.py
	src/registry.py
	src/schedule.py
	src/test.py
	src/utils/file.py
	src/utils/gen.py
	src/utils/net.py
	src/utils/web.py
	src/world.py
2013-08-24 11:28:29 +02:00
James McCoy
a483fef39d RSS: Ensure results is declared before trying to access it
Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2013-08-24 00:04:29 -04:00
Arnout Engelen
58e7e61d69 Only reset the cached feed when the response actually contains headlines
Some feeds, such as those from sourceforge.net, will sometimes show an error
page rather than a feed. In this case the feed cache used to be cleared for
that feed, causing all 'old' headlines to be flooded to the channel as soon
as the feed came back online.

This patch hopefully fixes that by only resetting the cache when the returned
page actually contains headlines.

Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2013-08-23 23:13:28 -04:00
Valentin Lorentz
f32f36fea4 Alias: Also allow exclamation marks, as they are allowed by the registry. 2013-08-22 14:03:37 +02:00
Valentin Lorentz
ccafbf4847 Aka: Speed up commands listing by statically listing builtin commands instead of invoking parent's listCommands(). 2013-08-21 20:56:18 +02:00
Valentin Lorentz
d2762d9fb9 Aka: Add explicit error message if sqlalchemy is not installed. 2013-08-21 18:04:16 +02:00
Valentin Lorentz
790bda4664 Web: Fix nesting of commands (bug introduced in d8a4ef8421). 2013-08-20 11:37:39 +02:00
Valentin Lorentz
d14f5df76f ChannelLogger: Rewrite relayed nicks. Closes GH-507. 2013-08-19 17:22:56 +02:00
Valentin Lorentz
1724d6867b Conditional: Fix handling of exceptions. 2013-08-18 17:37:42 +02:00
Valentin Lorentz
43f1e5cd24 Topic: Fix previous commit. 2013-08-17 19:51:17 +00:00
Valentin Lorentz
410472c317 Topic: Change behavior of supybot.plugins.Topic.alwaysSetOnJoin to only apply if the actual topic differs from the default. 2013-08-17 19:30:28 +00:00
Valentin Lorentz
b57be07f1c Topic: Add supybot.plugins.Topic.alwaysSetOnJoin. 2013-08-17 17:48:25 +00:00
Valentin Lorentz
dfdc7f1cd1 Merge pull request #506 from kytvi2p/unicode2.x
Unicode fixes for python 2.x
2013-08-17 07:54:45 -07:00
Kill Your TV
b46a0dd6a2 Unicode fixes for python 2.x
These changes have been tested with Python 3.2.3 and Python 2.7.5.
2013-08-17 14:12:10 +00:00
Valentin Lorentz
e1d0ab2774 Aka: Fix support for non-ascii commands name with Python 2 (bug introduced in 64300b8a02). 2013-08-17 16:12:06 +02:00
Valentin Lorentz
921ff2ae07 Aka: Fix case-sensitivity. 2013-08-17 07:02:21 +00:00
Valentin Lorentz
e120ab7eab User: Add custom error message for @gpg add arguments. 2013-08-16 16:23:08 +02:00
Kill Your TV
56c80e62f1 RSS: fix initialAnnounceHeadlines not being obeyed 2013-08-15 22:32:19 +00:00
Valentin Lorentz
a2f115e09f Alias: Prevent @add from allowing invalid names. 2013-08-15 13:30:12 +02:00
Valentin Lorentz
73f63c25b9 Aka: Fix import of locked alias. 2013-08-15 10:55:57 +02:00
Valentin Lorentz
18cc1ff3bb Revert "Web: Disable @title and @doctype for non-HTML documents." (incompatible with Python 2)
This reverts commit 34b0e5faad.
2013-08-15 00:14:34 +00:00
Valentin Lorentz
13bf8c2915 Aka: Fix crash when logging (on Python 2). 2013-08-11 11:28:53 +00:00
Valentin Lorentz
e5bac7e023 Aka: Fix previous commit. 2013-08-11 11:20:36 +00:00