Allowing Anonymous.say to send a message to either a nick or an
(implicit) channel through the use of first('nick', 'inChannel') changed
the behavior of the command by making it impossible for 'inChannel' to
take effect.
This meant that any previous users of the command that expected "say
some text" to send "some text" to the current channel would instead try
to send "text" to the user "some". Depending on the value of
conf.plugins.Anonymous.allowPrivateTarget, this would result in either
an error or a strange message to a random user.
Creating a new tell command solves this issue as Anonymous.channel now
goes back to its simple 'inChannel' wrapper.
Signed-off-by: James McCoy <vega.james@gmail.com>
* Change default separator to `|` as used by Topic plugin.
* Show links with manual calling and automatic announcement.
* In most of cases we want to know where does new RSS feed title point to...
The (faulty) detection of recursive Aliases was removed in
a656fd0693, claiming that "our nesting
limit will catch issues now." However, nested Aliases weren't actually
increasing the nesting level.
Actually increasing the nesting level when an alias is executed restores
the intended behavior. Additionally, limiting the size of the
expanded arguments to an alias prevents exponential growth of memory
usage for certain malicious inputs/aliases.
Signed-off-by: James McCoy <vega.james@gmail.com>
* plugins.karma.allowunaddressedkarma doesn't mean that the bot must be addressed by nick. It must be addressed, but that can also happen with prefix.
[SKIP CI]
And I thought this was already made clear to Limnoria, but seems that it
wasn't. because the wrong name appears in translations that I don't
remember touching.
[SKIP CI]
* Default separator to `is`.
* It's more used than `as`.
* Help text updated too.
* Default value as `$value`. Like with Topic plugin, the `$key could be`
is just annoyance which users are very likely to disable anyway.
* Most of networks have services with this name.
* I can only name QuakeNet from those that don't, but the default
configuration exludes it.
* If this plugin is loaded in Supybot-wizard, it asks for nicknames of
NickServ and ChanServ.
[SKIP CI] because this is `git commit --amend` and the build already
passed.
Please see https://github.com/TkTech/notifico/issues/79
* > There is a difference between a NOTICE to a channel and a NOTICE to a user, every client should be able to correctly display notices to a channel. ~~ @Dav1dde
* > They should, but they don't. ~~ @Mkaysi
* > That's besides the point. There are a lot of clients that do handle it properly, and if they don't then that's not notifico's fault, that's their own fault. ~~ @sckasturi
* This is default behaviour with ZNC and some other IRC related applications.
* Users are often confused when the logs don't appear.
* The logs will less likely get lost if they are written immediately.
* Gribble is doing this too (but not by default).
