Using Raise=True was only papering over the real problem in the nested
command error handling. The actual issue is that we were trying to
return an IrcMsg from NestedCommandsIrcProxy.__init__. Dropping
Raise=True and moving return to its own line is the correct fix and
resolves the test failure in testMaximumNestingDepth.
This commit reverts 7838cae3bc
Signed-off-by: James McCoy <vega.james@gmail.com>
freecode.com, nee freshmeat.net, is now a completely static site. Since
it is no longer allowing updates, no need to worry about pushing
information about Supybot releases to it.
Signed-off-by: James McCoy <vega.james@gmail.com>
* Change default separator to `|` as used by Topic plugin.
* Show links with manual calling and automatic announcement.
* In most of cases we want to know where does new RSS feed title point to...
The (faulty) detection of recursive Aliases was removed in
a656fd0693, claiming that "our nesting
limit will catch issues now." However, nested Aliases weren't actually
increasing the nesting level.
Actually increasing the nesting level when an alias is executed restores
the intended behavior. Additionally, limiting the size of the
expanded arguments to an alias prevents exponential growth of memory
usage for certain malicious inputs/aliases.
Signed-off-by: James McCoy <vega.james@gmail.com>
* plugins.karma.allowunaddressedkarma doesn't mean that the bot must be addressed by nick. It must be addressed, but that can also happen with prefix.
[SKIP CI]
And I thought this was already made clear to Limnoria, but seems that it
wasn't. because the wrong name appears in translations that I don't
remember touching.
[SKIP CI]
* Default separator to `is`.
* It's more used than `as`.
* Help text updated too.
* Default value as `$value`. Like with Topic plugin, the `$key could be`
is just annoyance which users are very likely to disable anyway.
* Most of networks have services with this name.
* I can only name QuakeNet from those that don't, but the default
configuration exludes it.
* If this plugin is loaded in Supybot-wizard, it asks for nicknames of
NickServ and ChanServ.
[SKIP CI] because this is `git commit --amend` and the build already
passed.
