LimnoriaPlugins/TripSit
6
0
Fork 0
Code Issues 5 Pull Requests 1 Projects Releases Wiki Activity

Drug filtering added to listdose #14

Merged
pratyush merged 1 commits from feat/listdose_drug into master 2024-11-29 23:22:28 +01:00
Conversation 2 Commits 1 Files Changed 1 +28 -13
pratyush commented 2024-11-29 22:48:04 +01:00
Owner
Copy Link

listdose now supports filtering with drug

(listdose [--drug <drug>] <n>) -- Retrieves your <n> last logged doses, optionally filtered by drug.

Signed-off-by: Pratyush Desai pratyush.desai@liberta.casa

listdose now supports filtering with drug `(listdose [--drug <drug>] <n>) -- Retrieves your <n> last logged doses, optionally filtered by drug. ` Signed-off-by: Pratyush Desai <pratyush.desai@liberta.casa>
pratyush added 1 commit 2024-11-29 22:48:04 +01:00 
listdose now supports filtering with drug

Signed-off-by: Pratyush Desai <pratyush.desai@liberta.casa>
Georg reviewed 2024-11-29 22:53:29 +01:00
plugin.py Outdated
@ -280,0 +287,4 @@
rangecheck = doses[-int(history)]
irc.reply(f"Your last {history} dose(s) are:", private=True)
for number in range(history, 0, -1):
lastdose = doses[-int(number)]
Georg commented 2024-11-29 22:53:29 +01:00
Owner
Copy Link

number should already be an integer, not necessary to cast it with int(), but of course not a problem either

`number` should already be an integer, not necessary to cast it with int(), but of course not a problem either
pratyush commented 2024-11-29 23:21:05 +01:00
Author
Owner
Copy Link

neither is the rangecheck = doses[-int(history)] assignment used.

neither is the `rangecheck = doses[-int(history)]` assignment used.
pratyush marked this conversation as resolved
Georg approved these changes 2024-11-29 22:53:43 +01:00
Dismissed
Georg left a comment
Owner
Copy Link

cool :)

cool :)
pratyush force-pushed feat/listdose_drug from e75cdc908d to bcb385d3e8 2024-11-29 23:19:01 +01:00 Compare
pratyush dismissed Georg’s review 2024-11-29 23:19:02 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pratyush merged commit f53ddf450c into master 2024-11-29 23:22:28 +01:00
pratyush deleted branch feat/listdose_drug 2024-11-29 23:22:28 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Priority: Critical
ALAAARM!
Priority: High
Move it!
Priority: Low
classic
Priority: Medium
Meh, it's like Rapid Chess
Status: Pending Merge
PR!
Status: Unitiliased
Just DO IT!
Status: WIP
Ongoing
Type: Bug
Steel your mind, Holmes
Type: Documentation
WTFM
Type: Enhancement
Improvements on existing infrastructure
Type: Feature
Incoming Bugs
Type: Maintenance
-_-
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Georg grapple Mikaela pratyush pytoxic samsepi0l
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LimnoriaPlugins/TripSit#14
No description provided.
Delete Branch "feat/listdose_drug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?