LibertaCasa/salt
LibertaCasa/salt
9
1
Fork 0
Code Issues 5 Pull Requests Releases Activity

cleanup interprotocol bridges #96

Merged
pratyush merged 1 commits from cfg_matterbridge into production 2024-09-07 22:07:23 +02:00
Conversation 4 Commits 1 Files Changed 1 +5 -13
pratyush commented 2024-09-01 18:31:03 +02:00
Owner
Copy Link

updating sshchat label

Remote nick formatting fixes

Remove some redundant linkages

Reroute bridges

Signed-off-by: Pratyush Desai pratyush.desai@liberta.casa

updating sshchat label Remote nick formatting fixes Remove some redundant linkages Reroute bridges Signed-off-by: Pratyush Desai <pratyush.desai@liberta.casa>
pratyush added 1 commit 2024-09-01 18:31:04 +02:00 
updating sshchat label
Remote nick formatting fixes
Remove some redundant linkages
Reroute bridges

Signed-off-by: Pratyush Desai <pratyush.desai@liberta.casa>
pratyush commented 2024-09-01 18:40:10 +02:00
Author
Owner
Copy Link

Hopefully those RemoteNickFormats work as intended. There’s no way all these changes work properly.

Hopefully those `RemoteNickFormat`s work as intended. There's no way all these changes work properly.
Georg reviewed 2024-09-01 18:40:50 +02:00
Georg left a comment
Owner
Copy Link

Some of these lines are obvious, others would be nice to have an explanation for. Though even the obvious ones might be not so obvious some years down the line.

Some of these lines are obvious, others would be nice to have an explanation for. Though even the obvious ones might be not so obvious some years down the line.
pillar/id/dericom02_rigel_lysergic_dev.sls Outdated
@ -85,4 +80,3 @@
petals:
irc.libertacasa: '#Petals'
telegram.libertacasa: '-1001971550949'
keytomb:
Georg commented 2024-09-01 18:40:21 +02:00
Owner
Copy Link

Same here.

Same here.
pratyush commented 2024-09-01 19:08:17 +02:00
Author
Owner
Copy Link

awe

awe
pratyush marked this conversation as resolved
pillar/id/dericom02_rigel_lysergic_dev.sls Outdated
@ -79,3 +77,3 @@
irc.libertacasa: '#chat'
discord.23: chat
xmpp.libertacasa: chat
dota:
Georg commented 2024-09-01 18:40:12 +02:00
Owner
Copy Link

I presume it’s something stale.

I presume it's something stale.
pratyush commented 2024-09-01 19:07:56 +02:00
Author
Owner
Copy Link

yeah

yeah
pratyush marked this conversation as resolved
pillar/id/dericom02_rigel_lysergic_dev.sls Outdated
@ -73,4 +73,3 @@
info:
irc.libertacasa: '#libcasa.info'
xmpp.libertacasa: libcasa.info
#telegram.libertacasa: '-1001518274267'
Georg commented 2024-09-01 18:39:21 +02:00
Owner
Copy Link

What happened to this? Would be cool to have an explanation as well.

What happened to this? Would be cool to have an explanation as well.
pratyush commented 2024-09-01 19:07:33 +02:00
Author
Owner
Copy Link

done

done
pratyush marked this conversation as resolved
pillar/id/dericom02_rigel_lysergic_dev.sls Outdated
@ -40,3 +40,3 @@
telegram.libertacasa:
Token: ${'secret_matterbridge:general:accounts:telegram.libertacasa:Token'}
RemoteNickFormat: '&lt;{NICK}&gt; '
RemoteNickFormat: '[{PROTOCOL}] &lt;{NICK}&gt; '
Georg commented 2024-09-01 18:37:57 +02:00
Owner
Copy Link

Not sure how that will look like in Telepound, but I assume you evaluated it.

Not sure how that will look like in Telepound, but I assume you evaluated it.
pratyush commented 2024-09-01 18:47:40 +02:00
Author
Owner
Copy Link

No lol. Hmm it needs something though. I feel like we had tried it and it didn’t work and so we let it go.

No lol. Hmm it needs something though. I feel like we had tried it and it didn't work and so we let it go.
pratyush commented 2024-09-01 19:02:09 +02:00
Author
Owner
Copy Link

Is there a way to test it without doing the whole procedure and applying the state all over again.

Is there a way to test it without doing the whole procedure and applying the state all over again.
Georg commented 2024-09-01 19:03:35 +02:00
Owner
Copy Link

In production? Not really .. only if you had some local setup, but there you could probably not use the same Telegram channels.

In production? Not really .. only if you had some local setup, but there you could probably not use the same Telegram channels.
pratyush marked this conversation as resolved
pillar/id/dericom02_rigel_lysergic_dev.sls Outdated
@ -70,24 +69,17 @@ profile:
irc.libertacasa: '#lucy'
xmpp.libertacasa: lucy
telegram.libertacasa: '-1001795702961'
sshchat.Psyched: sshchat
Georg commented 2024-09-01 18:38:55 +02:00
Owner
Copy Link

I get this and agree with it, but would have be cool to have an explanation in the commit message.

I get this and agree with it, but would have be cool to have an explanation in the commit message.
pratyush commented 2024-09-01 18:50:15 +02:00
Author
Owner
Copy Link

I had written it but then removed it :( as I felt “rerouting bridges” encompassed that already.

I had written it but then removed it :( as I felt "rerouting bridges" encompassed that already.
Georg commented 2024-09-01 18:51:39 +02:00
Owner
Copy Link

Well I can tell from the diff that you’re “rerouting bridges”, but I can’t tell why you’re doing so. :-)

Well I can tell from the diff that you're "rerouting bridges", but I can't tell why you're doing so. :-)
Georg commented 2024-09-01 18:54:53 +02:00
Owner
Copy Link

Thank you!

Thank you!
pratyush marked this conversation as resolved
Georg commented 2024-09-01 18:41:44 +02:00
Owner
Copy Link

Some bureaucratic nitpicks, otherwise ok.

Some bureaucratic nitpicks, otherwise ok.
pratyush force-pushed cfg_matterbridge from 4e8bf773a6 to 9db1ae0d4b 2024-09-01 18:54:06 +02:00 Compare
pratyush force-pushed cfg_matterbridge from 9db1ae0d4b to 00e7832e9d 2024-09-01 19:05:34 +02:00 Compare
Georg approved these changes 2024-09-01 19:08:14 +02:00
pratyush commented 2024-09-01 19:09:01 +02:00
Author
Owner
Copy Link

gonna yolo the tg remotenickformat stuff.

gonna yolo the tg remotenickformat stuff.
Georg commented 2024-09-01 19:09:35 +02:00
Owner
Copy Link

I pretend that comment doesn’t exist

(but on a more serious note, it looks at least technically correct)

I pretend that comment doesn't exist (but on a more serious note, it looks at least technically correct)
pratyush merged commit 8231c71927 into production 2024-09-07 22:07:23 +02:00
pratyush deleted branch cfg_matterbridge 2024-09-07 22:07:24 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georg
Labels
Clear labels
  
Priority: Critical

   
Priority: High

   
Priority: Low

   
Priority: Medium

   
Type: Sprinkle

Write yaml to salt

No Label
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
Type: Sprinkle
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LibertaCasa/salt#96
No description provided.
Delete Branch "cfg_matterbridge"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?