3
0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-10-04 02:18:49 +02:00

ap: Fix l_settings leak

l_settings is leaked if l_settings_load_from_file() fails.
This commit is contained in:
Denis Kenzior 2021-04-30 11:36:03 -05:00
parent 84ca680611
commit d973c347be

View File

@ -3296,7 +3296,7 @@ static struct l_dbus_message *ap_dbus_start_profile(struct l_dbus *dbus,
{ {
struct ap_if_data *ap_if = user_data; struct ap_if_data *ap_if = user_data;
const char *ssid; const char *ssid;
struct l_settings *config; _auto_(l_settings_free) struct l_settings *config = NULL;
char *config_path; char *config_path;
int err; int err;
@ -3325,8 +3325,6 @@ static struct l_dbus_message *ap_dbus_start_profile(struct l_dbus *dbus,
l_settings_set_string(config, "General", "SSID", ssid); l_settings_set_string(config, "General", "SSID", ssid);
ap_if->ap = ap_start(ap_if->netdev, config, &ap_dbus_ops, &err, ap_if); ap_if->ap = ap_start(ap_if->netdev, config, &ap_dbus_ops, &err, ap_if);
l_settings_free(config);
if (!ap_if->ap) if (!ap_if->ap)
goto error; goto error;