From d973c347be2ad1108f0a92eb2b48e82f8385cc81 Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Fri, 30 Apr 2021 11:36:03 -0500 Subject: [PATCH] ap: Fix l_settings leak l_settings is leaked if l_settings_load_from_file() fails. --- src/ap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/ap.c b/src/ap.c index 06f3432d..6fcee7d6 100644 --- a/src/ap.c +++ b/src/ap.c @@ -3296,7 +3296,7 @@ static struct l_dbus_message *ap_dbus_start_profile(struct l_dbus *dbus, { struct ap_if_data *ap_if = user_data; const char *ssid; - struct l_settings *config; + _auto_(l_settings_free) struct l_settings *config = NULL; char *config_path; int err; @@ -3325,8 +3325,6 @@ static struct l_dbus_message *ap_dbus_start_profile(struct l_dbus *dbus, l_settings_set_string(config, "General", "SSID", ssid); ap_if->ap = ap_start(ap_if->netdev, config, &ap_dbus_ops, &err, ap_if); - l_settings_free(config); - if (!ap_if->ap) goto error;