3
0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-11-22 06:29:23 +01:00

Log falling back from SAE to WPA2

I've had connections to a WPA3-Personal only network fail with no log
message from iwd, and eventually figured out to was because the driver
would've required using CMD_EXTERNAL_AUTH. With the added log messages
the reason becomes obvious.

Additionally the fallback may happen even if the user explicitly
configured WPA3 in NetworkManager, I believe a warning is appropriate
there.
This commit is contained in:
Fiona Klute 2024-01-09 10:59:26 +01:00 committed by Denis Kenzior
parent 5abf54f2dc
commit a6638513d4

View File

@ -248,6 +248,9 @@ static bool wiphy_can_connect_sae(struct wiphy *wiphy)
*
* TODO: No support for CMD_EXTERNAL_AUTH yet.
*/
l_warn("SAE unsupported: %s needs CMD_EXTERNAL_AUTH for SAE",
wiphy->driver_str);
return false;
}
@ -312,8 +315,10 @@ enum ie_rsn_akm_suite wiphy_select_akm(struct wiphy *wiphy,
if (ie_rsne_is_wpa3_personal(info)) {
l_debug("Network is WPA3-Personal...");
if (!wiphy_can_connect_sae(wiphy))
if (!wiphy_can_connect_sae(wiphy)) {
l_debug("Can't use SAE, trying WPA2");
goto wpa2_personal;
}
if (info->akm_suites &
IE_RSN_AKM_SUITE_FT_OVER_SAE_SHA256)