From a6638513d47cefa5c941789de898b8c36d7fc49c Mon Sep 17 00:00:00 2001 From: Fiona Klute Date: Tue, 9 Jan 2024 10:59:26 +0100 Subject: [PATCH] Log falling back from SAE to WPA2 I've had connections to a WPA3-Personal only network fail with no log message from iwd, and eventually figured out to was because the driver would've required using CMD_EXTERNAL_AUTH. With the added log messages the reason becomes obvious. Additionally the fallback may happen even if the user explicitly configured WPA3 in NetworkManager, I believe a warning is appropriate there. --- src/wiphy.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/wiphy.c b/src/wiphy.c index 766df348..3258b761 100644 --- a/src/wiphy.c +++ b/src/wiphy.c @@ -248,6 +248,9 @@ static bool wiphy_can_connect_sae(struct wiphy *wiphy) * * TODO: No support for CMD_EXTERNAL_AUTH yet. */ + l_warn("SAE unsupported: %s needs CMD_EXTERNAL_AUTH for SAE", + wiphy->driver_str); + return false; } @@ -312,8 +315,10 @@ enum ie_rsn_akm_suite wiphy_select_akm(struct wiphy *wiphy, if (ie_rsne_is_wpa3_personal(info)) { l_debug("Network is WPA3-Personal..."); - if (!wiphy_can_connect_sae(wiphy)) + if (!wiphy_can_connect_sae(wiphy)) { + l_debug("Can't use SAE, trying WPA2"); goto wpa2_personal; + } if (info->akm_suites & IE_RSN_AKM_SUITE_FT_OVER_SAE_SHA256)