Fixing Support for H-WASHER 500 #5

2023-03-14T14:33:17+01:00

alexandre-leites commented

2023-03-14 14:33:17 +01:00

(Migrated from github.com)

Hi,

My previous branch was outdated (my bad) and did not had the history methods. Therefore I encountered some issues with it and fixed with this PR. Mostly issues was about trying to set fixed values, or None types.

Please, test compatibility with your device as well.

PS: Python is not the language I know the most, therefore if there is better ways of dealing with stuff, feel free to optmize.

Hi, My previous branch was outdated (my bad) and did not had the history methods. Therefore I encountered some issues with it and fixed with this PR. Mostly issues was about trying to set fixed values, or None types. Please, test compatibility with your device as well. PS: Python is not the language I know the most, therefore if there is better ways of dealing with stuff, feel free to optmize.

Andre0512 (Migrated from github.com) approved these changes 2023-03-14 18:30:07 +01:00

Andre0512 (Migrated from github.com) left a comment

Hi, thank you, looks good! This will also fix #4 and #6 I will test it more careful this time and make a new release 🙂

Hi, thank you, looks good! This will also fix #4 and #6 I will test it more careful this time and make a new release :slightly_smiling_face:

Andre0512 commented

2023-03-14 18:57:11 +01:00

(Migrated from github.com)

All functions works without errors for me, created the new version v0.3.7

Sign in to join this conversation.

No reviewers

Andre0512