Commit Graph

1446 Commits

Author SHA1 Message Date
Shivaram Lingamneni 108ef3f424 don't double-store messages users send to themselves 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni fab0630180 time.Unix still requires normalization to UTC 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 8031085c26 clean up nil checks relevant to always-on join 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 282e7a4d57 don't write to mysql while holding joinPartMutex 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 4472683d58 persist lastSignoff in the database 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 17a89838b8 fix Client.historyStatus 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 8f4c14c783 miscellaneous review fixes 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 82732d5b5d fix behavior of echo-message without message-tags 2020-02-20 01:51:19 -05:00
Shivaram Lingamneni 5892680f60 consolidate sending DMs to targets with sending copies to non-originating sessions 2020-02-20 01:51:19 -05:00
Shivaram Lingamneni ef161c47ed use custime.Duration for more config fields 2020-02-20 00:09:39 -05:00
Shivaram Lingamneni 7b3caed20f fix/enhancement to custime 2020-02-19 02:45:50 -05:00
Shivaram Lingamneni e59aa43225 fix StringToBool (thanks @wrmsr) 2020-02-19 00:54:42 -05:00
Shivaram Lingamneni ad32356e34 move authentication data from Client to Session 2020-02-19 00:24:21 -05:00
Shivaram Lingamneni 33dac4c0ba initial persistent history implementation 2020-02-19 00:24:12 -05:00
Shivaram Lingamneni 306ca986a8 minor fixes 2020-02-11 22:08:41 -05:00
Shivaram Lingamneni 0c2d8adeac improve maintainability and license compliance
0. Maximum parity with upstream code
1. Added Apache-required modification notices
2. Added Apache license
2020-02-11 16:13:12 -05:00
Shivaram Lingamneni c13597f807 additional LDAP support 2020-02-11 06:35:17 -05:00
Matt Ouille 5ba2527eb0 Fix compilation errors 2020-02-09 22:13:12 -05:00
Matt Ouille d4afb027e5 Add LDAP support 2020-02-09 22:13:02 -05:00
Shivaram Lingamneni b964a201c1 fix #776 2020-02-07 13:28:49 -05:00
Shivaram Lingamneni a3f008e348 mitigate #772 2020-02-06 17:56:10 -05:00
Shivaram Lingamneni 88d7e98011 add vhost snomasks 2020-02-02 02:03:08 -05:00
Shivaram Lingamneni 5426c9fdc0 disallow TAKE and REQUEST while under a FORBID 2020-02-01 23:51:29 -05:00
Shivaram Lingamneni e1f56aaee3 fix #764 2020-02-01 22:19:33 -05:00
Shivaram Lingamneni 52d85517cd actually fix #760 2020-01-29 16:27:59 -05:00
Shivaram Lingamneni fd46874ad3 fix #760 2020-01-29 15:45:50 -05:00
Shivaram Lingamneni b329cf430e
Merge pull request #744 from slingamn/hostserv_offer.1
add support for offering vhosts
2020-01-28 19:36:17 -08:00
Shivaram Lingamneni 955cdbdfef impose throttle checks on HS TAKE 2020-01-28 22:27:56 -05:00
Shivaram Lingamneni dedf78d0e9 review fixes 2020-01-28 21:23:31 -05:00
Shivaram Lingamneni 7d3c0f7884 fix #757 2020-01-27 21:10:24 -05:00
Shivaram Lingamneni 166dc60729 fix #753
Also add +C no-ctcp mode, since it's not conflicted
2020-01-26 21:07:20 -05:00
Shivaram Lingamneni 1fc9a04503 fix #754 2020-01-25 21:06:55 -05:00
Shivaram Lingamneni 6e2b2a44b8 set the time of a multiline message at BATCH - 2020-01-20 00:37:13 -05:00
Shivaram Lingamneni 5d662742b9 remove oragono.io/maxline-2 and fmsgid 2020-01-18 23:47:05 -05:00
Shivaram Lingamneni 0cebdba82c
Merge pull request #750 from slingamn/isupport_fix
fix incorrect values of UTF8MAPPING for non-PRECIS casefoldings
2020-01-14 13:11:53 -05:00
Shivaram Lingamneni d807f1252f move generateISupport to config.go 2020-01-14 01:21:47 -05:00
Shivaram Lingamneni 3ff586e821 don't read globalCasemappingSetting in generateISupport
The isupport is always a pure function of the Config object,
not of Server or any globals.
2020-01-14 01:19:48 -05:00
Shivaram Lingamneni 90b428b416 fix #745 2020-01-12 11:24:11 -05:00
Shivaram Lingamneni 2db14c91b9 review fixes 2020-01-11 22:52:30 -05:00
Shivaram Lingamneni 05cb80507f fix #741 2020-01-11 22:43:40 -05:00
Shivaram Lingamneni 11ca86028c fix #741 2020-01-09 13:49:36 -05:00
Shivaram Lingamneni 6838d19acc don't check the real IP for bans on proxy-before-TLS
In the k8s PROXY-before-TLS setting, we don't know all the IPs
of the load balancers, so we can't whitelist them, so they're at
risk of being d-lined.
2020-01-09 04:38:59 -05:00
Shivaram Lingamneni 2110f3dad7 fix #705 2020-01-08 02:20:37 -05:00
Shivaram Lingamneni eb630b7657 Revert "never set the certfp lookup key before verification"
This reverts commit a120cc2443.
2020-01-06 15:00:26 -05:00
Shivaram Lingamneni a120cc2443 never set the certfp lookup key before verification 2020-01-06 12:53:21 -05:00
Shivaram Lingamneni 1b35c6887f fix #733 2020-01-06 12:21:52 -05:00
Shivaram Lingamneni 1ae38091a3
Merge pull request #728 from slingamn/issue727_group_ghost.1
fix #727
2020-01-05 03:26:26 -05:00
Shivaram Lingamneni d67d77bee7 fix #731 2020-01-03 09:46:55 -05:00
Shivaram Lingamneni bc0712b19b fix #727 2019-12-31 21:19:28 -05:00
Shivaram Lingamneni bd822853bc fix some translation warnings 2019-12-30 14:47:22 -05:00
Shivaram Lingamneni f920d3b79f fix #530, #721 2019-12-29 12:05:01 -05:00
Shivaram Lingamneni 9de9fcf069
Merge pull request #695 from slingamn/issue693_casemappings.4
#693: configurable casemappings
2019-12-29 09:20:06 -05:00
Shivaram Lingamneni f6757f814e
Merge pull request #707 from slingamn/multiline.4
implement draft/multiline
2019-12-26 23:18:54 -05:00
Shivaram Lingamneni 47ac8e984f remove unnecessary helper 2019-12-26 22:54:00 -05:00
Shivaram Lingamneni 68e3b74b79
Merge pull request #717 from slingamn/issue716
fix #716
2019-12-25 21:11:53 -05:00
Shivaram Lingamneni 8c1db7a2f5 better UX for cancelling channel transfers 2019-12-25 15:59:38 -05:00
Shivaram Lingamneni 33c8b2177e fix a bug
In the previous commit, the client would receive a failure message but would
actually remain logged in after an authzid/authcid mismatch. This was a
correctness rather than a security issue, but now it's fixed so that the client
never logs in in the first place.
2019-12-25 15:06:26 -05:00
Shivaram Lingamneni c8ccf94936 fix #716 2019-12-25 12:44:55 -05:00
Shivaram Lingamneni 9b5d6bf746 fix #713 2019-12-24 16:20:18 -05:00
Shivaram Lingamneni 1487980fe0 Fix #710 2019-12-24 15:03:37 -05:00
Shivaram Lingamneni cd3ff3922e fill in more authzid/authcid details 2019-12-24 12:46:31 -05:00
Pavel Djundik 6831b0ffdc
Fix `authcid` variable name 2019-12-24 19:33:33 +02:00
Shivaram Lingamneni 358c4b7d81 implement draft/multiline 2019-12-24 09:29:54 -05:00
Shivaram Lingamneni 7a6925fa3f Merge remote-tracking branch 'origin/master' into issue702 2019-12-23 11:32:15 -05:00
Shivaram Lingamneni bf5a02f077
Merge pull request #692 from slingamn/issue683_channelpurge.1
chanserv enhancements and miscellaneous fixes
2019-12-22 10:41:24 -05:00
Shivaram Lingamneni 4391b1ba5a restrict ASCII mode to printable characters only 2019-12-22 09:57:49 -05:00
Shivaram Lingamneni 781bb6b051 more systematic bad-character check in permissive mode 2019-12-22 09:31:51 -05:00
Shivaram Lingamneni 2d4dbeba1c disallow some bad characters in foldPermissive 2019-12-22 09:19:28 -05:00
Shivaram Lingamneni 76a8768d05 make rehash-enable logic a little more uniform 2019-12-22 08:42:56 -05:00
Shivaram Lingamneni bd6c2117e8 fix analogous issue for history
History couldn't be enabled by rehash if autoresize-window was nonzero.
2019-12-22 08:11:24 -05:00
Shivaram Lingamneni 26ca016c66 fix the analogous issue for vhosts 2019-12-21 20:26:40 -05:00
Shivaram Lingamneni 25c4eb2996 fix #702 2019-12-21 20:19:19 -05:00
Shivaram Lingamneni 0df25e0e30 remove redundant error check 2019-12-19 18:41:46 -05:00
Shivaram Lingamneni c4e66d8b83
Merge pull request #698 from slingamn/issue616_prefs.2
fix #616
2019-12-19 18:38:18 -05:00
Shivaram Lingamneni 9bc5fb78cf
Merge pull request #700 from slingamn/issue347_snomasks
fix #347
2019-12-19 18:35:19 -05:00
Shivaram Lingamneni 01488bfe2e slightly more defensive implementation of /OPER check 2019-12-19 18:30:19 -05:00
Shivaram Lingamneni 78da024b24 improve an error message 2019-12-19 09:30:49 -05:00
Shivaram Lingamneni 0c33c3399f fix #347 2019-12-19 09:27:54 -05:00
Shivaram Lingamneni b717402b5e implement review feedback
1. If both fingerprint and hash are specified, require both instead of either
2. Implement auto-oper on connect
2019-12-19 06:33:43 -05:00
Shivaram Lingamneni 6033d9f569 tweaks for consistency 2019-12-18 20:33:58 -05:00
Shivaram Lingamneni 6740222ecb fix #616 2019-12-18 17:38:14 -05:00
Shivaram Lingamneni e143aaa83f fix #696 2019-12-18 16:04:43 -05:00
Shivaram Lingamneni f9b5224ae0 have realSkeleton use cases.Fold as well 2019-12-18 12:26:09 -05:00
Shivaram Lingamneni 91d6888b7e fix #693 2019-12-18 12:26:09 -05:00
Shivaram Lingamneni ab444a3980 remove unnecessary uses of Casefold 2019-12-18 12:21:03 -05:00
Shivaram Lingamneni f1e2bbc0e4 more permissive hostname validation
In particular, allow hostnames without periods (like on a LAN).
This shouldn't be a client compability concern since we allow
vhosts without periods.
2019-12-18 09:21:45 -05:00
Shivaram Lingamneni 4b37b5dd3e tweak to avoid a potential data race 2019-12-17 19:57:23 -05:00
Shivaram Lingamneni b468baa959 allow NS SESSIONS targeting yourself 2019-12-17 19:37:33 -05:00
Shivaram Lingamneni 3480f124cd fix #688 2019-12-17 19:37:33 -05:00
Shivaram Lingamneni c5a81d59ff fix #581 2019-12-17 13:21:26 -05:00
Shivaram Lingamneni 07865b8f63 chanserv enhancements and miscellaneous fixes
* Fix #684
* Fix #683
* Add `CHANSERV CLEAR`
* Allow mode changes from channel founders even when they aren't joined
* Operators with the chanreg capability are exempt from max-channels-per-account
* Small fixes and cleanup
2019-12-16 20:06:52 -05:00
Shivaram Lingamneni 438d1f0488 fix bad ERR_WASNOSUCHNICK responses 2019-12-05 08:31:17 -05:00
Shivaram Lingamneni bcc58be8af remove some redundant casefolds 2019-12-05 07:44:28 -05:00
Shivaram Lingamneni 08f351060e fix #682 2019-12-05 07:29:27 -05:00
Shivaram Lingamneni 0880f20f4b fix analogous invalid parameters for ERR_NOSUCHNICK 2019-12-05 06:52:07 -05:00
Shivaram Lingamneni aa8579b6e8 Assorted fixes
* Fix #679 (borked reply to `JOIN #chan,\r\n`)
* Replace invalid error parameters with *'s in various places
* Fix PART with no message sending an empty trailing parameter to the channel
* Fix some error responses not getting labeled
2019-12-02 21:13:09 -05:00
Shivaram Lingamneni fec1139dc8
Merge pull request #673 from slingamn/proxytls.18
fix #561, take two
2019-11-23 22:09:45 -05:00
Shivaram Lingamneni c6bd0aea8d
Merge pull request #672 from slingamn/issue671
fix #671
2019-11-23 22:09:37 -05:00
Shivaram Lingamneni 2d456c2106 review feedback: rename a key 2019-11-23 22:01:24 -05:00
Shivaram Lingamneni 7432ef07a7 rename some variables for clarity 2019-11-20 17:43:45 -05:00
Shivaram Lingamneni 50783d5276 fix #561, take 2 2019-11-20 17:35:35 -05:00
Shivaram Lingamneni 42db1778ac unexport rawLimiterConfig 2019-11-18 17:30:54 -05:00
Shivaram Lingamneni babd8b1da9 fix #671 2019-11-18 17:21:28 -05:00
Shivaram Lingamneni 4050b6571a fix #646
Includes a partially backwards-incompatible config change
2019-11-18 01:47:18 -05:00
Shivaram Lingamneni 149c9b45e8 bump version 2019-11-16 18:49:30 -05:00
Shivaram Lingamneni d1ed5e4cbf bump version and changelog 2019-11-16 18:14:20 -05:00
Shivaram Lingamneni ae9aecbbb0 increase max cap line length
Workaround for #661: this makes the `CAP LS 302` line from the default config
fit on a single line, as long as the server name is at most 35 characters.
2019-11-09 22:43:07 -05:00
Shivaram Lingamneni a75d26a46b refactor cap line splitting 2019-11-09 20:31:39 -05:00
Shivaram Lingamneni 507740464a bump version 2019-11-03 12:39:13 -05:00
Shivaram Lingamneni b6cdb51f00 fix #652 2019-10-23 11:32:32 -04:00
Shivaram Lingamneni baa71ba2be remove unnecessary special-casing for ASCII 2019-10-23 02:18:45 -04:00
Shivaram Lingamneni 82c5041225 fix #649 2019-10-16 18:10:32 -04:00
Shivaram Lingamneni 332f0d8d91 fix #644 2019-10-16 12:51:40 -04:00
Shivaram Lingamneni cddc51d6cf
Merge pull request #640 from slingamn/issue639_emptystruct.1
make semaphores O(1) in storage
2019-10-12 18:13:07 -07:00
Shivaram Lingamneni 24c103da5a fix #642 2019-10-05 23:50:11 -04:00
Shivaram Lingamneni 40df122c73 remove unused getters 2019-10-04 02:08:49 -04:00
Shivaram Lingamneni 45476079a1 make semaphores O(1) in storage 2019-10-03 00:03:00 -04:00
Shivaram Lingamneni 06b1e7b603 fix #632 2019-09-24 21:47:37 -04:00
Shivaram Lingamneni c1acf3ea43 move ISUPPORT regeneration to the end of config loading 2019-09-22 17:26:50 -04:00
Shivaram Lingamneni 1ce716582a make CHANTYPES a constant 2019-09-22 15:48:17 -04:00
Shivaram Lingamneni 584f2261a8 fix #625 2019-09-22 15:45:06 -04:00
Shivaram Lingamneni 3cb9234bb5 review fixes 2019-09-08 06:28:48 -04:00
Shivaram Lingamneni f6eb8fa5a1 fix #197 2019-09-01 02:36:56 -04:00
Shivaram Lingamneni 8a33d68cf1 add cap-notify for bouncer 2019-08-31 22:42:51 -04:00
Shivaram Lingamneni ca17e58b3a fix #595 2019-08-31 21:29:23 -04:00
Shivaram Lingamneni 7ed27d4a42 Fix #448, #594 2019-08-27 03:58:04 -04:00
Shivaram Lingamneni 65834c0729 optimize Sessions() at the expense of AddSession() 2019-08-02 00:20:31 -04:00
Daniel Oaks 8bca8a1752
Merge pull request #606 from slingamn/issue331.1
fix #331
2019-07-31 06:37:23 +10:00
Daniel Oaks 7a56c4e0ad
Merge pull request #591 from slingamn/history_autoresize.4
autoresizing of history buffers (#349)
2019-07-31 06:36:35 +10:00
Shivaram Lingamneni 938ce7e435 fix #331 2019-07-14 16:17:37 -04:00
Daniel Oaks 07bb38ecdf
Merge pull request #601 from slingamn/spurious_message
fix spurious error message
2019-07-14 12:57:09 +10:00
Shivaram Lingamneni ce651b4a90 remove obsolete consistency check
tor-listeners.listeners was checked against listen,
but listen is obsolete now, so config load would fail
on a config that used the new style `listeners` instead of
`listen` --- unless tor-listeners.listeners was empty, which
it should be under the new style, but there's no need to enforce
that
2019-07-12 15:19:43 -04:00
Shivaram Lingamneni 80aa77372b fix spurious error message 2019-07-12 11:49:01 -04:00
Shivaram Lingamneni ecf945038f
Merge pull request #565 from slingamn/listener_refactor.3
refactor listener config loading
2019-07-12 11:08:04 -04:00
Shivaram Lingamneni 86ad402203 review feedback 2019-07-12 09:58:14 -04:00
Daniel Oaks dc87ae7ef1
Merge pull request #583 from slingamn/stats.4
fix #526
2019-07-12 23:39:50 +10:00
Daniel Oaks b396d41375
Merge pull request #585 from slingamn/samode_bug
fix bugs affecting SAMODE on other users
2019-07-12 23:31:38 +10:00
Daniel Oaks 23974af345
Merge pull request #588 from slingamn/servicehelp.5
refactor /HELP for services
2019-07-12 23:30:50 +10:00
Daniel Oaks 5cff9bb636
Merge pull request #593 from slingamn/issue592
fix #592
2019-07-12 23:27:34 +10:00
Shivaram Lingamneni bbf6c4a269 fix #572 2019-07-08 22:04:53 -04:00
Shivaram Lingamneni cbabccc2f8 fix #592 2019-07-04 07:05:38 -04:00
Shivaram Lingamneni 6e9a728354 autoresizing of history buffers (#349) 2019-07-03 21:08:37 -04:00
Shivaram Lingamneni 1c583d775c refactor /HELP for services
1. DRY "banner" descriptions of each services
2. `/HELP NICKSERV` now refers the user to `/NICKSERV HELP`, etc.
3. Fix double translation of `textGenerator` output
2019-07-02 12:48:33 -04:00
Shivaram Lingamneni 6a3d2733d6 fix bugs affecting SAMODE on other users
1. Your own snomasks would be reported as belonging to the other user
2. Prefixes were incorrect
2019-07-02 08:45:14 -04:00
Shivaram Lingamneni 5a554ab4b0 fix #526 2019-07-01 09:21:38 -04:00
Shivaram Lingamneni 22c298d337 fix #567 2019-06-28 16:40:51 -04:00
Shivaram Lingamneni eee0747e5e new format for listener section 2019-06-28 14:43:53 -04:00
Shivaram Lingamneni cfe991a335 Merge remote-tracking branch 'origin/master' into listener_refactor.4 2019-06-28 09:05:07 -04:00
Daniel Oaks a5d09c932c
Merge pull request #557 from slingamn/issue555.2
upgrade to draft/labeled-response-0.2
2019-06-28 22:18:42 +10:00
Daniel Oaks 9ce3bed4a2 Setup v1.2.0-unreleased devel ver 2019-06-28 22:17:43 +10:00