do an actual nonblocking send instead of the len() trick

irc/socket.go

@@ -121,8 +121,6 @@ func (socket *Socket) Read() (string, error) {
 // Write sends the given string out of Socket.
 func (socket *Socket) Write(data string) (err error) {
 	socket.Lock()
-	defer socket.Unlock()
-
 	if socket.closed {
 		err = io.EOF
 	} else if uint64(len(data)+len(socket.buffer)) > socket.MaxSendQBytes {
@@ -131,12 +129,13 @@ func (socket *Socket) Write(data string) (err error) {
 	} else {
 		socket.buffer = append(socket.buffer, data...)
 	}
+	socket.Unlock()
 
-	// this can generate a spurious wakeup, since we are racing against the channel read,
+	// notify the consumer that data is available
-	// but since we are holding the mutex, we are not racing against the other writes
+	select {
-	// and therefore we cannot miss a wakeup or block
+	case socket.lineToSendExists <- true:
-	if len(socket.lineToSendExists) == 0 {
+	default:
-		socket.lineToSendExists <- true
+		// a notification is already in the queue, this is fine
 	}
 
 	return