Georg/OOMAnalyser
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused return code in OOMAnalyser._choose_kernel_config()

Browse Source
This commit is contained in:
Carsten Grohmann 2022-11-19 11:45:51 +01:00
parent 50103374e7
commit efa1facafd
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
OOMAnalyser.py
View File

@ -2753,7 +2753,6 @@ class OOMAnalyser:
Choose the first matching kernel configuration from AllKernelConfigs Choose the first matching kernel configuration from AllKernelConfigs
@see: _check_kversion_greater_equal(), AllKernelConfigs @see: _check_kversion_greater_equal(), AllKernelConfigs
@rtype: bool
""" """
for kcfg in AllKernelConfigs: for kcfg in AllKernelConfigs:
if self._check_kversion_greater_equal( if self._check_kversion_greater_equal(
@ -2769,8 +2768,7 @@ class OOMAnalyser:
) )
) )
self.oom_result.kconfig = BaseKernelConfig() self.oom_result.kconfig = BaseKernelConfig()
# FIXME: Return value is always True, but OOMAnalyser.analyse() has a useless check return
return True
def _check_for_empty_oom(self): def _check_for_empty_oom(self):
""" """
@ -3148,9 +3146,7 @@ class OOMAnalyser:
error(self.oom_result.error_msg) error(self.oom_result.error_msg)
return False return False
if not self._choose_kernel_config(): self._choose_kernel_config()
error(self.oom_result.error_msg)
return False
if not self._check_for_complete_oom(): if not self._check_for_complete_oom():
error(self.oom_result.error_msg) error(self.oom_result.error_msg)