From efa1facafd991c111549f31e17ecb0075a3c1d4e Mon Sep 17 00:00:00 2001 From: Carsten Grohmann Date: Sat, 19 Nov 2022 11:45:51 +0100 Subject: [PATCH] Remove unused return code in OOMAnalyser._choose_kernel_config() --- OOMAnalyser.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/OOMAnalyser.py b/OOMAnalyser.py index 26add4e..25b3e27 100644 --- a/OOMAnalyser.py +++ b/OOMAnalyser.py @@ -2753,7 +2753,6 @@ class OOMAnalyser: Choose the first matching kernel configuration from AllKernelConfigs @see: _check_kversion_greater_equal(), AllKernelConfigs - @rtype: bool """ for kcfg in AllKernelConfigs: if self._check_kversion_greater_equal( @@ -2769,8 +2768,7 @@ class OOMAnalyser: ) ) self.oom_result.kconfig = BaseKernelConfig() - # FIXME: Return value is always True, but OOMAnalyser.analyse() has a useless check - return True + return def _check_for_empty_oom(self): """ @@ -3148,9 +3146,7 @@ class OOMAnalyser: error(self.oom_result.error_msg) return False - if not self._choose_kernel_config(): - error(self.oom_result.error_msg) - return False + self._choose_kernel_config() if not self._check_for_complete_oom(): error(self.oom_result.error_msg)