this commit makes `service name` to consider pillar provided values,
fallback to a consistent `service name` when {archive|package} is available
for the component, or to `service name == name` when no other value
is provided
BREAKING CHANGE: The golang clientib is not required for
the regular use of this formula but, if you already expected it to be
installed by default, you'll need to update your pillars to do so.
Running this version of the formula over previous ones won't break the
minions, only skip clientlibs.
BREAKING CHANGE: The data dictionary is simplified and expanded.
Retest your states and update pillar data accordingly.
For developer convenience, clientlibs states were introduced.
See pillar.example, defaults.yaml, and docs/README.
```bash
Examining prometheus/archive/alternatives/install.sls of type state
[206] Jinja variables should have spaces before and after: {{ var_name }}
prometheus/archive/alternatives/install.sls:21
- name: update-alternatives --install {{ p.dir.basedir }}/{{ name }} prometheus-{{ name }}-home {{ p.dir.basedir }}/{{ bundle }} {{p.linux.altpriority}}
[204] Lines should be no longer that 160 chars
prometheus/archive/alternatives/install.sls:50
- name: update-alternatives --install /usr/local/bin/{{ b }} prometheus-{{ name }}-{{ b }} {{ p.dir.basedir }}/{{ bundle }}/{{ b }} {{ p.linux.altpriority }}
```
* Semi-automated using `ssf-formula` (v0.5.0)
* Fix errors shown below:
```bash
prometheus-formula$ $(grep "\- yamllint" .travis.yml | sed -e "s:^\s\+-\s\(.*\):\1:")
./prometheus/osfamilymap.yaml
1:89 error line too long (116 > 88 characters) (line-length)
1:24 error trailing spaces (trailing-spaces)
13:2 error syntax error: found character '%' that cannot start any token
24:89 error line too long (90 > 88 characters) (line-length)
25:89 error line too long (167 > 88 characters) (line-length)
./prometheus/defaults.yaml
6:13 error too many spaces inside braces (braces)
6:35 error too many spaces inside braces (braces)
7:11 error too many spaces inside braces (braces)
7:25 error too many spaces inside braces (braces)
8:22 warning truthy value should be one of [false, true] (truthy)
9:25 warning truthy value should be one of [false, true] (truthy)
49:85 error trailing spaces (trailing-spaces)
103:20 warning truthy value should be one of [false, true] (truthy)
104:25 warning truthy value should be one of [false, true] (truthy)
108:16 warning truthy value should be one of [false, true] (truthy)
113:24 warning missing starting space in comment (comments)
pillar.example
31:6 warning missing starting space in comment (comments)
32:8 warning missing starting space in comment (comments)
32:7 warning comment not indented like content (comments-indentation)
51:5 warning comment not indented like content (comments-indentation)
65:89 error line too long (110 > 88 characters) (line-length)
68:29 error too many spaces after colon (colons)
68:34 warning too few spaces before comment (comments)
68:89 error line too long (106 > 88 characters) (line-length)
69:34 warning too few spaces before comment (comments)
69:89 error line too long (98 > 88 characters) (line-length)
75:9 error wrong indentation: expected 10 but found 8 (indentation)
76:11 error wrong indentation: expected 12 but found 10 (indentation)
77:13 warning comment not indented like content (comments-indentation)
79:89 error line too long (101 > 88 characters) (line-length)
81:9 warning comment not indented like content (comments-indentation)
86:89 error line too long (103 > 88 characters) (line-length)
91:11 error wrong indentation: expected 12 but found 10 (indentation)
106:15 error wrong indentation: expected 16 but found 14 (indentation)
108:41 warning too few spaces before comment (comments)
118:89 error line too long (96 > 88 characters) (line-length)
139:13 error wrong indentation: expected 14 but found 12 (indentation)
143:7 error wrong indentation: expected 8 but found 6 (indentation)
145:9 error wrong indentation: expected 10 but found 8 (indentation)
157:6 warning missing starting space in comment (comments)
158:20 error too many spaces inside braces (braces)
158:47 error too many spaces inside braces (braces)
```
