Merge pull request #179 from n-rodriguez/wip/semantic-release

feat(semantic-release): add support of semantic-release

.gitignore

@@ -0,0 +1,110 @@
+# Byte-compiled / optimized / DLL files
+__pycache__/
+*.py[cod]
+*$py.class
+
+# C extensions
+*.so
+
+# Distribution / packaging
+.Python
+env/
+build/
+develop-eggs/
+dist/
+downloads/
+eggs/
+.eggs/
+lib/
+lib64/
+parts/
+sdist/
+var/
+wheels/
+*.egg-info/
+.installed.cfg
+*.egg
+
+# PyInstaller
+#  Usually these files are written by a python script from a packager
+#  before PyInstaller builds the exe, so as to inject date/other infos into it.
+*.manifest
+*.spec
+
+# Installer logs
+pip-log.txt
+pip-delete-this-directory.txt
+
+# Unit test / coverage reports
+htmlcov/
+.tox/
+.coverage
+.coverage.*
+.cache
+nosetests.xml
+coverage.xml
+*.cover
+.hypothesis/
+.kitchen
+.kitchen.local.yml
+kitchen.local.yml
+
+# Translations
+*.mo
+*.pot
+
+# Django stuff:
+*.log
+local_settings.py
+
+# Flask stuff:
+instance/
+.webassets-cache
+
+# Scrapy stuff:
+.scrapy
+
+# Sphinx documentation
+docs/_build/
+
+# PyBuilder
+target/
+
+# Jupyter Notebook
+.ipynb_checkpoints
+
+# pyenv
+.python-version
+
+# celery beat schedule file
+celerybeat-schedule
+
+# SageMath parsed files
+*.sage.py
+
+# dotenv
+.env
+
+# virtualenv
+.venv
+venv/
+ENV/
+
+# Spyder project settings
+.spyderproject
+.spyproject
+
+# Rope project settings
+.ropeproject
+
+# mkdocs documentation
+/site
+
+# mypy
+.mypy_cache/
+
+# Bundler
+Gemfile.lock
+
+# copied `.md` files used for conversion to `.rst` using `m2r`
+docs/*.md

.travis.yml

@@ -0,0 +1,90 @@
+stages:
+  - test
+  - commitlint
+  - name: release
+    if: branch = master AND type != pull_request
+
+sudo: required
+cache: bundler
+language: ruby
+
+services:
+  - docker
+
+# Make sure the instances listed below match up with
+# the `platforms` defined in `kitchen.yml`
+# NOTE: Please try to select up to six instances that add some meaningful
+#       testing of the formula's behaviour. If possible, try to refrain from
+#       the classical "chosing all the instances because I want to test on
+#       another/all distro/s" trap: it will just add time to the testing (see
+#       the discussion on #121).  As an example, the set chosen below covers
+#       the most used distros families, systemd and non-systemd and the latest
+#       three supported Saltstack versions with python2 and 3."
+#       As for `kitchen.yml`, that should still contain all of the platforms,
+#       to allow for comprehensive local testing
+#       Ref: https://github.com/saltstack-formulas/template-formula/issues/118
+#       Ref: https://github.com/saltstack-formulas/template-formula/issues/121
+env:
+  matrix:
+    # Disable tests on Salt develop for now
+    # See: https://travis-ci.com/saltstack-formulas/php-formula/jobs/211316835
+    # - INSTANCE: default-debian-9-develop-py3
+    # - INSTANCE: default-ubuntu-1804-develop-py3
+    # - INSTANCE: default-centos-7-develop-py3
+    # - INSTANCE: default-fedora-29-develop-py3
+    # - INSTANCE: default-opensuse-leap-15-develop-py3
+    # - INSTANCE: default-debian-9-2019-2-py3
+    - INSTANCE: default-ubuntu-1804-2019-2-py3
+    - INSTANCE: default-centos-7-2019-2-py3
+    # - INSTANCE: default-fedora-29-2019-2-py3
+    # - INSTANCE: default-opensuse-leap-15-2019-2-py3
+    # - INSTANCE: default-debian-9-2018-3-py2
+    # - INSTANCE: default-ubuntu-1604-2018-3-py2
+    # - INSTANCE: default-centos-7-2018-3-py2
+    - INSTANCE: default-fedora-29-2018-3-py2
+    # TODO: Use this when fixed instead of `opensuse-leap-42`
+    # Ref: https://github.com/netmanagers/salt-image-builder/issues/2
+    # - INSTANCE: default-opensuse-leap-15-2018-3-py2
+    - INSTANCE: default-opensuse-leap-42-2018-3-py2
+    # - INSTANCE: default-debian-8-2017-7-py2
+    # - INSTANCE: default-ubuntu-1604-2017-7-py2
+    # TODO: Enable after improving the formula to work with other than `systemd`
+    - INSTANCE: default-centos-6-2017-7-py2
+    # - INSTANCE: default-fedora-28-2017-7-py2
+    # - INSTANCE: default-opensuse-leap-42-2017-7-py2
+
+script:
+  - bundle exec kitchen verify ${INSTANCE}
+
+jobs:
+  include:
+    # Define the commitlint stage
+    - stage: commitlint
+      language: node_js
+      node_js: lts/*
+      before_install: skip
+      script:
+        - npm install @commitlint/config-conventional -D
+        - npm install @commitlint/travis-cli -D
+        - commitlint-travis
+    # Define the release stage that runs semantic-release
+    - stage: release
+      language: node_js
+      node_js: lts/*
+      before_install: skip
+      script:
+        # Update `AUTHORS.md`
+        - export MAINTAINER_TOKEN=${GH_TOKEN}
+        - go get github.com/myii/maintainer
+        - maintainer contributor
+
+        # Install all dependencies required for `semantic-release`
+        - npm install @semantic-release/changelog@3 -D
+        - npm install @semantic-release/exec@3 -D
+        - npm install @semantic-release/git@7 -D
+      deploy:
+        provider: script
+        skip_cleanup: true
+        script:
+          # Run `semantic-release`
+          - npx semantic-release@15

FORMULA

@@ -0,0 +1,9 @@
+name: php
+os: Debian, Ubuntu, RedHat, Fedora, CentOS, Suse, openSUSE
+os_family: Debian, RedHat, Suse
+version: 1.0.0
+release: 1
+minimum_version: 2017.7
+summary: Php formula
+description: Formula to use to install and configure php
+top_level_dir: php

Gemfile

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gem 'kitchen-docker', '>= 2.9'
+gem 'kitchen-salt',   '>= 0.6.0'
+gem 'kitchen-inspec', '>= 1.1'

bin/kitchen

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'kitchen' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("test-kitchen", "kitchen")

commitlint.config.js

@@ -0,0 +1,3 @@
+module.exports = {
+    extends: ['@commitlint/config-conventional'],
+};

docs/CONTRIBUTING.rst

@@ -0,0 +1,158 @@
+.. _contributing:
+
+How to contribute
+=================
+
+This document will eventually outline all aspects of guidance to make your contributing experience a fruitful and enjoyable one.
+What it already contains is information about *commit message formatting* and how that directly affects the numerous automated processes that are used for this repo.
+It also covers how to contribute to this *formula's documentation*.
+
+.. contents:: **Table of Contents**
+
+Overview
+--------
+
+Submitting a pull request is more than just code!
+To achieve a quality product, the *tests* and *documentation* need to be updated as well.
+An excellent pull request will include these in the changes, wherever relevant.
+
+Commit message formatting
+-------------------------
+
+Since every type of change requires making Git commits,
+we will start by covering the importance of ensuring that all of your commit
+messages are in the correct format.
+
+Automation of multiple processes
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+This formula uses `semantic-release <https://github.com/semantic-release/semantic-release>`_ for automating numerous processes such as bumping the version number appropriately, creating new tags/releases and updating the changelog.
+The entire process relies on the structure of commit messages to determine the version bump, which is then used for the rest of the automation.
+
+Full details are available in the upstream docs regarding the `Angular Commit Message Conventions <https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines>`_.
+The key factor is that the first line of the commit message must follow this format:
+
+.. code-block::
+
+   type(scope): subject
+
+
+* E.g. ``docs(contributing): add commit message formatting instructions``.
+
+Besides the version bump, the changelog and release notes are formatted accordingly.
+So based on the example above:
+
+..
+
+   .. raw:: html
+
+      <h3>Documentation</h3>
+
+   * **contributing:** add commit message formatting instructions
+
+
+* The ``type`` translates into a ``Documentation`` sub-heading.
+* The ``(scope):`` will be shown in bold text without the brackets.
+* The ``subject`` follows the ``scope`` as standard text.
+
+Linting commit messages in Travis CI
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+This formula uses `commitlint <https://github.com/conventional-changelog/commitlint>`_ for checking commit messages during CI testing.
+This ensures that they are in accordance with the ``semantic-release`` settings.
+
+For more details about the default settings, refer back to the ``commitlint`` `reference rules <https://conventional-changelog.github.io/commitlint/#/reference-rules>`_.
+
+Relationship between commit type and version bump
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+This formula applies some customisations to the defaults, as outlined in the table below,
+based upon the `type <https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#type>`_ of the commit:
+
+.. list-table::
+   :name: commit-type-vs-version-bump
+   :header-rows: 1
+   :stub-columns: 0
+   :widths: 1,2,3,1,1
+
+   * - Type
+     - Heading
+     - Description
+     - Bump (default)
+     - Bump (custom)
+   * - ``build``
+     - Build System
+     - Changes related to the build system
+     - –
+     -
+   * - ``chore``
+     - –
+     - Changes to the build process or auxiliary tools and libraries such as
+       documentation generation
+     - –
+     -
+   * - ``ci``
+     - Continuous Integration
+     - Changes to the continuous integration configuration
+     - –
+     -
+   * - ``docs``
+     - Documentation
+     - Documentation only changes
+     - –
+     - 0.0.1
+   * - ``feat``
+     - Features
+     - A new feature
+     - 0.1.0
+     -
+   * - ``fix``
+     - Bug Fixes
+     - A bug fix
+     - 0.0.1
+     -
+   * - ``perf``
+     - Performance Improvements
+     - A code change that improves performance
+     - 0.0.1
+     -
+   * - ``refactor``
+     - Code Refactoring
+     - A code change that neither fixes a bug nor adds a feature
+     - –
+     - 0.0.1
+   * - ``revert``
+     - Reverts
+     - A commit used to revert a previous commit
+     - –
+     - 0.0.1
+   * - ``style``
+     - Styles
+     - Changes that do not affect the meaning of the code (white-space,
+       formatting, missing semi-colons, etc.)
+     - –
+     - 0.0.1
+   * - ``test``
+     - Tests
+     - Adding missing or correcting existing tests
+     - –
+     - 0.0.1
+
+Use ``BREAKING CHANGE`` to trigger a ``major`` version change
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+Adding ``BREAKING CHANGE`` to the footer of the extended description of the commit message will **always** trigger a ``major`` version change, no matter which type has been used.
+This will be appended to the changelog and release notes as well.
+To preserve good formatting of these notes, the following format is prescribed:
+
+* ``BREAKING CHANGE: <explanation in paragraph format>.``
+
+An example of that:
+
+.. code-block:: git
+
+   ...
+
+   BREAKING CHANGE: With the removal of all of the `.sls` files under
+   `template package`, this formula no longer supports the installation of
+   packages.

docs/README.rst

@@ -1,223 +1,253 @@
-===
+.. _readme:
-php
-===
 
-Formulas to set up and configure php and various php libraries.
+php-formula
+===========
 
-.. note::
+|img_travis| |img_sr|
 
-    See the full `Salt Formulas installation and usage instructions
+.. |img_travis| image:: https://travis-ci.com/saltstack-formulas/php-formula.svg?branch=master
-    <http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html>`_.
+   :alt: Travis CI Build Status
+   :scale: 100%
+   :target: https://travis-ci.com/saltstack-formulas/php-formula
+.. |img_sr| image:: https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg
+   :alt: Semantic Release
+   :scale: 100%
+   :target: https://github.com/semantic-release/semantic-release
+
+Formula to set up and configure php
+
+.. contents:: **Table of Contents**
+
+General notes
+-------------
+
+See the full `SaltStack Formulas installation and usage instructions
+<https://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html>`_.
+
+If you are interested in writing or contributing to formulas, please pay attention to the `Writing Formula Section
+<https://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html#writing-formulas>`_.
+
+If you want to use this formula, please pay attention to the ``FORMULA`` file and/or ``git tag``,
+which contains the currently released version. This formula is versioned according to `Semantic Versioning <http://semver.org/>`_.
+
+See `Formula Versioning Section <https://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html#versioning>`_ for more details.
+
+Contributing to this repo
+-------------------------
+
+**Commit message formatting is significant!!**
+
+Please see :ref:`How to contribute <CONTRIBUTING>` for more details.
 
 Available states
-================
+----------------
 
 .. contents::
     :local:
 
 ``php``
--------
+^^^^^^^
 
 Installs the php package.
 
 ``php.adodb``
--------------
+^^^^^^^^^^^^^
 
 Installs the php-adodb package.
 
 ``php.apc``
------------
+^^^^^^^^^^^
 
 Installs the php-apc package.
 Disabled by default on opensuse need server:php repo
 
 ``php.apcu``
-------------
+^^^^^^^^^^^^
 
 Installs the php-apcu package.
 Disabled by default on opensuse need server:php repo
 
 ``php.bcmath``
-------------
+^^^^^^^^^^^^^^
 
 Installs the php-bcmath package.
 
 ``php.cgi``
------------
+^^^^^^^^^^^
 
 Installs the php-cgi package.
 Disabled on opensuse not available, only fastcgi
 
 ``php.cli``
------------
+^^^^^^^^^^^
 
 Installs the php-cli package.
 
 ``php.composer``
-----------------
+^^^^^^^^^^^^^^^^
 
 Installs [composer](https://getcomposer.org) and keeps it updated.
 
 ``php.curl``
-------------
+^^^^^^^^^^^^
 
 Installs the php5-curl package on Debian, and ensures that curl itself is
 installed for RedHat systems, this is due to the curl libs being provided by
 php-common, which will get installed with the main php package.
 
 ``php.dev``
-----------
+^^^^^^^^^^^
 
 Installs the php-dev package.
 
 ``php.fileinfo``
------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-fileinfo package and enables it.
 
 ``php.fpm``
------------
+^^^^^^^^^^^
 
 Installs the php-fpm package, starts the service, and enables it.
 
 ``php.gd``
-----------
+^^^^^^^^^^
 
 Installs the php-gd package.
 
 ``php.imagick``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-imagick package.
 Disabled on opensuse not available.
 
 ``php.imap``
-------------
+^^^^^^^^^^^^
 
 Installs the php-imap package.
 
 ``php.intl``
-------------
+^^^^^^^^^^^^
 
 Installs the php-intl package.
 
 ``php.json``
-------------
+^^^^^^^^^^^^
 
 Installs the php-json package.
 
 ``php.ldap``
-------------
+^^^^^^^^^^^^
 
 Installs the php-ldap package.
 
 ``php.mail``
-------------
+^^^^^^^^^^^^
 
 Installs the php-mail package.
 
 ``php.mbstring``
-----------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-mbstring package.
 
 ``php.mcrypt``
---------------
+^^^^^^^^^^^^^^
 
 Installs the php-mcrypt package.
 
 ``php.memcache``
-----------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-memcache package.
 Disabled on opensuse need server:php:extensions repo
 
 ``php.memcached``
------------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-memcached package.
 Disabled on opensuse need server:php:extensions repo
 
 ``php.mongo``
--------------
+^^^^^^^^^^^^^
 
 Installs the php-mongo package.
 Disabled on opensuse need server:php:extensions repo
 
 ``php.mysql``
--------------
+^^^^^^^^^^^^^
 
 Installs the php-mysql package.
 
 ``php.mysqlnd``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-mysqlnd package.
 Disabled on opensuse no package.
 
 ``php.oauth``
-------------
+^^^^^^^^^^^^^
 
 Installs the php-oauth package.
 
 ``php.pear``
-------------
+^^^^^^^^^^^^
 
 Installs the php-pear package.
 
 ``php.pgsql``
--------------
+^^^^^^^^^^^^^
 
 Installs the php-pgsql package.
 
 ``php.readline``
--------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-readline package.
 
 ``php.redis``
-------------
+^^^^^^^^^^^^^
 
 Installs the php-redis package.
 Disabled on opensuse need server:php:extensions repo
 
 ``php.soap``
-------------
+^^^^^^^^^^^^
 
 Installs the php-soap package.
 
 ``php.sqlite``
---------------
+^^^^^^^^^^^^^^
 
 Installs the php-sqlite package,
 
 ``php.suhosin``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-suhosin package.
 
 ``php.sybase``
------------
+^^^^^^^^^^^^^^
 
 Installs the php-sybase package for Sybase/MS-SQL. Debian / Ubuntu as RedHat has no similar package.
 
 ``php.tokenizer``
------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-tokenizer package and enables it.
 
 ``php.xml``
------------
+^^^^^^^^^^^
 
 Installs the php-xml package.
 
 ``php.zip``
------------
+^^^^^^^^^^^
 
 Installs the php-zip package.
 
 Next-generation, alternate approach
-===================================
+-----------------------------------
 
 The following states provide an alternate approach to managing PHP and FPM
 pools, as well as code organization. Please provide feedback by filing issues,
@@ -230,469 +260,492 @@ first available in the Helium release.
     :local:
 
 ``php.ng``
-----------
+^^^^^^^^^^
 
 Installs the php package.
 
 ``php.ng.adodb``
-----------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-adodb package.
 
 ``php.ng.apache2``
-----------------
+^^^^^^^^^^^^^^^^^^
 
 Meta-state that combines `php.ng.apache2.install`_ and `php.ng.apache2.ini`_.
 
 ``php.ng.apache2.ini``
---------------
+^^^^^^^^^^^^^^^^^^^^^^
 
 Manages the apache2 php.ini file
 
 ``php.ng.apache2.install``
---------------
+^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 Installs the apache2 and libapache2-mod-php5 package. Debian Only.
 
 ``php.ng.apc``
---------------
+^^^^^^^^^^^^^^
 
 Installs the php-apc package.
 Disabled on opensuse need server:php repo
 
 ``php.ng.apcu``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-apcu package.
 Disabled on opensuse need server:php repo
 
 ``php.ng.auth-sasl``
----------------
+^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-auth-sasl package.
 
 ``php.ng.bcmath``
----------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-bcmath package.
 
 ``php.ng.cache-lite``
----------------
+^^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-cache-lite package.
 
 ``php.ng.cgi``
---------------
+^^^^^^^^^^^^^^
 
 Installs the php-cgi package.
 Disabled on opensuse only php5-fastcgi available.
 
 ``php.ng.cli``
---------------
+^^^^^^^^^^^^^^
 
 Meta-state that combines `php.ng.cli.install`_ and `php.ng.cli.ini`_.
 
 ``php.ng.cli.ini``
-------------------
+^^^^^^^^^^^^^^^^^^
 
 Manages the php-cli ini file.
 
 ``php.ng.cli.install``
-----------------------
+^^^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-cli package.
 
 ``php.ng.composer``
--------------------
+^^^^^^^^^^^^^^^^^^^
 
 Installs [composer](https://getcomposer.org) and keeps it updated.
 
 ``php.ng.console-table``
----------------
+^^^^^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-console-table package.
 
 ``php.ng.ctype``
-----------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-ctype package.
 
 ``php.ng.curl``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php5-curl package on Debian, and ensures that curl itself is
 installed for RedHat systems, this is due to the curl libs being provided by
 php-common, which will get installed with the main php package.
 
 ``php.ng.dev``
---------------
+^^^^^^^^^^^^^^
 
 Installs the php5-dev and build-essential package.
 
 ``php.ng.filter``
------------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-filter package.
 
 ``php.ng.fpm``
---------------
+^^^^^^^^^^^^^^
 
 Meta-state that combines all php.ng.fpm states.
 
 ``php.ng.fpm.config``
----------------------
+^^^^^^^^^^^^^^^^^^^^^
 
 Manages the (non-pool) php-fpm config files.
 
 ``php.ng.fpm.install``
-----------------------
+^^^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-fpm package.
 
 ``php.ng.fpm.pools``
---------------------
+^^^^^^^^^^^^^^^^^^^^
 
 Meta-state that combines `php.ng.fpm.service`_ and `php.ng.fpm.pools_config`_
 
 ``php.ng.fpm.pools_config``
----------------------------
+^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 Manages php-fpm pool config files.
 
 ``php.ng.fpm.service``
-----------------------
+^^^^^^^^^^^^^^^^^^^^^^
 
 Manages the php-fpm service.
 
 ``php.ng.gd``
--------------
+^^^^^^^^^^^^^
 
 Installs the php-gd package.
 
 ``php.ng.gearman``
----------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-gearman package.
 
 ``php.ng.geoip``
-----------------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-geoip package.
 
 ``php.ng.geshi``
---------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-geshi package.
 
 ``php.ng.gettext``
---------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-gettext package.
 
 ``php.ng.gmp``
-----------
+^^^^^^^^^^^^^^
 
 Installs the php-gmp package. Debian Only.
 
 ``php.ng.hash``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-hash package.
 
 ``php.ng.http``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-http package.
 
 ``php.ng.hhvm``
----------------
+^^^^^^^^^^^^^^^
 
 Meta-state that combines php.ng.hhvm states
 
 ``php.ng.hhvm.config``
-----------------------
+^^^^^^^^^^^^^^^^^^^^^^
 
 Manages the php-hhvm config files
 
 ``php.ng.hhvm.install``
------------------------
+^^^^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-hhvm package
 
 ``php.ng.hhvm.repo``
---------------------
+^^^^^^^^^.REPO^^^^^^
 
 Configures the hhvm repo for debian/ubuntu
 
 ``php.ng.hhvm.service``
------------------------
+^^^^^^^^^^^^^^^^^^^^^^^
 
 Manages the php-hhvm service.
 
 ``php.ng.igbinary``
-------------------
+^^^^^^^^^^^^^^^^^^^
 
 Installs the php-igbinary package.
 
 ``php.ng.imagick``
-------------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-imagick package.
 Disabled on opensuse no package.
 
 ``php.ng.imap``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-imap package.
 
 ``php.ng.intl``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-intl package.
 
 ``php.ng.json``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-json package.
 
 ``php.ng.ldap``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-ldap package.
 
 ``php.ng.mail``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-mail package.
 
 ``php.ng.mbstring``
--------------------
+^^^^^^^^^^^^^^^^^^^
 
 Installs the php-mbstring package.
 
 ``php.ng.mcrypt``
------------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-mcrypt package.
 
 ``php.ng.mdb2``
---------------
+^^^^^^^^^^^^^^^
 
 Installs the php-mdb2 package.
 
 ``php.ng.mdb2-driver-mysql``
---------------
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-mdb2-driver-mysql package.
 
 ``php.ng.mdb2-driver-pgsql``
---------------
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-mdb2-driver-pgsql package.
 
 ``php.ng.memcache``
--------------------
+^^^^^^^^^^^^^^^^^^^
 
 Installs the php-memcache package.
 Disabled on opensuse need server:php:extensions repo
 
 ``php.ng.memcached``
---------------------
+^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-memcached package.
 Disabled on opensuse need server:php:extensions repo
 
-``php.ng.module``
---------------------
-
-Calls ``php.ng.<name>`` for each entry in ``php:ng:modules`` if available, or
-try to install the matching packages that can be set via from
-``php:ng:lookup:pkgs``
-
 ``php.ng.mongo``
---------------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-mongo package.
 
 ``php.ng.mongodb``
---------------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-mongodb package.
 
 ``php.ng.msgpack``
---------------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-msgpack package.
 
 ``php.ng.mysql``
-----------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-mysql package.
 
 ``php.ng.mysqlnd``
-------------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-mysqlnd package.
 Disabled on opensuse no package.
 
 ``php.ng.net-smtp``
----------------
+^^^^^^^^^^^^^^^^^^^
 
 Installs the php-net-smtp package.
 
 ``php.ng.net4``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-net4 package.
 
 ``php.ng.net6``
----------------
+^^^^^^^^^^^NET6
 
 Installs the php-net6 package.
 
 ``php.ng.oauth``
----------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-oauth package.
 
 ``php.ng.opcache``
----------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-opcache package.
 
 ``php.ng.openssl``
-------------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-openssl package.
 
 ``php.ng.pear``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-pear package.
 
 ``php.ng.pgsql``
-----------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-pgsql package.
 
 ``php.ng.phar``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-phar package.
 
 ``php.ng.posix``
-----------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-posix package.
 
 ``php.ng.pspell``
-----------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-pspell package.
 
 ``php.ng.readline``
-----------------
+^^^^^^^^^^^^^^^^^^^
 
 Installs the php-readline package.
 
 ``php.ng.redis``
----------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-redis package.
 Disabled on opensuse need server:php:extensions repo
 
 ``php.ng.seclib``
---------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-seclib package.
 
 ``php.ng.session``
-------------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-session package.
 
 ``php.ng.snmp``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-snmp package.
 
 ``php.ng.soap``
----------------
+^^^^^^^^^^^^^^^
 
 Installs the php-soap package.
 
 ``php.ng.sqlite``
------------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-sqlite package,
 
 ``php.ng.ssh2``
------------------
+^^^^^^^^^^^^^^^
 
 Installs the php-ssh2 package,
 
 ``php.ng.suhosin``
-------------------
+^^^^^^^^^^^^^^^^^^
 
 Installs the php-suhosin package.
 
 ``php.ng.svn``
-------------------
+^^^^^^^^^^^^^^
 
 Installs the php-svn package.
 
 ``php.ng.sybase``
--------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-sybase package.
 
 ``php.ng.tcpdf``
--------------
+^^^^^^^^^^^^^^^^
 
 Installs the php-tcpdf package.
 
 ``php.ng.tidy``
---------------
+^^^^^^^^^^^^^^^
 
 Installs the php-tidy package.
 
 ``php.ng.uuid``
---------------
+^^^^^^^^^^^^^^^
 
 Installs the php-uuid package.
 
 ``php.ng.xcache``
----------------
+^^^^^^^^^^^^^^^^^
 
 Meta-state that combines `php.ng.xcache.install`_ and `php.ng.xcache.ini`_.
 
 ``php.ng.xcache.ini``
----------------
+^^^^^^^^^^^^^^^^^^^^^
 
 Manages the php-xcache ini file
 
 ``php.ng.xcache.install``
----------------
+^^^^^^^^^^^^^^^^^^^^^^^^^
 
 Installs the php-xcache package.
 Disabled on opensuse need server:php:extensions repo
 
 ``php.ng.xdebug``
---------------
+^^^^^^^^^^^^^^^^^
 
 Installs the php-xdebug package.
 
 ``php.ng.xml``
---------------
+^^^^^^^^^^^^^^
 
 Installs the php-xml package.
 
 ``php.ng.xsl``
---------------
+^^^^^^^^^^^^^^
 
 Installs the php-xsl package.
 
 ``php.ng.zip``
-----------------
+^^^^^^^^^^^^^^
 
 Installs the php-zip package.
+
+Testing
+-------
+
+Linux testing is done with ``kitchen-salt``.
+
+``bin/kitchen converge``
+^^^^^^^^^^^^^^^^^^^^^^^^
+
+Creates the docker instance and runs the ``template`` main state, ready for testing.
+
+``bin/kitchen verify``
+^^^^^^^^^^^^^^^^^^^^^^
+
+Runs the ``inspec`` tests on the actual instance.
+
+``bin/kitchen destroy``
+^^^^^^^^^^^^^^^^^^^^^^^
+
+Removes the docker instance.
+
+``bin/kitchen test``
+^^^^^^^^^^^^^^^^^^^^
+
+Runs all of the stages above in one go: i.e. ``destroy`` + ``converge`` + ``verify`` + ``destroy``.
+
+``bin/kitchen login``
+^^^^^^^^^^^^^^^^^^^^^
+
+Gives you SSH access to the instance for manual testing.

docs/TOFS_pattern.rst

@@ -0,0 +1,443 @@
+.. _tofs_pattern:
+
+TOFS: A pattern for using SaltStack
+===================================
+
+.. list-table::
+   :name: tofs-authors
+   :header-rows: 1
+   :stub-columns: 1
+   :widths: 2,2,3,2
+
+   * -
+     - Person
+     - Contact
+     - Date
+   * - Authored by
+     - Roberto Moreda
+     - moreda@allenta.com
+     - 29/12/2014
+   * - Modified by
+     - Daniel Dehennin
+     - daniel.dehennin@baby-gnu.org
+     - 07/02/2019
+   * - Modified by
+     - Imran Iqbal
+     - https://github.com/myii
+     - 23/02/2019
+
+All that follows is a proposal based on my experience with `SaltStack <http://www.saltstack.com/>`_. The good thing of a piece of software like this is that you can "bend it" to suit your needs in many possible ways, and this is one of them. All the recommendations and thoughts are given "as it is" with no warranty of any type.
+
+.. contents:: **Table of Contents**
+
+Usage of values in pillar vs templates in ``file_roots``
+--------------------------------------------------------
+
+Among other functions, the *master* (or *salt-master*) serves files to the *minions* (or *salt-minions*). The `file_roots <http://docs.saltstack.com/en/latest/ref/file_server/file_roots.html>`_ is the list of directories used in sequence to find a file when a minion requires it: the first match is served to the minion. Those files could be `state files <http://docs.saltstack.com/en/latest/topics/tutorials/starting_states.html>`_ or configuration templates, among others.
+
+Using SaltStack is a simple and effective way to implement configuration management, but even in a `non-multitenant <http://en.wikipedia.org/wiki/Multitenancy>`_ scenario, it is not a good idea to generally access some data (e.g. the database password in our `Zabbix <http://www.zabbix.com/>`_ server configuration file or the private key of our `Nginx <http://nginx.org/en/>`_ TLS certificate).
+
+To avoid this situation we can use the `pillar mechanism <http://docs.saltstack.com/en/latest/topics/pillar/>`_, which is designed to provide controlled access to data from the minions based on some selection rules. As pillar data could be easily integrated in the `Jinja <http://docs.saltstack.com/en/latest/topics/tutorials/pillar.html>`_ templates, it is a good mechanism to store values to be used in the final rendering of state files and templates.
+
+There are a variety of approaches on the usage of pillar and templates as seen in the `saltstack-formulas <https://github.com/saltstack-formulas>`_' repositories. `Some <https://github.com/saltstack-formulas/nginx-formula/pull/18>`_ `developments <https://github.com/saltstack-formulas/php-formula/pull/14>`_ stress the initial purpose of pillar data into a storage for most of the possible variables for a determined system configuration. This, in my opinion, is shifting too much load from the original template files approach. Adding up some `non-trivial Jinja <https://github.com/spsoit/nginx-formula/blob/81de880fe0276dd9488ffa15bc78944c0fc2b919/nginx/ng/files/nginx.conf>`_ code as essential part of composing the state file definitely makes SaltStack state files (hence formulas) more difficult to read. The extreme of this approach is that we could end up with a new render mechanism, implemented in Jinja, storing everything needed in pillar data to compose configurations. Additionally, we are establishing a strong dependency with the Jinja renderer.
+
+In opposition to the *put the code in file_roots and the data in pillars* approach, there is the *pillar as a store for a set of key-values* approach. A full-blown configuration file abstracted in pillar and jinja is complicated to develop, understand and maintain. I think a better and simpler approach is to keep a configuration file templated using just a basic (non-extensive but extensible) set of pillar values.
+
+On the reusability of SaltStack state files
+-------------------------------------------
+
+There is a brilliant initiative of the SaltStack community called `salt-formulas <https://github.com/saltstack-formulas>`_. Their goal is to provide state files, pillar examples and configuration templates ready to be used for provisioning. I am a contributor for two small ones: `zabbix-formula <https://github.com/saltstack-formulas/zabbix-formula>`_ and `varnish-formula <https://github.com/saltstack-formulas/varnish-formula>`_.
+
+The `design guidelines <http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html>`_ for formulas are clear in many aspects and it is a recommended reading for anyone willing to write state files, even non-formulaic ones.
+
+In the next section, I am going to describe my proposal to extend further the reusability of formulas, suggesting some patterns of usage.
+
+The Template Override and Files Switch (TOFS) pattern
+-----------------------------------------------------
+
+I understand a formula as a **complete, independent set of SaltStack state and configuration template files sufficient to configure a system**. A system could be something as simple as an NTP server or some other much more complex service that requires many state and configuration template files.
+
+The customization of a formula should be done mainly by providing pillar data used later to render either the state or the configuration template files.
+
+Example: NTP before applying TOFS
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+Let's work with the NTP example. A basic formula that follows the `design guidelines <http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html>`_ has the following files and directories tree:
+
+.. code-block::
+
+   /srv/saltstack/salt-formulas/ntp-saltstack-formula/
+     ntp/
+       map.jinja
+       init.sls
+       conf.sls
+       files/
+         default/
+           etc/
+             ntp.conf.jinja
+
+In order to use it, let's assume a `masterless configuration <http://docs.saltstack.com/en/latest/topics/tutorials/quickstart.html>`_ and this relevant section of ``/etc/salt/minion``:
+
+.. code-block:: yaml
+
+   pillar_roots:
+     base:
+       - /srv/saltstack/pillar
+   file_client: local
+   file_roots:
+     base:
+       - /srv/saltstack/salt
+       - /srv/saltstack/salt-formulas/ntp-saltstack-formula
+
+.. code-block:: jinja
+
+   {#- /srv/saltstack/salt-formulas/ntp-saltstack-formula/ntp/map.jinja #}
+   {%- set ntp = salt['grains.filter_by']({
+     'default': {
+       'pkg': 'ntp',
+       'service': 'ntp',
+       'config': '/etc/ntp.conf',
+     },
+   }, merge=salt['pillar.get']('ntp:lookup')) %}
+
+In ``init.sls`` we have the minimal states required to have NTP configured. In many cases ``init.sls`` is almost equivalent to an ``apt-get install`` or a ``yum install`` of the package.
+
+.. code-block:: sls
+
+   ## /srv/saltstack/salt-formulas/ntp-saltstack-formula/ntp/init.sls
+   {%- from 'ntp/map.jinja' import ntp with context %}
+
+   Install NTP:
+     pkg.installed:
+       - name: {{ ntp.pkg }}
+
+   Enable and start NTP:
+     service.running:
+       - name: {{ ntp.service }}
+       - enabled: True
+       - require:
+         - pkg: Install NTP package
+
+In ``conf.sls`` we have the configuration states. In most cases, that is just managing configuration file templates and making them to be watched by the service.
+
+.. code-block:: sls
+
+   ## /srv/saltstack/salt-formulas/ntp-saltstack-formula/ntp/conf.sls
+   include:
+     - ntp
+
+   {%- from 'ntp/map.jinja' import ntp with context %}
+
+   Configure NTP:
+     file.managed:
+       - name: {{ ntp.config }}
+       - template: jinja
+       - source: salt://ntp/files/default/etc/ntp.conf.jinja
+       - watch_in:
+         - service: Enable and start NTP service
+       - require:
+         - pkg: Install NTP package
+
+Under ``files/default``, there is a structure that mimics the one in the minion in order to avoid clashes and confusion on where to put the needed templates. There you can find a mostly standard template for the configuration file.
+
+.. code-block:: jinja
+
+   {#- /srv/saltstack/salt-formulas/ntp-saltstack-formula/ntp/files/default/etc/ntp.conf.jinja #}
+   {#- Managed by saltstack #}
+   {#- Edit pillars or override this template in saltstack if you need customization #}
+   {%- set settings = salt['pillar.get']('ntp', {}) %}
+   {%- set default_servers = ['0.ubuntu.pool.ntp.org',
+                             '1.ubuntu.pool.ntp.org',
+                             '2.ubuntu.pool.ntp.org',
+                             '3.ubuntu.pool.ntp.org'] %}
+
+   driftfile /var/lib/ntp/ntp.drift
+   statistics loopstats peerstats clockstats
+   filegen loopstats file loopstats type day enable
+   filegen peerstats file peerstats type day enable
+   filegen clockstats file clockstats type day enable
+
+   {%- for server in settings.get('servers', default_servers) %}
+   server {{ server }}
+   {%- endfor %}
+
+   restrict -4 default kod notrap nomodify nopeer noquery
+   restrict -6 default kod notrap nomodify nopeer noquery
+
+   restrict 127.0.0.1
+   restrict ::1
+
+With all this, it is easy to install and configure a simple NTP server by just running ``salt-call state.sls ntp.conf``: the package will be installed, the service will be running and the configuration should be correct for most of cases, even without pillar data.
+
+Alternatively, you can define a highstate in ``/srv/saltstack/salt/top.sls`` and run ``salt-call state.highstate``.
+
+.. code-block:: sls
+
+   ## /srv/saltstack/salt/top.sls
+   base:
+     '*':
+       - ntp.conf
+
+**Customizing the formula just with pillar data**, we have the option to define the NTP servers.
+
+.. code-block:: sls
+
+   ## /srv/saltstack/pillar/top.sls
+   base:
+     '*':
+       - ntp
+
+.. code-block:: sls
+
+   ## /srv/saltstack/pillar/ntp.sls
+   ntp:
+     servers:
+       - 0.ch.pool.ntp.org
+       - 1.ch.pool.ntp.org
+       - 2.ch.pool.ntp.org
+       - 3.ch.pool.ntp.org
+
+Template Override
+^^^^^^^^^^^^^^^^^
+
+If the customization based on pillar data is not enough, we can override the template by creating a new one in ``/srv/saltstack/salt/ntp/files/default/etc/ntp.conf.jinja``
+
+.. code-block:: jinja
+
+   {#- /srv/saltstack/salt/ntp/files/default/etc/ntp.conf.jinja #}
+   {#- Managed by saltstack #}
+   {#- Edit pillars or override this template in saltstack if you need customization #}
+
+   {#- Some bizarre configurations here #}
+   {#- ... #}
+
+   {%- for server in settings.get('servers', default_servers) %}
+   server {{ server }}
+   {%- endfor %}
+
+This way we are locally **overriding the template files** offered by the formula in order to make a more complex adaptation. Of course, this could be applied as well to any of the files, including the state files.
+
+Files Switch
+^^^^^^^^^^^^
+
+To bring some order into the set of template files included in a formula, as we commented, we suggest having a similar structure to a normal final file system under ``files/default``.
+
+We can make different templates coexist for different minions, classified by any `grain <http://docs.saltstack.com/en/latest/topics/targeting/grains.html>`_ value, by simply creating new directories under ``files``. This mechanism is based on **using values of some grains as a switch for the directories under** ``files/``.
+
+If we decide that we want ``os_family`` as switch, then we could provide the formula template variants for both the ``RedHat`` and ``Debian`` families.
+
+.. code-block::
+
+   /srv/saltstack/salt-formulas/ntp-saltstack-formula/ntp/files/
+     default/
+       etc/
+         ntp.conf.jinja
+     RedHat/
+       etc/
+         ntp.conf.jinja
+     Debian/
+       etc/
+         ntp.conf.jinja
+
+To make this work we need a ``conf.sls`` state file that takes a list of possible files as the configuration template.
+
+.. code-block:: sls
+
+   ## /srv/saltstack/salt-formulas/ntp-saltstack-formula/ntp/conf.sls
+   include:
+     - ntp
+
+   {%- from 'ntp/map.jinja' import ntp with context %}
+
+   Configure NTP:
+     file.managed:
+       - name: {{ ntp.config }}
+       - template: jinja
+       - source:
+         - salt://ntp/files/{{ grains.get('os_family', 'default') }}/etc/ntp.conf.jinja
+         - salt://ntp/files/default/etc/ntp.conf.jinja
+       - watch_in:
+         - service: Enable and start NTP service
+       - require:
+         - pkg: Install NTP package
+
+If we want to cover the possibility of a special template for a minion identified by ``node01`` then we could have a specific template in ``/srv/saltstack/salt/ntp/files/node01/etc/ntp.conf.jinja``.
+
+.. code-block:: jinja
+
+   {#- /srv/saltstack/salt/ntp/files/node01/etc/ntp.conf.jinja #}
+   {#- Managed by saltstack #}
+   {#- Edit pillars or override this template in saltstack if you need customization #}
+
+   {#- Some crazy configurations here for node01 #}
+   {#- ... #}
+
+To make this work we could write a specially crafted ``conf.sls``.
+
+.. code-block:: sls
+
+   ## /srv/saltstack/salt-formulas/ntp-saltstack-formula/ntp/conf.sls
+   include:
+     - ntp
+
+   {%- from 'ntp/map.jinja' import ntp with context %}
+
+   Configure NTP:
+     file.managed:
+       - name: {{ ntp.config }}
+       - template: jinja
+       - source:
+         - salt://ntp/files/{{ grains.get('id') }}/etc/ntp.conf.jinja
+         - salt://ntp/files/{{ grains.get('os_family') }}/etc/ntp.conf.jinja
+         - salt://ntp/files/default/etc/ntp.conf.jinja
+       - watch_in:
+         - service: Enable and start NTP service
+       - require:
+         - pkg: Install NTP package
+
+Using the ``files_switch`` macro
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+We can simplify the ``conf.sls`` with the new ``files_switch`` macro to use in the ``source`` parameter for the ``file.managed`` state.
+
+.. code-block:: sls
+
+   ## /srv/saltstack/salt-formulas/ntp-saltstack-formula/ntp/conf.sls
+   include:
+     - ntp
+
+   {%- set tplroot = tpldir.split('/')[0] %}
+   {%- from 'ntp/map.jinja' import ntp with context %}
+   {%- from 'ntp/libtofs.jinja' import files_switch %}
+
+   Configure NTP:
+     file.managed:
+       - name: {{ ntp.config }}
+       - template: jinja
+       - source: {{ files_switch(['/etc/ntp.conf.jinja'],
+                                 lookup='Configure NTP'
+                    )
+                 }}
+       - watch_in:
+         - service: Enable and start NTP service
+       - require:
+         - pkg: Install NTP package
+
+
+* This uses ``config.get``, searching for ``ntp:tofs:source_files:Configure NTP`` to determine the list of template files to use.
+* If this does not yield any results, the default of ``['/etc/ntp.conf.jinja']`` will be used.
+
+In ``libtofs.jinja``, we define this new macro ``files_switch``.
+
+.. literalinclude:: ../template/libtofs.jinja
+   :caption: /srv/saltstack/salt-formulas/ntp-saltstack-formula/ntp/libtofs.jinja
+   :language: jinja
+
+How to customise the ``source`` further
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+The examples below are based on an ``Ubuntu`` minion called ``theminion`` being configured via. pillar.
+
+Using the default settings of the ``files_switch`` macro above,
+the ``source`` will be:
+
+.. code-block:: sls
+
+         - source:
+           - salt://ntp/files/theminion/etc/ntp.conf.jinja
+           - salt://ntp/files/Debian/etc/ntp.conf.jinja
+           - salt://ntp/files/default/etc/ntp.conf.jinja
+
+Customise ``files``
+~~~~~~~~~~~~~~~~~~~
+
+The ``files`` portion can be customised:
+
+.. code-block:: sls
+
+   ntp:
+     tofs:
+       dirs:
+         files: files_alt
+
+Resulting in:
+
+.. code-block:: sls
+
+         - source:
+           - salt://ntp/files_alt/theminion/etc/ntp.conf.jinja
+           - salt://ntp/files_alt/Debian/etc/ntp.conf.jinja
+           - salt://ntp/files_alt/default/etc/ntp.conf.jinja
+
+Customise the use of grains
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Grains can be customised and even arbitrary paths can be supplied:
+
+.. code-block:: sls
+
+   ntp:
+     tofs:
+       files_switch:
+         - any/path/can/be/used/here
+         - id
+         - os
+         - os_family
+
+Resulting in:
+
+.. code-block:: sls
+
+         - source:
+           - salt://ntp/files/any/path/can/be/used/here/etc/ntp.conf.jinja
+           - salt://ntp/files/theminion/etc/ntp.conf.jinja
+           - salt://ntp/files/Ubuntu/etc/ntp.conf.jinja
+           - salt://ntp/files/Debian/etc/ntp.conf.jinja
+           - salt://ntp/files/default/etc/ntp.conf.jinja
+
+Customise the ``default`` path
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The ``default`` portion of the path can be customised:
+
+.. code-block:: sls
+
+   ntp:
+     tofs:
+       dirs:
+         default: default_alt
+
+Resulting in:
+
+.. code-block:: sls
+
+         - source:
+           ...
+           - salt://ntp/files/default_alt/etc/ntp.conf.jinja
+
+Customise the list of ``source_files``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The list of ``source_files`` can be given:
+
+.. code-block:: sls
+
+   ntp:
+     tofs:
+       source_files:
+         Configure NTP:
+           - '/etc/ntp.conf.jinja'
+           - '/etc/ntp.conf_alt.jinja'
+
+Resulting in:
+
+.. code-block:: sls
+
+         - source:
+           - salt://ntp/files/theminion/etc/ntp.conf.jinja
+           - salt://ntp/files/theminion/etc/ntp.conf_alt.jinja
+           - salt://ntp/files/Debian/etc/ntp.conf.jinja
+           - salt://ntp/files/Debian/etc/ntp.conf_alt.jinja
+           - salt://ntp/files/default/etc/ntp.conf.jinja
+           - salt://ntp/files/default/etc/ntp.conf_alt.jinja
+

kitchen.yml

@@ -0,0 +1,183 @@
+# -*- coding: utf-8 -*-
+# vim: ft=yaml
+---
+# For help on this file's format, see https://kitchen.ci/
+driver:
+  name: docker
+  use_sudo: false
+  privileged: true
+  run_command: /lib/systemd/systemd
+
+# Make sure the platforms listed below match up with
+# the `env.matrix` instances defined in `.travis.yml`
+platforms:
+  ## SALT `develop`
+  - name: debian-9-develop-py3
+    driver:
+      image: netmanagers/salt-develop-py3:debian-9
+      provision_command:
+        - curl -o bootstrap-salt.sh -L https://bootstrap.saltstack.com
+        - sh bootstrap-salt.sh -XdPbfrq -x python3 git develop
+  - name: ubuntu-1804-develop-py3
+    driver:
+      image: netmanagers/salt-develop-py3:ubuntu-18.04
+      provision_command:
+        - curl -o bootstrap-salt.sh -L https://bootstrap.saltstack.com
+        - sh bootstrap-salt.sh -XdPbfrq -x python3 git develop
+  - name: centos-7-develop-py3
+    driver:
+      image: netmanagers/salt-develop-py3:centos-7
+      provision_command:
+        - curl -o bootstrap-salt.sh -L https://bootstrap.saltstack.com
+        - sh bootstrap-salt.sh -XdPbfrq -x python3 git develop
+  - name: fedora-29-develop-py3
+    driver:
+      image: netmanagers/salt-develop-py3:fedora-29
+      provision_command:
+        - curl -o bootstrap-salt.sh -L https://bootstrap.saltstack.com
+        - sh bootstrap-salt.sh -XdPbfrq -x python3 git develop
+  - name: opensuse-leap-15-develop-py3
+    driver:
+      image: netmanagers/salt-develop-py3:opensuse-leap-15
+      provision_command:
+        - curl -o bootstrap-salt.sh -L https://bootstrap.saltstack.com
+        - sh bootstrap-salt.sh -XdPbfrq -x python3 git develop
+      run_command: /usr/lib/systemd/systemd
+
+  ## SALT 2019.2
+  - name: debian-9-2019-2-py3
+    driver:
+      image: netmanagers/salt-2019.2-py3:debian-9
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/debian.sls
+  - name: ubuntu-1804-2019-2-py3
+    driver:
+      image: netmanagers/salt-2019.2-py3:ubuntu-18.04
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/debian.sls
+  - name: centos-7-2019-2-py3
+    driver:
+      image: netmanagers/salt-2019.2-py3:centos-7
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/redhat.sls
+  - name: fedora-29-2019-2-py3
+    driver:
+      image: netmanagers/salt-2019.2-py3:fedora-29
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/redhat.sls
+  - name: opensuse-leap-15-2019-2-py3
+    driver:
+      image: netmanagers/salt-2019.2-py3:opensuse-leap-15
+      run_command: /usr/lib/systemd/systemd
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/suse.sls
+
+  ## SALT 2018.3
+  - name: debian-9-2018-3-py2
+    driver:
+      image: netmanagers/salt-2018.3-py2:debian-9
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/debian.sls
+  - name: ubuntu-1604-2018-3-py2
+    driver:
+      image: netmanagers/salt-2018.3-py2:ubuntu-16.04
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/debian.sls
+  - name: centos-7-2018-3-py2
+    driver:
+      image: netmanagers/salt-2018.3-py2:centos-7
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/redhat.sls
+  - name: fedora-29-2018-3-py2
+    driver:
+      image: netmanagers/salt-2018.3-py2:fedora-29
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/redhat.sls
+  # TODO: Use this when fixed instead of `opensuse-leap-42`
+  # Ref: https://github.com/netmanagers/salt-image-builder/issues/2
+  # - name: opensuse-leap-15-2018-3-py2
+  #   driver:
+  #     image: netmanagers/salt-2018.3-py2:opensuse-leap-15
+  #     run_command: /usr/lib/systemd/systemd
+  - name: opensuse-leap-42-2018-3-py2
+    driver:
+      image: netmanagers/salt-2018.3-py2:opensuse-leap-42
+      run_command: /usr/lib/systemd/systemd
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/suse.sls
+
+  ## SALT 2017.7
+  - name: debian-8-2017-7-py2
+    driver:
+      image: netmanagers/salt-2017.7-py2:debian-8
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/debian.sls
+  - name: ubuntu-1604-2017-7-py2
+    driver:
+      image: netmanagers/salt-2017.7-py2:ubuntu-16.04
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/debian.sls
+  - name: centos-6-2017-7-py2
+    driver:
+      image: netmanagers/salt-2017.7-py2:centos-6
+      run_command: /sbin/init
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/redhat.sls
+  - name: fedora-28-2017-7-py2
+    driver:
+      image: netmanagers/salt-2017.7-py2:fedora-28
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/redhat.sls
+  - name: opensuse-leap-42-2017-7-py2
+    driver:
+      image: netmanagers/salt-2017.7-py2:opensuse-leap-42
+      run_command: /usr/lib/systemd/systemd
+    provisioner:
+      pillars_from_files:
+        php.sls: test/salt/pillar/suse.sls
+
+provisioner:
+  name: salt_solo
+  log_level: info
+  salt_install: none
+  require_chef: false
+  formula: php
+  salt_copy_filter:
+    - .kitchen
+    - .git
+  state_top:
+    base:
+      '*':
+        - php
+  pillars:
+    top.sls:
+      base:
+        '*':
+          - php
+
+verifier:
+  # https://www.inspec.io/
+  name: inspec
+  sudo: true
+  # cli, documentation, html, progress, json, json-min, json-rspec, junit
+  reporter:
+    - cli
+  inspec_tests:
+    - path: test/integration/default
+
+suites:
+  - name: default

pre-commit_semantic-release.sh

@@ -0,0 +1,30 @@
+#!/bin/sh
+
+###############################################################################
+# (A) Update `FORMULA` with `${nextRelease.version}`
+###############################################################################
+sed -i -e "s_^\(version:\).*_\1 ${1}_" FORMULA
+
+
+###############################################################################
+# (B) Use `m2r` to convert automatically produced `.md` docs to `.rst`
+###############################################################################
+
+# Install `m2r`
+sudo -H pip install m2r
+
+# Copy and then convert the `.md` docs
+cp *.md docs/
+cd docs/
+m2r --overwrite *.md
+
+# Change excess `H1` headings to `H2` in converted `CHANGELOG.rst`
+sed -i -e '/^=.*$/s/=/-/g' CHANGELOG.rst
+sed -i -e '1,4s/-/=/g' CHANGELOG.rst
+
+# Use for debugging output, when required
+# cat AUTHORS.rst
+# cat CHANGELOG.rst
+
+# Return back to the main directory
+cd ..

release-rules.js

@@ -0,0 +1,18 @@
+// No release is triggered for the types commented out below.
+// Commits using these types will be incorporated into the next release.
+//
+// NOTE: Any changes here must be reflected in `CONTRIBUTING.md`.
+module.exports = [
+  {breaking: true, release: 'major'},
+  // {type: 'build', release: 'patch'},
+  // {type: 'chore', release: 'patch'},
+  // {type: 'ci', release: 'patch'},
+  {type: 'docs', release: 'patch'},
+  {type: 'feat', release: 'minor'},
+  {type: 'fix', release: 'patch'},
+  {type: 'perf', release: 'patch'},
+  {type: 'refactor', release: 'patch'},
+  {type: 'revert', release: 'patch'},
+  {type: 'style', release: 'patch'},
+  {type: 'test', release: 'patch'},
+];

release.config.js

@@ -0,0 +1,106 @@
+module.exports = {
+  branch: 'master',
+  plugins: [
+      ['@semantic-release/commit-analyzer', {
+        preset: 'angular',
+        releaseRules: './release-rules.js',
+      }],
+      '@semantic-release/release-notes-generator',
+      ['@semantic-release/changelog', {
+        changelogFile: 'CHANGELOG.md',
+        changelogTitle: '# Changelog',
+      }],
+      ['@semantic-release/exec', {
+        prepareCmd: 'sh ./pre-commit_semantic-release.sh ${nextRelease.version}',
+      }],
+      ['@semantic-release/git', {
+        assets: ['*.md', 'docs/*.rst', 'FORMULA'],
+      }],
+      '@semantic-release/github',
+  ],
+  generateNotes: {
+    preset: 'angular',
+    writerOpts: {
+      // Required due to upstream bug preventing all types being displayed.
+      // Bug: https://github.com/conventional-changelog/conventional-changelog/issues/317
+      // Fix: https://github.com/conventional-changelog/conventional-changelog/pull/410
+      transform: (commit, context) => {
+          const issues = []
+
+          commit.notes.forEach(note => {
+              note.title = `BREAKING CHANGES`
+          })
+
+          // NOTE: Any changes here must be reflected in `CONTRIBUTING.md`.
+          if (commit.type === `feat`) {
+              commit.type = `Features`
+          } else if (commit.type === `fix`) {
+              commit.type = `Bug Fixes`
+          } else if (commit.type === `perf`) {
+              commit.type = `Performance Improvements`
+          } else if (commit.type === `revert`) {
+              commit.type = `Reverts`
+          } else if (commit.type === `docs`) {
+              commit.type = `Documentation`
+          } else if (commit.type === `style`) {
+              commit.type = `Styles`
+          } else if (commit.type === `refactor`) {
+              commit.type = `Code Refactoring`
+          } else if (commit.type === `test`) {
+              commit.type = `Tests`
+          } else if (commit.type === `build`) {
+              commit.type = `Build System`
+          // } else if (commit.type === `chore`) {
+          //     commit.type = `Maintenance`
+          } else if (commit.type === `ci`) {
+              commit.type = `Continuous Integration`
+          } else {
+              return
+          }
+
+          if (commit.scope === `*`) {
+              commit.scope = ``
+          }
+
+          if (typeof commit.hash === `string`) {
+              commit.hash = commit.hash.substring(0, 7)
+          }
+
+          if (typeof commit.subject === `string`) {
+              let url = context.repository
+                  ? `${context.host}/${context.owner}/${context.repository}`
+                  : context.repoUrl
+              if (url) {
+                  url = `${url}/issues/`
+                  // Issue URLs.
+                  commit.subject = commit.subject.replace(/#([0-9]+)/g, (_, issue) => {
+                      issues.push(issue)
+                      return `[#${issue}](${url}${issue})`
+                  })
+              }
+              if (context.host) {
+                  // User URLs.
+                  commit.subject = commit.subject.replace(/\B@([a-z0-9](?:-?[a-z0-9/]){0,38})/g, (_, username) => {
+                  if (username.includes('/')) {
+                      return `@${username}`
+                  }
+
+                  return `[@${username}](${context.host}/${username})`
+                  })
+              }
+          }
+
+          // remove references that already appear in the subject
+          commit.references = commit.references.filter(reference => {
+              if (issues.indexOf(reference.issue) === -1) {
+                  return true
+              }
+
+              return false
+          })
+
+          return commit
+      },
+    },
+  },
+};

test/integration/default/controls/package_spec.rb

@@ -0,0 +1,15 @@
+control 'Php package' do
+  title 'should be installed'
+
+  pkg_name =
+    case os[:family]
+    when 'debian', 'redhat', 'fedora'
+      'php'
+    when 'suse'
+      'php5'
+    end
+
+  describe package(pkg_name) do
+    it { should be_installed }
+  end
+end

test/integration/default/inspec.yml

@@ -0,0 +1,12 @@
+name: php
+title: Php Formula
+maintainer: Nicolas Rodriguez
+license: Apache-2.0
+summary: Verify that the php formula is setup and configured correctly
+supports:
+  - os-name: debian
+  - os-name: ubuntu
+  - os-name: centos
+  - os-name: fedora
+  - os-name: opensuse
+  - os-name: suse