From f3e4197fcb399b63799b175ded7bf25c2a94e8f8 Mon Sep 17 00:00:00 2001 From: Hayden King Date: Sun, 19 Jul 2015 18:00:44 -0500 Subject: [PATCH 1/2] remove curl dependency in favor of saltstack file.managed and use the composer instlaller. --- php/composer.sls | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/php/composer.sls b/php/composer.sls index 530c723..49c7aa7 100644 --- a/php/composer.sls +++ b/php/composer.sls @@ -1,23 +1,24 @@ {% from "php/map.jinja" import php with context %} -{% set install_file = php.local_bin + '/composer' %} +{% set install_file = php.local_bin + '/' + php.composer_bin %} include: - php get-composer: - cmd.run: - - name: 'CURL=`which curl`; $CURL -sS https://getcomposer.org/installer | php' + file.managed: + - name: {{ php.temp_dir }}/installer + - mode: 0755 - unless: test -f {{ install_file }} - - cwd: {{ php.temp_dir }} + - source: https://getcomposer.org/installer + - source_hash: {{ php.composer_hash }} - require: - pkg: php install-composer: cmd.wait: - - name: mv {{ php.temp_dir }}/composer.phar {{ install_file }} - - cwd: {{ php.temp_dir }} + - name: {{ php.temp_dir }}/installer --filename={{ php.composer_bin }} --install-dir={{ php.local_bin }} - watch: - - cmd: get-composer + - file: get-composer # Get COMPOSER_DEV_WARNING_TIME from the installed composer, and if that time has passed # then it's time to run `composer selfupdate` @@ -29,6 +30,6 @@ update-composer: cmd.run: - name: "{{ install_file }} selfupdate" - unless: test $(grep --text COMPOSER_DEV_WARNING_TIME {{ install_file }} | egrep '^\s*define' | sed -e 's,[^[:digit:]],,g') \> $(php -r 'echo time();') - - cwd: {{ php.temp_dir }} + - cwd: {{ php.local_bin }} - require: - cmd: install-composer From 77c6e9b2c09d64e58954d461b4174d7945f8a072 Mon Sep 17 00:00:00 2001 From: Hayden King Date: Sun, 19 Jul 2015 18:01:34 -0500 Subject: [PATCH 2/2] add composer bin and hash variables so it could be overridden in pillar if needed. --- php/map.jinja | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/php/map.jinja b/php/map.jinja index 375c2f8..2a9da20 100644 --- a/php/map.jinja +++ b/php/map.jinja @@ -36,6 +36,8 @@ 'ext_conf_path': '/etc/php5/mods-available', 'local_bin': '/usr/local/bin', 'temp_dir': '/tmp', + 'composer_bin': 'composer', + 'composer_hash': 'sha256=6a1ba6495f0bdb8e7735a7a76948b61c54b4a57b56837a9e9f93b4a0ac1f83a5', }, 'RedHat': { 'php_pkg': 'php', @@ -74,6 +76,8 @@ 'ext_conf_path': '/etc/php5/conf.d', 'local_bin': '/usr/local/bin', 'temp_dir': '/tmp', + 'composer_bin': 'composer', + 'composer_hash': 'sha256=6a1ba6495f0bdb8e7735a7a76948b61c54b4a57b56837a9e9f93b4a0ac1f83a5', }, 'Suse': { 'php_pkg': 'php5', @@ -103,5 +107,7 @@ 'ext_conf_path': '/etc/php5/conf.d', 'local_bin': '/usr/local/bin', 'temp_dir': '/tmp', + 'composer_bin': 'composer', + 'composer_hash': 'sha256=6a1ba6495f0bdb8e7735a7a76948b61c54b4a57b56837a9e9f93b4a0ac1f83a5', }, }, merge=salt['pillar.get']('php:lookup')) %}