ci(pre-commit): enable rubocop
linter after fix
`rubocop` violations fixed in 1a4d20877c
.
* Automated using https://github.com/myii/ssf-formula/pull/284
This commit is contained in:
parent
f1f94d48ce
commit
71dbf345d6
@ -17,6 +17,14 @@ repos:
|
|||||||
stages: [manual]
|
stages: [manual]
|
||||||
additional_dependencies: ['@commitlint/config-conventional@8.3.4']
|
additional_dependencies: ['@commitlint/config-conventional@8.3.4']
|
||||||
always_run: true
|
always_run: true
|
||||||
|
- repo: https://github.com/adithyabsk/mirrors-rubocop
|
||||||
|
rev: v0.91.0
|
||||||
|
hooks:
|
||||||
|
- id: rubocop
|
||||||
|
name: Check Ruby files with rubocop
|
||||||
|
args: [--debug]
|
||||||
|
always_run: true
|
||||||
|
pass_filenames: false
|
||||||
- repo: https://github.com/jumanjihouse/pre-commit-hooks
|
- repo: https://github.com/jumanjihouse/pre-commit-hooks
|
||||||
rev: 2.1.3
|
rev: 2.1.3
|
||||||
hooks:
|
hooks:
|
||||||
|
21
.travis.yml
21
.travis.yml
@ -36,17 +36,14 @@ stages:
|
|||||||
# - name: 'release'
|
# - name: 'release'
|
||||||
# if: 'branch = master AND type != pull_request'
|
# if: 'branch = master AND type != pull_request'
|
||||||
jobs:
|
jobs:
|
||||||
allow_failures:
|
|
||||||
- env: Lint_rubocop
|
|
||||||
fast_finish: true
|
|
||||||
include:
|
include:
|
||||||
## Define the test stage that runs the linters (and testing matrix, if applicable)
|
## Define the test stage that runs the linters (and testing matrix, if applicable)
|
||||||
|
|
||||||
# Run all of the linters in a single job (except `rubocop`)
|
# Run all of the linters in a single job
|
||||||
- language: 'node_js'
|
- language: 'node_js'
|
||||||
node_js: 'lts/*'
|
node_js: 'lts/*'
|
||||||
env: 'Lint'
|
env: 'Lint'
|
||||||
name: 'Lint: salt-lint, yamllint, shellcheck & commitlint'
|
name: 'Lint: salt-lint, yamllint, rubocop, shellcheck & commitlint'
|
||||||
before_install: 'skip'
|
before_install: 'skip'
|
||||||
script:
|
script:
|
||||||
# Install and run `salt-lint`
|
# Install and run `salt-lint`
|
||||||
@ -57,6 +54,9 @@ jobs:
|
|||||||
# Need at least `v1.17.0` for the `yaml-files` setting
|
# Need at least `v1.17.0` for the `yaml-files` setting
|
||||||
- pip install --user yamllint>=1.17.0
|
- pip install --user yamllint>=1.17.0
|
||||||
- yamllint -s .
|
- yamllint -s .
|
||||||
|
# Install and run `rubocop`
|
||||||
|
- gem install rubocop
|
||||||
|
- rubocop -d
|
||||||
# Run `shellcheck` (already pre-installed in Travis)
|
# Run `shellcheck` (already pre-installed in Travis)
|
||||||
- shellcheck --version
|
- shellcheck --version
|
||||||
- git ls-files -- '*.sh' '*.bash' '*.ksh'
|
- git ls-files -- '*.sh' '*.bash' '*.ksh'
|
||||||
@ -65,17 +65,6 @@ jobs:
|
|||||||
- npm i -D @commitlint/config-conventional
|
- npm i -D @commitlint/config-conventional
|
||||||
@commitlint/travis-cli
|
@commitlint/travis-cli
|
||||||
- commitlint-travis
|
- commitlint-travis
|
||||||
# Run the `rubocop` linter in a separate job that is allowed to fail
|
|
||||||
# Once these lint errors are fixed, this can be merged into a single job
|
|
||||||
- language: node_js
|
|
||||||
node_js: lts/*
|
|
||||||
env: Lint_rubocop
|
|
||||||
name: 'Lint: rubocop'
|
|
||||||
before_install: skip
|
|
||||||
script:
|
|
||||||
# Install and run `rubocop`
|
|
||||||
- gem install rubocop
|
|
||||||
- rubocop -d
|
|
||||||
|
|
||||||
# Run `pre-commit` linters in a single job
|
# Run `pre-commit` linters in a single job
|
||||||
- language: 'python'
|
- language: 'python'
|
||||||
|
Loading…
Reference in New Issue
Block a user