test: fix rubocop violations
Use method: 1. `rubocop -a --safe` 2. `rubocop -A --safe` 3. Use `rubocop:disable` ``` Offenses: test/integration/default/controls/config_spec.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string literal comment. control 'Php configuration' do ^ test/integration/default/controls/config_spec.rb:4:3: C: Metrics/AbcSize: Assignment Branch Condition size for test_debian is too high. [<0, 26, 0> 26/17] (http://c2.com/cgi/wiki?AbcMetric, https://en.wikipedia.org/wiki/ABC_Software_Metric) def test_debian ... ^^^^^^^^^^^^^^^ test/integration/default/controls/config_spec.rb:4:3: C: Metrics/MethodLength: Method has too many lines. [14/10] (https://rubystyle.guide#short-methods) def test_debian ... ^^^^^^^^^^^^^^^ test/integration/default/controls/config_spec.rb:24:3: C: Style/EmptyMethod: Put empty method definitions on a single line. (https://rubystyle.guide#no-single-line-methods) def test_redhat ... ^^^^^^^^^^^^^^^ test/integration/default/controls/config_spec.rb:27:3: C: Style/EmptyMethod: Put empty method definitions on a single line. (https://rubystyle.guide#no-single-line-methods) def test_suse ... ^^^^^^^^^^^^^ test/integration/default/controls/package_spec.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string literal comment. control 'Php package' do ^ test/integration/default/controls/package_spec.rb:4:3: C: Metrics/AbcSize: Assignment Branch Condition size for test_debian is too high. [<1, 26, 1> 26.04/17] (http://c2.com/cgi/wiki?AbcMetric, https://en.wikipedia.org/wiki/ABC_Software_Metric) def test_debian ... ^^^^^^^^^^^^^^^ test/integration/default/controls/package_spec.rb:4:3: C: Metrics/MethodLength: Method has too many lines. [20/10] (https://rubystyle.guide#short-methods) def test_debian ... ^^^^^^^^^^^^^^^ test/integration/default/controls/package_spec.rb:21:1: C: Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies) test/integration/default/controls/service_spec.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string literal comment. control 'Php service' do ^ test/integration/default/controls/service_spec.rb:16:3: C: Style/EmptyMethod: Put empty method definitions on a single line. (https://rubystyle.guide#no-single-line-methods) def test_redhat ... ^^^^^^^^^^^^^^^ test/integration/default/controls/service_spec.rb:19:3: C: Style/EmptyMethod: Put empty method definitions on a single line. (https://rubystyle.guide#no-single-line-methods) def test_suse ... ^^^^^^^^^^^^^ 7 files inspected, 12 offenses detected, 8 offenses auto-correctable ```
This commit is contained in:
parent
f88fdf784a
commit
1a4d20877c
@ -1,6 +1,9 @@
|
|||||||
|
# frozen_string_literal: true
|
||||||
|
|
||||||
control 'Php configuration' do
|
control 'Php configuration' do
|
||||||
title 'should match desired lines'
|
title 'should match desired lines'
|
||||||
|
|
||||||
|
# rubocop:disable Metrics/MethodLength, Metrics/AbcSize
|
||||||
def test_debian
|
def test_debian
|
||||||
describe file('/etc/php/5.6/fpm/pool.d/radius-admin.conf') do
|
describe file('/etc/php/5.6/fpm/pool.d/radius-admin.conf') do
|
||||||
its('content') { should include '[radius-admin]' }
|
its('content') { should include '[radius-admin]' }
|
||||||
@ -20,12 +23,11 @@ control 'Php configuration' do
|
|||||||
its('content') { should include 'date.timezone = Europe/Paris' }
|
its('content') { should include 'date.timezone = Europe/Paris' }
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
# rubocop:enable Metrics/MethodLength, Metrics/AbcSize
|
||||||
|
|
||||||
def test_redhat
|
def test_redhat; end
|
||||||
end
|
|
||||||
|
|
||||||
def test_suse
|
def test_suse; end
|
||||||
end
|
|
||||||
|
|
||||||
case os[:family]
|
case os[:family]
|
||||||
when 'debian'
|
when 'debian'
|
||||||
|
@ -1,6 +1,9 @@
|
|||||||
|
# frozen_string_literal: true
|
||||||
|
|
||||||
control 'Php package' do
|
control 'Php package' do
|
||||||
title 'should be installed'
|
title 'should be installed'
|
||||||
|
|
||||||
|
# rubocop:disable Metrics/MethodLength, Metrics/AbcSize
|
||||||
def test_debian
|
def test_debian
|
||||||
describe package('php-imagick') do
|
describe package('php-imagick') do
|
||||||
it { should be_installed }
|
it { should be_installed }
|
||||||
@ -18,7 +21,6 @@ control 'Php package' do
|
|||||||
bz2 cli curl fpm gd imap intl mbstring
|
bz2 cli curl fpm gd imap intl mbstring
|
||||||
mysql readline xml zip
|
mysql readline xml zip
|
||||||
].each do |pkg|
|
].each do |pkg|
|
||||||
|
|
||||||
describe package("php5.6-#{pkg}") do
|
describe package("php5.6-#{pkg}") do
|
||||||
it { should be_installed }
|
it { should be_installed }
|
||||||
end
|
end
|
||||||
@ -28,6 +30,7 @@ control 'Php package' do
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
# rubocop:enable Metrics/MethodLength, Metrics/AbcSize
|
||||||
|
|
||||||
def test_redhat
|
def test_redhat
|
||||||
describe package('php') do
|
describe package('php') do
|
||||||
|
@ -1,3 +1,5 @@
|
|||||||
|
# frozen_string_literal: true
|
||||||
|
|
||||||
control 'Php service' do
|
control 'Php service' do
|
||||||
title 'should be running and enabled'
|
title 'should be running and enabled'
|
||||||
|
|
||||||
@ -13,11 +15,9 @@ control 'Php service' do
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_redhat
|
def test_redhat; end
|
||||||
end
|
|
||||||
|
|
||||||
def test_suse
|
def test_suse; end
|
||||||
end
|
|
||||||
|
|
||||||
case os[:family]
|
case os[:family]
|
||||||
when 'debian'
|
when 'debian'
|
||||||
|
Loading…
Reference in New Issue
Block a user