From 63ad14efb1fa6d7c2aab7aa295941acd504c329f Mon Sep 17 00:00:00 2001
From: tmeneau <tmeneau@xetus.com>
Date: Fri, 3 Aug 2018 08:35:42 -0400
Subject: [PATCH] Fix invalid require_in sshd_config for key states

Change the require_ins used by the key management states in the
config.sls to be conditional based on whether the sshd_config
is managed by the formula

Fixes #130
---
 openssh/config.sls | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/openssh/config.sls b/openssh/config.sls
index dd5ac2f..eb721e9 100644
--- a/openssh/config.sls
+++ b/openssh/config.sls
@@ -1,9 +1,11 @@
 {% from "openssh/map.jinja" import openssh with context %}
 
+{%- set manage_sshd_config = salt['pillar.get']('sshd_config', False) %}
+
 include:
   - openssh
 
-{% if salt['pillar.get']('sshd_config', False) %}
+{% if manage_sshd_config %}
 sshd_config:
   file.managed:
     - name: {{ openssh.sshd_config }}
@@ -38,8 +40,10 @@ ssh_host_{{ keyType }}_key:
     - contents_pillar: 'openssh:{{ keyType }}:private_key'
     - user: root
     - mode: 600
+    {%- if manage_sshd_config %}
     - require_in:
       - file: sshd_config
+    {%- endif %}
     - watch_in:
       - service: {{ openssh.service }}
 
@@ -49,8 +53,10 @@ ssh_host_{{ keyType }}_key.pub:
     - contents_pillar: 'openssh:{{ keyType }}:public_key'
     - user: root
     - mode: 600
+    {%- if manage_sshd_config %}
     - require_in:
       - file: sshd_config
+    {%- endif %}
     - watch_in:
       - service: {{ openssh.service }}
 {%-   elif salt['pillar.get']('openssh:generate_' ~ keyType ~ '_keys', False) %}
@@ -68,8 +74,10 @@ ssh_generate_host_{{ keyType }}_key:
     - name: "rm {{ keyFile }}*; ssh-keygen -t {{ keyType }} {{ keySizePart }} -N '' -f {{ keyFile }}"
     - unless: "test -s {{ keyFile }}"
     - runas: root
+    {%- if manage_sshd_config %}
     - require_in:
       - file: sshd_config
+    {%- endif %}
     - watch_in:
       - service: {{ openssh.service }}
 
@@ -80,8 +88,10 @@ ssh_host_{{ keyType }}_key:  # set permissions
     - mode: 0600
     - require:
       - cmd: ssh_generate_host_{{ keyType }}_key
+    {%- if manage_sshd_config %}
     - require_in:
       - file: sshd_config
+    {%- endif %}
 
 {%-   elif salt['pillar.get']('openssh:absent_' ~ keyType ~ '_keys', False) %}
 ssh_host_{{ keyType }}_key: