Commit Graph

232 Commits

Author SHA1 Message Date
Niels Abspoel
cf901ef465
Merge pull request #33 from myii/feat/implement-semantic-release
feat(semantic-release): implement for this formula
2019-11-09 15:58:03 +01:00
Imran Iqbal
3df11fc75c
docs(readme): modify according to standard structure 2019-11-09 08:24:56 +00:00
Imran Iqbal
d47265f974
docs(readme): move to docs/ directory 2019-11-09 08:24:55 +00:00
Imran Iqbal
8136b75fa0
fix(rubocop): add fixes using rubocop --safe-auto-correct 2019-11-09 08:24:55 +00:00
Imran Iqbal
0f808d6afb
fix(yamllint): fix all errors
```bash
firewalld-formula$ yamllint -s .
./pillar.example
  2:1       warning  missing document start "---"  (document-start)
  3:12      warning  truthy value should be one of [false, true]  (truthy)
  12:13     warning  truthy value should be one of [false, true]  (truthy)
  15:89     error    line too long (108 > 88 characters)  (line-length)
  19:13     warning  truthy value should be one of [false, true]  (truthy)
  30:89     error    line too long (363 > 88 characters)  (line-length)
  96:89     error    line too long (170 > 88 characters)  (line-length)
  108:15    error    wrong indentation: expected 12 but found 14  (indentation)
  115:13    error    empty value in block mapping  (empty-values)
  116:2     error    syntax error: found character '%' that cannot start any token
  152:89    error    line too long (112 > 88 characters)  (line-length)

./firewalld/defaults.yaml
  3:1       warning  missing document start "---"  (document-start)
```
2019-11-09 08:24:55 +00:00
Imran Iqbal
de4e1915fb
fix(map.jinja): fix salt-lint errors
```bash
Examining firewalld/map.jinja of type state
[209] Jinja comment should have spaces before and after: {# comment #}
firewalld/map.jinja:4
{## Start with  defaults from defaults.yaml ##}

[209] Jinja comment should have spaces before and after: {# comment #}
firewalld/map.jinja:7
{##

[201] Trailing whitespace
firewalld/map.jinja:16
  }, grain='os_family', merge=salt['pillar.get']('firewalld:lookup'))

[209] Jinja comment should have spaces before and after: {# comment #}
firewalld/map.jinja:19
{## Merge the flavor_map to the default settings ##}

[209] Jinja comment should have spaces before and after: {# comment #}
firewalld/map.jinja:22
{## Merge in salt:lookup pillar ##}
```
2019-11-09 08:24:55 +00:00
Imran Iqbal
c5f114d886
feat(semantic-release): implement for this formula
* Automated using https://github.com/myii/ssf-formula/pull/95
2019-11-09 08:24:55 +00:00
Imran Iqbal
db9597e398
Merge pull request #32 from Sxderp/pr-remove-unexpected-icmp-block-attribtue
Remove name attribute in icmp-block-inversion
2019-11-08 18:52:47 +00:00
Steven Daniele
12b696a8fe Remove name attribute in icmp-block-inversion
Firewalld does not parse the name attribute.

Log message:
firewalld[1999]: ERROR: Failed to load zone file 'public.xml':
PARSE_ERROR: icmp-block-inversion: Unexpected attribute name
2019-11-08 10:37:31 -05:00
Imran Iqbal
9646ead4b4
Merge pull request #31 from Sxderp/pr-fix-block-inversion-key-name
Fix typo in icmp block inversion key name
2019-11-08 15:13:25 +00:00
Steven Daniele
64825e20ab Fix typo in icmp block inversion key name 2019-11-08 09:39:57 -05:00
Niels Abspoel
ae1f2453d3 add updated firewalld.conf from 0.7.1 2019-09-15 21:01:15 +01:00
Niels Abspoel
4937787038
Merge pull request #29 from noelmcloughlin/arch
feat(linux): archlinux support (no osfinger grain)
2019-08-04 21:23:15 +02:00
N
ad37448038
feat(linux): archlinux support (no osfinger grain) 2019-08-03 14:59:08 +01:00
Imran Iqbal
46288d6b50
Merge pull request #28 from aboe76/update_test_images
update test images
2019-04-30 20:07:25 +01:00
Niels Abspoel
f560dcd1b4 add @myii recommendations 2019-04-30 20:55:32 +02:00
Niels Abspoel
d201f448c9 update test images 2019-04-30 19:26:04 +02:00
Imran Iqbal
6a546ca192
Merge pull request #27 from aboe76/improve_service
update service and zones with more options
2019-04-06 22:39:30 +01:00
Niels Abspoel
a438f30f50 fix spacing in closing tags 2019-04-06 23:26:48 +02:00
Niels Abspoel
9522826dcb update gems 2019-04-06 22:03:15 +02:00
Niels Abspoel
87ecf4eea4 update gems 2019-04-06 21:58:48 +02:00
Niels Abspoel
18fc482853 update service and zones with more options
update kitchen travis
fix ipsets.sls
2019-04-06 21:40:50 +02:00
Javier Bértoli
f5c2acbd3a
Merge pull request #25 from aboe76/fix_travis
update kitchen.yml and Gemfile
2018-12-23 19:55:19 -03:00
Niels Abspoel
b05886c13e update kitchen.yml and Gemfile 2018-12-22 19:38:27 +01:00
Niels Abspoel
22e301a218
Merge pull request #24 from valibud/master
Add support for inet6 ipsets.
2018-12-10 20:01:04 +01:00
Valentin Bud
d1d7a9186c Add support for inet6 ipsets. 2018-12-10 13:44:53 +02:00
Niels Abspoel
a2d99c5957
Merge pull request #23 from netmanagers/master
Refactor ipset & backend
2018-08-26 07:55:00 +02:00
Javier Bértoli
951050008d Update pillar.example 2018-08-25 19:05:21 -03:00
Javier Bértoli
15a48462f0 Refactor backend format, add backward compatibility, simple pkg testing
See https://github.com/saltstack-formulas/firewalld-formula/pull/21#pullrequestreview-146958098
2018-08-25 19:00:11 -03:00
Javier Bértoli
d3928d1be0 Refactor ipset format, add backward compatibility
See https://github.com/saltstack-formulas/firewalld-formula/pull/21#pullrequestreview-146958098
2018-08-25 18:27:37 -03:00
Javier Bértoli
7bc3a9cdd4 Use mapped data instead of pillar.get data 2018-08-25 18:20:27 -03:00
Javier Bértoli
bcd47361ca Refactor .kitchen.yml to use pillar.example as pillar 2018-08-25 18:13:06 -03:00
Niels Abspoel
9017ad5ea2
Merge pull request #22 from netmanagers/master
Update testing environment
2018-08-25 21:36:47 +02:00
Javier Bértoli
e513275112 Updated REDME 2018-08-25 16:16:01 -03:00
Javier Bértoli
b641216b8b Update testing environment 2018-08-25 16:08:24 -03:00
Javier Bértoli
8694a11de5
Merge pull request #21 from aboe76/update_config_6.x
update firewalld formula for firewalld > 0.6
2018-08-16 15:19:46 -03:00
Niels Abspoel
7c0b6aeb55 fix whitespacing 2018-08-14 19:52:08 +02:00
Niels Abspoel
36da1094b7 update firewalld formula for firewalld > 0.6 2018-08-12 20:26:21 +02:00
Niels Abspoel
1ddb09137c
Merge pull request #20 from noelmcloughlin/suseSupport
notify nosupport if SLES version < 15
2018-06-05 17:04:53 +02:00
N
1ba51b8583 notify nosupport if SLES version < 15 2018-06-05 15:36:29 +01:00
Niels Abspoel
1038546745
Merge pull request #19 from noelmcloughlin/renamefile
fix filename
2018-06-01 21:23:25 +02:00
N
ac07060c6f fix filename 2018-06-01 19:19:12 +01:00
Niels Abspoel
31ad6eb4c2
Merge pull request #17 from saltstack-formulas/revert-16-master
Revert "Fix ipset:type colon handling error"
2018-05-13 22:15:20 +02:00
Niels Abspoel
c7f4b3a611
Revert "Fix ipset:type colon handling error" 2018-05-13 22:14:49 +02:00
Niels Abspoel
0a1f82dbf6
Merge pull request #16 from netmanagers/master
Fix ipset:type colon handling error
2018-05-13 21:58:24 +02:00
Javier Bértoli
2fc03fbd70 Fix ipset:type colon handling error 2018-05-10 07:53:54 -03:00
Niels Abspoel
b607a7abdd
Merge pull request #15 from Angelo-Verona/master
Default file permission for firewalld.conf
2017-12-28 11:08:57 +01:00
Angelo Verona
b1d6b52307 Default file permission for firewalld.conf is 644 not 640 (CentOS). Even if I think that "others" don't need to read that, it always shows up as file with non-default permissions from default rpm package in security scans. e.g. "rpm -Va |grep ^.M" or more salty way: "salt '*' pkg.verify" / salt '*' pkg.modified firewalld mode=True; manual fix e.g. rpm --setperms firewalld-*.el7.noarch 2017-12-28 02:45:05 +01:00
Niels Abspoel
28a15e1707
Merge pull request #14 from pauldalewilliams/add-ipset-as-source-in-zones
Add support for using ipsets as sources in a zone
2017-11-25 19:06:05 +01:00
Paul Williams
2fd70c9f41
Add support for using ipsets as sources in a zone
I wanted to be able to add an ipset as a source in the zone without using a rich rule.  I believe this change accomplishes that.  Tested and working on CentOS 7 (salt master and minion).
2017-11-24 18:31:17 -05:00