From 12b696a8fedc7e8909ce4bd2f3b2a1f82e5db6be Mon Sep 17 00:00:00 2001
From: Steven Daniele <sdaniele@gatech.edu>
Date: Fri, 8 Nov 2019 10:37:31 -0500
Subject: [PATCH] Remove name attribute in icmp-block-inversion

Firewalld does not parse the name attribute.

Log message:
firewalld[1999]: ERROR: Failed to load zone file 'public.xml':
PARSE_ERROR: icmp-block-inversion: Unexpected attribute name
---
 firewalld/files/zone.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/firewalld/files/zone.xml b/firewalld/files/zone.xml
index eb9d4b9..6525d71 100644
--- a/firewalld/files/zone.xml
+++ b/firewalld/files/zone.xml
@@ -56,8 +56,8 @@
   <icmp-block name="{{ v }}" />
   {%- endfor %}
 {%- endif %}
-{%- if 'icmp_block_inversion' in zone %}
-  <icmp-block-inversion name="{{ zone.icmp_block_inversion }}" />
+{%- if 'icmp_block_inversion' in zone and zone.icmp_block_inversion %}
+  <icmp-block-inversion />
 {%- endif %}
 {%- if 'masquerade' in zone %}
   {%- if zone.masquerade %}