From 1db59c0e614f00a09a3f9daa69afa400415e5872 Mon Sep 17 00:00:00 2001
From: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Date: Tue, 17 Sep 2024 00:40:49 +0200
Subject: [PATCH] Improve test matrix

Simplify YAML structure and parsing by removing the superfluous list
layer.
Add additional matrix entries to cover more user ACL constellations.

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
---
 tests/matrix.yaml   | 143 +++++++++++++++++++++++++++++++-------------
 tests/test_pyacl.py |   7 +--
 2 files changed, 104 insertions(+), 46 deletions(-)

diff --git a/tests/matrix.yaml b/tests/matrix.yaml
index 143c151..f3522dc 100644
--- a/tests/matrix.yaml
+++ b/tests/matrix.yaml
@@ -1,43 +1,106 @@
 ---
-- user:user:r:
+user:user:r:
+  user:
     user:
-      user:
-        read: true
-        write: false
-        execute: false
-    group:
-      null:
-        read: true
-        write: false
-        execute: false
-    mask:
-      null:
-        read: true
-        write: false
-        execute: false
-    other:
-      null:
-        read: true
-        write: false
-        execute: false
-- user:user:-w-:
+      read: true
+      write: false
+      execute: false
+  group:
+    null:
+      read: true
+      write: false
+      execute: false
+  mask:
+    null:
+      read: true
+      write: false
+      execute: false
+  other:
+    null:
+      read: true
+      write: false
+      execute: false
+user:user:-w-:
+  user:
     user:
-      user:
-        read: false
-        write: true
-        execute: false
-    group:
-      null:
-        read: true
-        write: false
-        execute: false
-    mask:
-      null:
-        read: true
-        write: true
-        execute: false
-    other:
-      null:
-        read: true
-        write: false
-        execute: false
+      read: false
+      write: true
+      execute: false
+  group:
+    null:
+      read: true
+      write: false
+      execute: false
+  mask:
+    null:
+      read: true
+      write: true
+      execute: false
+  other:
+    null:
+      read: true
+      write: false
+      execute: false
+user:user:--x:
+  user:
+    user:
+      read: false
+      write: false
+      execute: true
+  group:
+    null:
+      read: true
+      write: false
+      execute: false
+  mask:
+    null:
+      read: true
+      write: false
+      execute: true
+  other:
+    null:
+      read: true
+      write: false
+      execute: false
+user:user:r-x:
+  user:
+    user:
+      read: true
+      write: false
+      execute: true
+  group:
+    null:
+      read: true
+      write: false
+      execute: false
+  mask:
+    null:
+      read: true
+      write: false
+      execute: true
+  other:
+    null:
+      read: true
+      write: false
+      execute: false
+user:user:rwx:
+  user:
+    user:
+      read: true
+      write: true
+      execute: true
+  group:
+    null:
+      read: true
+      write: false
+      execute: false
+  mask:
+    null:
+      read: true
+      write: true
+      execute: true
+  other:
+    null:
+      read: true
+      write: false
+      execute: false
diff --git a/tests/test_pyacl.py b/tests/test_pyacl.py
index 286df8d..97eec9a 100644
--- a/tests/test_pyacl.py
+++ b/tests/test_pyacl.py
@@ -20,12 +20,7 @@ def load_yaml(file):
   with open(join(dirname(__file__), file)) as fh:
     data = safe_load(fh)
 
-  out = []
-
-  for entry in data:
-    out.append(tuple(entry.items())[0])
-
-  return out
+  return list(data.items())
 
 
 @mark.parametrize('aclin, aclout', load_yaml('matrix.yaml'))