Limnoria/test
Val Lorentz 2902a85dbd
Fix STS parsing and handling of unchecked-TLS connections (#1524)
* ircutils: Fix incorrect log message on invalid STS policy

* STS: fix confusion over what a secure connection is

irclib computed 'secure_connection' when TLS is enabled and TLS certs
are checked; but ircutils used the value to parse STS policies, which
should only care about being TLS or not.

This commit fixes the incorrect parsing on unchecked-TLS, and triggers
a reconnect when a STS policy is encountered in this case, to force
TLS certs to be checked before storing the policy.

* Accept STS policies when reconnecting after getting it over cleartext

ircutils.parseStsPolicy() was passed self.driver.ssl which is the configured
value, even though the connection was forced to be TLS temporarily

* ci: Lower timeout

* Fix typo in test name

Co-authored-by: James Lu <james@overdrivenetworks.com>

---------

Co-authored-by: James Lu <james@overdrivenetworks.com>
2023-06-10 08:28:08 +02:00
..
__init__.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
messages.pot Add tests for nicksToHostmasks 2022-11-23 19:25:12 +01:00
test.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_callbacks.py Modernize tests 2022-11-20 19:33:23 +01:00
test_commands.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_conf.py Fix joins to many channels (#1473) 2021-06-14 23:15:43 +02:00
test_drivers.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_dynamicScope.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_firewall.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_format.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_i18n.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_ircdb.py Modernize tests 2022-11-20 19:33:23 +01:00
test_irclib.py Fix STS parsing and handling of unchecked-TLS connections (#1524) 2023-06-10 08:28:08 +02:00
test_ircmsgs.py Modernize tests 2022-11-20 19:33:23 +01:00
test_ircutils.py Modernize tests 2022-11-20 19:33:23 +01:00
test_misc.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_plugin.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_plugin_create.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_plugins.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_registry.py Add test for registry reloading 2022-12-28 17:06:02 +01:00
test_schedule.py test: Revert generic 'The Limnoria Contributors' in copyright notices 2022-10-24 23:41:26 +02:00
test_standardSubstitute.py Modernize tests 2022-11-20 19:33:23 +01:00
test_utils.py Modernize tests 2022-11-20 19:33:23 +01:00
test_yn.py Remove unused import fallback on the 'mock' library 2023-01-21 18:51:17 +01:00