Commit Graph

6929 Commits

Author SHA1 Message Date
James McCoy
3db5727a9d Merge branch 'disable' into maint/0.83.4 2011-10-22 15:52:34 -04:00
Valentin Lorentz
8fb97c56bc Owner: Fix bug with @enable and @disable if a plugin is given. Closes GH-43. Closes GH-44.
Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2011-10-22 15:52:19 -04:00
James McCoy
964c73f591 RSS._getConverter: Encode strings before handing them off to other functions
When the feed has a specified encoding, we'll be dealing with unicode objects
in the response from feedparser.parse().  To avoid possible UnicodeErrors, we
need to encode() before handing the string off to other functions, so the
other functions are always dealing with bytestrings instead of bytestrings and
unicode objects.  Mixing unicode and bytestrings will cause implicit
conversions of the unicode objects, which will most likely use the wrong
encoding.

Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2011-10-22 15:23:56 -04:00
James McCoy
01c8dc7f78 String.decode: Only encode('utf-8') when the decode string is unicode
Closes: Sf#3165718
Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2011-10-22 14:57:20 -04:00
Daniel Folkinshteyn
8f7c4bdf7f Fix banmask creation. Thanks Progval for the patch!
fixes https://sourceforge.net/tracker/?func=detail&aid=3088559&group_id=58965&atid=489447

incorporating patch https://sourceforge.net/tracker/?func=detail&aid=3163843&group_id=58965&atid=489449

Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2011-10-22 14:25:26 -04:00
Daniel Folkinshteyn
df5391dcf7 Socket driver: implement ssl connection support.
Signed-off-by: James McCoy <jamessan@users.sourceforge.net>
2011-10-22 14:09:06 -04:00
James Vega
4661acb3a3 Honor supybot-test's timeout option and document the units
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2011-08-22 14:07:39 -04:00
James Vega
0cd4939678 Seen: Anchor nick regexp to ensure valid match.
When searching for 'st*ke', 'stryker' would incorrectly match, 'stryke' would
be added to the nick set and the subsequent lookup would cause a KeyError.
This is fixed both by anchoring the regexp ('^st.*ke$' instead of 'st.*ke')
and adding searchNick to the nick set instead of the string that matched the
pattern.

Closes: Sf#3377381

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2011-08-02 22:19:47 -04:00
James Vega
b0e595fbd2 Update Internet.hexip to handle IPv6
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2011-06-06 22:29:21 -04:00
James Vega
d56381436c Update Internet.dns to handle IPv6 IPs and responses
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2011-06-06 22:28:35 -04:00
James Vega
543e78828b Add utils.net.isIPV4, with utils.net.isIP checking v4 or v6
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2011-06-06 21:44:15 -04:00
James Vega
cb48912db6 Services: Correct formatting of "isn't registered" log.
Closes: Sf#3075937
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-10-03 14:58:38 -04:00
James Vega
ca56575eb5 Unix: Use converter to enforce "no spaces" for spell's argument.
Closes: Sf#3064304
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-20 19:44:01 -04:00
James Vega
89df85c3b3 README: It's a 3-clause, not 2-clause BSD license.
Closes: Sf#3069906
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-20 19:25:47 -04:00
James Vega
0fd6a84632 Use self.error() instead of raise for BooleanRequiredFalseOnWindows.
Closes: Sf#3070285
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-20 18:34:07 -04:00
James Vega
074ded49e4 Use the plugin name for Owner.defaultplugin's error message.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-20 18:20:52 -04:00
James Vega
154fbc30e9 Games: Re-add some, much higher, upper limits to dice.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-09 00:00:47 -04:00
James Vega
45abdc8248 Karma: Refer to plugins.Karma.rankingDisplay in Karma.karma's help.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-08 23:44:40 -04:00
James Vega
b0575cec88 Handle changes to fnmatch.translate in Python 2.6
Define utils.python.glob2re based on the Python version being used.
Use glob2re in Todo and Note plugins.

Closes: Sf#3059292
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-08 23:31:01 -04:00
James Vega
fc2a84fb90 <text> -> <thing> in Karma.karma's help
Closes: Sf#3057517
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-08 22:43:45 -04:00
James Vega
c0e24cef30 Limiter: Fix "reduce limit" test case.
Closes: Sf#3058142
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-08 22:42:07 -04:00
James Vega
c9274606ce Google: Remove Groups snarfer
The regular expressions were woefully out of date and since there's not a
stable API (or any for that matter), keeping things working is a losing
battle.

Closes: Sf#3057485
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-08 22:20:23 -04:00
James Vega
7cf61ad046 Games: Remove arbitrary upper limits on dice command.
Closes: Sf#3057255
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-08 21:35:22 -04:00
James Vega
63244b1e47 News: Use positiveInt converter instead of manual checks.
Closes: Sf#3059239
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-09-05 01:09:43 -04:00
James Vega
8cc6320768 Channel: Correct specification of "#channel,op" capability.
Closes: Sf#3055991
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-31 19:00:28 -04:00
James Vega
bc98577fb1 Dict: Refer to the server config variable in Dict.dict's help.
Closes: Sf#3056621
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-31 18:46:05 -04:00
James Vega
577294f489 User: Handle DuplicateHostmask exception in hostmask.add.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 11:32:39 -04:00
James Vega
de726f90f3 User: Only require name for set.password when changing other user's password.
Closes: Sf#3055358
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 11:32:23 -04:00
James Vega
f977a3a260 User: Require set.password be sent in private.
Closes: Sf#3055365
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 11:03:41 -04:00
James Vega
07da8cab13 User: Specify chanagename must be used in private in its help.
Closes: Sf#3055353
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 10:49:13 -04:00
James Vega
25b987cc58 Model Admin's ignore help after Channel's.
Closes: Sf#3054919
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 10:26:59 -04:00
James Vega
e7ef97e529 Ensure channel-specific reply.whenNotAddressed works.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 166f32dcb0)
2010-08-24 19:52:59 -04:00
James Vega
0ff414b993 Services: Don't filter outgoing JOIN messages on disabled networks
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit acffde68ab)
2010-08-24 19:52:22 -04:00
James Vega
3f63917dc2 Use conf.registerGlobalValue to ensure generated values are properly setup.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 0c62204809)
2010-08-24 19:52:09 -04:00
James Vega
8c280369a6 Services: Properly register the NickServ.password group and child values.
Closes: Sf#3019174

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit d78f7b6ac5)
2010-08-24 19:51:51 -04:00
James Vega
31d5191dcd supybot: Remove extraneous sys.stdin.close()
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 0e22e218f0)
2010-08-24 19:51:33 -04:00
James Vega
0f877166ad Services: Fix conflict with callbacks.Commands.isDisabled
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit f926804f40)
2010-08-24 19:51:09 -04:00
Daniel Folkinshteyn
abf6df9e13 fix google calc to work when doing a currency conversion.
made the calcre more generic, so it finds stuff on both math and currency.
nothing a little exploration of google html page source couldn't solve.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 432228c736)
2010-08-24 19:50:47 -04:00
Daniel Folkinshteyn
9e1ba9910a make Misc.apropos return plugin name even if command is in only one plugin.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 8daebd1240)
2010-08-24 19:50:22 -04:00
James Vega
976567c1ac Services: Disable most of the plugin on networks in the disabled list.
Notify the user when trying to use the commands on a disabled network, ignore
noJoinsUntilIdentified, and don't try communicating with services.

Closes: Sf#3018464

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 9e73f4482c)
2010-08-24 19:50:11 -04:00
James Vega
8d5e4ba624 Twisted: Send all available ircmsgs and reduce delay between checks
All ircmsgs that takeMsg will return should be processed each time
checkIrcForMsgs is called since there may be multiple available in the
fastqueue.

Reduced the time between calls of checkIrcForMsgs so the delay between
normally queued ircmsgs stays close to the configured throttleTime.

Closes: Sf#3018148
(cherry picked from commit adc5d62bbf)
2010-08-24 19:49:54 -04:00
James Vega
ff760d1c69 Socket: Ensure driver is flagged as disconnected after a socket error.
Users were occasionally hitting a situation where the socket had errored,
causing a reconnect, but the socket wasn't closed nor the driver marked as
disconnected.  This resulted in run() continuing to try and use the driver,
which would cause another error, schedule another reconnect, log an error, ad
infinitum.

Closes: Sf#2965530

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit a278d17f2b)
2010-08-24 19:49:38 -04:00
James Vega
a6857ce9bf utils/web.py: Only try catching socket.sslerror if built with SSL support
Closes: Sf#2998820

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit f03a3f6c85)
2010-08-24 19:49:30 -04:00
James Vega
246e09cc99 Anonymous: Implement support for allowPrivateTarget config.
Closes: Sf#2991515

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 57e894de58)
2010-08-24 19:49:14 -04:00
Daniel Folkinshteyn
e9d55d4bbd fix bug in RSS.announce.list:
Because the 'channel' argument was declared optional, calling announce.list
off-channel without a channel argument caused an error.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 40941e044a)
2010-08-24 19:48:42 -04:00
Daniel Folkinshteyn
4f2279fc92 Improve supybot-botchk documentation. Make a note that supybot.pidFile config must be set for it to work.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 79c7514f1a)
2010-08-24 19:46:38 -04:00
Daniel Folkinshteyn
fb8d0d320a fix alias bug https://sourceforge.net/tracker/?func=detail&aid=2987147&group_id=58965&atid=489447
add tests for appropriate behavior

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 8d64d08645)
2010-08-24 19:45:48 -04:00
James Vega
7869b962d1 Fix the previous Factoids fix.
channel needs to be part of the args list.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit fe07ea1146)
2010-08-24 19:44:56 -04:00
James Vega
b2c45caa66 Factoids: Pass channel to whatis when being called from search
Thanks to Daniel Folkinshteyn for the fix.

Closes: Sf#2965589

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 209facd242)
2010-08-24 19:44:45 -04:00
James Vega
fa199022e1 Make registry.Regexp.error mimic registry.Value.error
Regexp.error can't directly call Value.error because it's providing extra
information, so it needs to build the InvalidRegistryValue exception itself
and raise it.

Closes: Sf#2985241

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit ef8bd817e8)
2010-08-24 19:44:31 -04:00