Commit Graph

7067 Commits

Author SHA1 Message Date
James Vega 7d87d2f87a Merge branch 'maint/0.83.4'
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 11:34:55 -04:00
James Vega 577294f489 User: Handle DuplicateHostmask exception in hostmask.add.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 11:32:39 -04:00
James Vega de726f90f3 User: Only require name for set.password when changing other user's password.
Closes: Sf#3055358
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 11:32:23 -04:00
James Vega f977a3a260 User: Require set.password be sent in private.
Closes: Sf#3055365
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 11:03:41 -04:00
James Vega 07da8cab13 User: Specify chanagename must be used in private in its help.
Closes: Sf#3055353
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 10:49:13 -04:00
James Vega 25b987cc58 Model Admin's ignore help after Channel's.
Closes: Sf#3054919
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-29 10:26:59 -04:00
James Vega e7ef97e529 Ensure channel-specific reply.whenNotAddressed works.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 166f32dcb0)
2010-08-24 19:52:59 -04:00
James Vega 0ff414b993 Services: Don't filter outgoing JOIN messages on disabled networks
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit acffde68ab)
2010-08-24 19:52:22 -04:00
James Vega 3f63917dc2 Use conf.registerGlobalValue to ensure generated values are properly setup.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 0c62204809)
2010-08-24 19:52:09 -04:00
James Vega 8c280369a6 Services: Properly register the NickServ.password group and child values.
Closes: Sf#3019174

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit d78f7b6ac5)
2010-08-24 19:51:51 -04:00
James Vega 31d5191dcd supybot: Remove extraneous sys.stdin.close()
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 0e22e218f0)
2010-08-24 19:51:33 -04:00
James Vega 0f877166ad Services: Fix conflict with callbacks.Commands.isDisabled
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit f926804f40)
2010-08-24 19:51:09 -04:00
Daniel Folkinshteyn abf6df9e13 fix google calc to work when doing a currency conversion.
made the calcre more generic, so it finds stuff on both math and currency.
nothing a little exploration of google html page source couldn't solve.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 432228c736)
2010-08-24 19:50:47 -04:00
Daniel Folkinshteyn 9e1ba9910a make Misc.apropos return plugin name even if command is in only one plugin.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 8daebd1240)
2010-08-24 19:50:22 -04:00
James Vega 976567c1ac Services: Disable most of the plugin on networks in the disabled list.
Notify the user when trying to use the commands on a disabled network, ignore
noJoinsUntilIdentified, and don't try communicating with services.

Closes: Sf#3018464

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 9e73f4482c)
2010-08-24 19:50:11 -04:00
James Vega 8d5e4ba624 Twisted: Send all available ircmsgs and reduce delay between checks
All ircmsgs that takeMsg will return should be processed each time
checkIrcForMsgs is called since there may be multiple available in the
fastqueue.

Reduced the time between calls of checkIrcForMsgs so the delay between
normally queued ircmsgs stays close to the configured throttleTime.

Closes: Sf#3018148
(cherry picked from commit adc5d62bbf)
2010-08-24 19:49:54 -04:00
James Vega ff760d1c69 Socket: Ensure driver is flagged as disconnected after a socket error.
Users were occasionally hitting a situation where the socket had errored,
causing a reconnect, but the socket wasn't closed nor the driver marked as
disconnected.  This resulted in run() continuing to try and use the driver,
which would cause another error, schedule another reconnect, log an error, ad
infinitum.

Closes: Sf#2965530

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit a278d17f2b)
2010-08-24 19:49:38 -04:00
James Vega a6857ce9bf utils/web.py: Only try catching socket.sslerror if built with SSL support
Closes: Sf#2998820

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit f03a3f6c85)
2010-08-24 19:49:30 -04:00
James Vega 246e09cc99 Anonymous: Implement support for allowPrivateTarget config.
Closes: Sf#2991515

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 57e894de58)
2010-08-24 19:49:14 -04:00
Daniel Folkinshteyn e9d55d4bbd fix bug in RSS.announce.list:
Because the 'channel' argument was declared optional, calling announce.list
off-channel without a channel argument caused an error.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 40941e044a)
2010-08-24 19:48:42 -04:00
Daniel Folkinshteyn 4f2279fc92 Improve supybot-botchk documentation. Make a note that supybot.pidFile config must be set for it to work.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 79c7514f1a)
2010-08-24 19:46:38 -04:00
Daniel Folkinshteyn fb8d0d320a fix alias bug https://sourceforge.net/tracker/?func=detail&aid=2987147&group_id=58965&atid=489447
add tests for appropriate behavior

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 8d64d08645)
2010-08-24 19:45:48 -04:00
James Vega 7869b962d1 Fix the previous Factoids fix.
channel needs to be part of the args list.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit fe07ea1146)
2010-08-24 19:44:56 -04:00
James Vega b2c45caa66 Factoids: Pass channel to whatis when being called from search
Thanks to Daniel Folkinshteyn for the fix.

Closes: Sf#2965589

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 209facd242)
2010-08-24 19:44:45 -04:00
James Vega fa199022e1 Make registry.Regexp.error mimic registry.Value.error
Regexp.error can't directly call Value.error because it's providing extra
information, so it needs to build the InvalidRegistryValue exception itself
and raise it.

Closes: Sf#2985241

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit ef8bd817e8)
2010-08-24 19:44:31 -04:00
James Vega be9128b3ec Internet: Use whois-servers.net for all whois lookups.
rs.internic.net seems to be broken and using $tld.whois-servers.net looks to
be working for everything.

Also need to update the line termination string to use '\r\n' instead of '\n'
since some servers are strict about receiving the former.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 397cbbe0d3)
2010-08-24 19:44:18 -04:00
James Vega 8d94ff743c Include hostmasks in JOIN, PART, QUIT logs.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 4a9596608a)
2010-08-24 19:44:10 -04:00
James Vega 0933621dab Factoids: Prevent empty key or value when adding a factoid.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 10f5a12b7e)
2010-08-24 19:43:56 -04:00
James Vega e13d3d6943 Decode/encode as 'string_escape' when (de)serializing the registry.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
2010-08-24 19:43:24 -04:00
James Vega 455b5631bc Update plugins to ignore all non-ACTION CTCP messages.
Also update commands.urlSnarfer to do the same, which allows us to revert
"Don't bother snarfing URLs from non-Action CTCP messages."

This reverts commit 3282e3407e.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 288d7c6e02)
2010-08-24 19:42:11 -04:00
Jeremy Fincher e2cafb2e3d Don't bother snarfing URLs from non-Action CTCP messages.
(cherry picked from commit 3282e3407e)
2010-08-24 19:41:49 -04:00
James Vega f35e68cd65 Network: Properly parse WHOIS response
The 319 message that indicates which channel(s) a user is in prefix the
channel name with the modes (@, +, !, etc.) applied to that user.  These need
to be stripped from the channel name before we feed it to
irc.state.channels.get(), otherwise when irc.state.channels.get() returns None
we assume the channel can't be private and leak information.
(cherry picked from commit 408ab6f88a)
2010-08-24 19:41:30 -04:00
James Vega 4de4717f43 PLUGIN_TUTORIAL: Remove references to the old website.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 0806c0bbc3)
2010-08-24 19:41:04 -04:00
James Vega afb4e1e07f Use 0 when no results are returned for Google.fight
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 3689460d0f)
2010-08-24 19:40:54 -04:00
James Vega 2a79c0cab9 Fix supybot-botchk's use of subprocess
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit a48cd109a3)
2010-08-24 19:40:40 -04:00
James Vega a7c924b466 Switch from using the various popen flavors to subprocess.Popen
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit fbdc44ca52)
2010-08-24 19:40:23 -04:00
James Vega 2a18d07a2e Default to strict RFC compliance.
It's better to force people to use an RFC nick and change it after they
connect than to let non-RFC nicks get used and not be able to connect to the
network.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 07e283f450)
2010-08-24 19:26:13 -04:00
James Vega 9ddf07ce97 Allow Banmask.makeBanmask to work when dynamic.channel is None.
This gives back the ability to generate a banmask based on the global banmask
settings instead of per-channel settings.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 8a98653d3b)
2010-08-24 19:23:25 -04:00
James Vega c53f8cd510 Rename Owner.log to Owner.logmark
Since every plugin has a log method (to do actual logging), the log command
was conflicting with that.  The attempted workaround was overly complicated
and broken.  Simply renaming the command to logmark simplifies everything.

Closes Sf #2889709

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit acaa9b1fd6)
2010-08-24 19:21:58 -04:00
James Vega d95cdfec34 Remove supybot-plugin-package from the set of installed files.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit e393ea5917)
2010-08-24 19:21:49 -04:00
James Vega 56d97e0eeb Remove supybot-plugin-package.
It was never fully fleshed out.  If someone wants to finish it, they can
rewrite it or dig it out of the history and finish it.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 899391e4dc)
2010-08-24 19:16:20 -04:00
James Vega c5df44204d Use '2x' to reference Python version in README.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 96aaf159f6)
2010-08-24 19:16:10 -04:00
James Vega 2688467a31 Re-word the private message FAQ since +E UMODE is no longer default.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit dc3cdbd849)
2010-08-24 19:15:51 -04:00
James Vega 0bd9a8b6f4 Use the correct URLs for the PySqlite website.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 927c8c963a)
2010-08-24 19:15:27 -04:00
James Vega dcdbd5bea4 Update references to PySqlite URL
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit f475525237)
2010-08-24 19:15:17 -04:00
James Vega f0852a9e45 utils.web: Provide access to the raw httpUrlRe/urlRe strings
Using the compiled regexps for a PluginRegexp method's __doc__ doesn't work.

Closes Sourceforge #2879862

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 25fc2de643)
2010-08-24 19:14:58 -04:00
James Vega bb4e09886a Use utils.web.httpUrlRe for the Web/ShrinkUrl snarfer regexes.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit ca917d3528)
2010-08-24 19:14:36 -04:00
Benjamin P. Burhans 750fb2ccdc Check for empty word list in BadWords plugin before filtering.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 6418b3d8c3)
2010-08-24 19:13:09 -04:00
James Vega 3e984c71d0 Clarify databases.types.cdb.maximumModifications' help and use a proper type.
The code expects a float between 0 and 1 inclusive but was simply using
registry.Float.  registry.Probability matches the behavior we want.

Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit e9a896c736)
2010-08-24 19:12:44 -04:00
James Vega 5a0f96fc8e Reply with an error when getBanmask doesn't have a valid channel.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 459bc616b1)
2010-08-24 19:12:21 -04:00