Commit Graph

7103 Commits

Author SHA1 Message Date
Daniel Folkinshteyn
e23bd93ded Secure some more commands which take a regexp from untrusted user input.
Namely todo.search, note.search, dunno.search.
2011-08-12 18:13:27 -04:00
Daniel Folkinshteyn
47fdfe2e9a String: set default re subprocess timeout to 0.1, since that should be quite enough. 2011-08-12 16:38:36 -04:00
Daniel Folkinshteyn
57884bba57 Misc: fix potential ddos when misc.last command is fed a specially-crafted regexp. 2011-08-12 16:30:46 -04:00
Daniel Folkinshteyn
3e0375812a String: fix it up to work with the previously committed enhancement for subprocess timeout. 2011-08-12 16:30:09 -04:00
Daniel Folkinshteyn
2feaddba08 src/commands.py: make subprocesses raise an error on timeout, rather than return a string 2011-08-12 16:28:50 -04:00
Daniel Folkinshteyn
08e676e8fe Misc: fix test for misc.last 2011-08-12 16:21:36 -04:00
Daniel Folkinshteyn
3a96f6735b Services: catch occasional error when removing waiting joins from list 2011-08-08 18:45:02 -04:00
Daniel Folkinshteyn
1e337bdfa9 Dict: Fix FSF address in included dictclient module
Taking fresh address from http://www.gnu.org/licenses/old-licenses/gpl-2.0.html#SEC4
2011-06-27 14:41:49 -04:00
Daniel Folkinshteyn
2b708f034b Web: add 'timeout' config for web fetch, default 5 sec.
Otherwise, when a site would take a long time to respond, the thread would hang for quite a while.

also needed to mod src/utils/web.py to take the timeout arg.
2011-06-13 16:42:57 -04:00
Daniel Folkinshteyn
1b74b8ddf6 Seen: fix tests so they pass. fix seen command so it properly accepts nick wildcards. 2011-04-04 16:30:52 -04:00
Valentin Lorentz
da5b2b35e2 Seen: Fix save Seen.any.db. (thanks to beo_ for the repport and the test)
Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2011-04-04 16:21:12 -04:00
Daniel Folkinshteyn
c25db0ecdf Services: fix problem with some channels being mixed up between networks on startup, when noJoinsUntilIdentified is true.
When noJoinsUntilIdentified config is true, the bot holds join messages in a 'waitingJoins' list, and processes them
once nickserv identification comes through. The problem was that when the bot is configured to join multiple networks,
join messages from different networks would get appended to the same list, without any differentiation by which message
belongs to which network. Thus, if there are messages waiting for multiple networks, it would often be the case that
whichever network got identification done first, would 'pick up' other network's join messages.

This fix stores the network name along with the join messages in the list, and has each network pick out only its own
join messages.
2011-03-13 14:21:46 -04:00
Daniel Folkinshteyn
831a2c3b9a Topic: get shouldn't require capabilities, since it's a read-only operation. 2011-01-25 01:26:42 -05:00
Daniel Folkinshteyn
3151d08e73 Filter: fix rainbow so it doesn't fail with numbers.
fixing this bug: https://sourceforge.net/tracker/?func=detail&aid=3140981&group_id=58965&atid=489447

Thanks to The Compiler for the report and the fix.
2011-01-24 16:18:01 -05:00
Daniel Folkinshteyn
a6d361573d Fix banmask creation. Thanks Progval for the patch!
fixes https://sourceforge.net/tracker/?func=detail&aid=3088559&group_id=58965&atid=489447

incorporating patch https://sourceforge.net/tracker/?func=detail&aid=3163843&group_id=58965&atid=489449
2011-01-24 16:09:18 -05:00
Daniel Folkinshteyn
fc1a3ab258 Services: add some more strings indicating identification success. 2011-01-18 13:51:34 -05:00
Daniel Folkinshteyn
42464d8180 Google: add some extra matching capability to google calc
now should be able to display any 'special' result from google.
2010-12-01 16:53:08 -05:00
Daniel Folkinshteyn
8b702543fa update the version timestamp for the batch of upstream bugfixes that just came through. 2010-10-10 17:52:04 -04:00
James Vega
9183c96a13 Services: Correct formatting of "isn't registered" log.
Closes: Sf#3075937
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit cb48912db6)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:43:34 -04:00
Daniel Folkinshteyn
e78a754c69 Unix: Use converter to enforce "no spaces" for spell's argument.
Closes: Sf#3064304
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit ca56575eb5)
2010-10-10 17:42:26 -04:00
James Vega
4d84798fb8 README: It's a 3-clause, not 2-clause BSD license.
Closes: Sf#3069906
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 89df85c3b3)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:40:19 -04:00
James Vega
a9b515fbd2 Use self.error() instead of raise for BooleanRequiredFalseOnWindows.
Closes: Sf#3070285
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 0fd6a84632)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:40:04 -04:00
James Vega
771331232e Use the plugin name for Owner.defaultplugin's error message.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 074ded49e4)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:39:40 -04:00
James Vega
14a5f52b29 Games: Re-add some, much higher, upper limits to dice.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 154fbc30e9)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:39:08 -04:00
James Vega
fa7c17e24e Karma: Refer to plugins.Karma.rankingDisplay in Karma.karma's help.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 45abdc8248)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:38:44 -04:00
James Vega
8baf08b882 Handle changes to fnmatch.translate in Python 2.6
Define utils.python.glob2re based on the Python version being used.
Use glob2re in Todo and Note plugins.

Closes: Sf#3059292
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit b0575cec88)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:38:08 -04:00
James Vega
3177b3ac36 <text> -> <thing> in Karma.karma's help
Closes: Sf#3057517
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit fc2a84fb90)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:37:05 -04:00
James Vega
219832a0f9 Limiter: Fix "reduce limit" test case.
Closes: Sf#3058142
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit c0e24cef30)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:36:23 -04:00
James Vega
f68b6f709e Google: Remove Groups snarfer
The regular expressions were woefully out of date and since there's not a
stable API (or any for that matter), keeping things working is a losing
battle.

Closes: Sf#3057485
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit c9274606ce)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:35:31 -04:00
James Vega
961786f362 Games: Remove arbitrary upper limits on dice command.
Closes: Sf#3057255
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 7cf61ad046)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-10-10 17:34:56 -04:00
Daniel Folkinshteyn
246c73eed2 BadWords: improve help for requireWordBoundaries config.
Make a note that the plugin requires restart or the words set updating,
for changes to this setting to take effect.
2010-09-08 00:11:28 -04:00
Daniel Folkinshteyn
8d80fb9e88 Badwords: add plugin docstring, and fix/standardize some method docstrings. 2010-09-07 20:27:51 -04:00
Daniel Folkinshteyn
3c00d82579 Scheduler: don't immediately execute commands when restoring repeated events. 2010-09-04 01:25:57 -04:00
Daniel Folkinshteyn
0fe7912628 Misc: update version command to get latest version from gribble git.
Note: if this is ever merged into upstream supybot, should change url
to point at supybot gitweb, rather than gribble.
2010-09-02 18:31:42 -04:00
Daniel Folkinshteyn
567e72488d Cherry-pick a bunch of upstream fix commits. 2010-09-02 09:14:22 -04:00
James Vega
bde37c2afe Channel: Correct specification of "#channel,op" capability.
Closes: Sf#3055991
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 8cc6320768)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-09-02 09:09:29 -04:00
James Vega
ee42f42fb4 Filter: Rename _(un)code to _(morse|unMorse)code
Closes: Sf#3056753
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 452c019b10)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-09-02 09:09:05 -04:00
James Vega
d6423cad67 Dict: Refer to the server config variable in Dict.dict's help.
Closes: Sf#3056621
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit bc98577fb1)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-09-02 09:08:43 -04:00
James Vega
828b82ea9c User: Handle DuplicateHostmask exception in hostmask.add.
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 577294f489)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-09-02 09:08:21 -04:00
James Vega
1fbc28b376 User: Only require name for set.password when changing other user's password.
Closes: Sf#3055358
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit de726f90f3)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-09-02 09:07:35 -04:00
James Vega
5e72daa5f4 User: Require set.password to be sent in private.
Closes: Sf#3055365
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit f977a3a260)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-09-02 09:07:11 -04:00
James Vega
2c812cfd9e User: Specify changename must be used in private in its help.
Closes: Sf#3055353
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 07da8cab13)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-09-02 09:06:33 -04:00
James Vega
7613e4056a Model Admin's ignore help after Channel's.
Closes: Sf#3054919
Signed-off-by: James Vega <jamessan@users.sourceforge.net>
(cherry picked from commit 25b987cc58)

Signed-off-by: Daniel Folkinshteyn <nanotube@users.sourceforge.net>
2010-09-02 09:05:52 -04:00
Daniel Folkinshteyn
3a0e19bc22 Scheduler: remove spammy debug output. 2010-09-02 08:54:13 -04:00
Daniel Folkinshteyn
f9fc250a62 Scheduler: handle event persistence on plugin reload.
Write data to disk on unload; populate events dict with events which are
still scheduled on reload.
2010-09-01 16:37:55 -04:00
Daniel Folkinshteyn
e5e9cbba69 Scheduler: add scheduled task persistence.
The list of tasks scheduled with the Scheduler plugin is now saved
on exit, and restored upon restart.

Previously all scheduled tasks would be forgotten upon bot restart,
which was undesirable behavior.
2010-09-01 15:03:20 -04:00
Daniel Folkinshteyn
cf6fcb9928 Merge commit '05e8b658e633f37456340b83b01fa304f9fcc5d3', Add script to automatically update version with a datestamp upon commit. 2010-08-22 16:16:39 -04:00
Daniel Folkinshteyn
6230a32c69 Fix setup.py version import. It failed on clean install, since module supybot is not yet available.
When importing 'from src', that pulled src/__init__.py, which in turn tried to import the supybot module.
Now we edit sys.path and import the .py file directly.
2010-08-20 12:35:58 -04:00
Daniel Folkinshteyn
05e8b658e6 Add script to automatically update version with a datestamp upon commit. 2010-08-20 11:08:31 -04:00
Daniel Folkinshteyn
2a40d6eb90 Consolidate the version string to reside in one central place to ease change making. 2010-08-20 10:31:05 -04:00