From f5c66afe4f4be57305a54c4cd3ad9efdd580e611 Mon Sep 17 00:00:00 2001 From: jacksonmj Date: Sat, 22 Aug 2015 13:18:19 +0000 Subject: [PATCH] Alias: add hard-coded check that alias names are valid registry names --- plugins/Alias/plugin.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/plugins/Alias/plugin.py b/plugins/Alias/plugin.py index b8cc84b3b..cac46fa4a 100644 --- a/plugins/Alias/plugin.py +++ b/plugins/Alias/plugin.py @@ -319,10 +319,17 @@ class Alias(callbacks.Plugin): group.unregister(name) - def setLocked(name, value): + def setLocked(self, name, value): self.aliases[name][1] = value self.aliasRegistryNode(name).locked.setValue(value) + def isValidName(self, name): + if not re.search(self.registryValue('validName'), name): + return False + if not registry.isValidRegistryName(name): + return False + return True + @internationalizeDocstring def lock(self, irc, msg, args, name): """ @@ -350,7 +357,7 @@ class Alias(callbacks.Plugin): unlock = wrap(unlock, [('checkCapability', 'admin'), 'commandName']) def addAlias(self, irc, name, alias, lock=False): - if not re.search(self.registryValue('validName'), name): + if not self.isValidName(name): raise AliasError('Invalid alias name.') realName = callbacks.canonicalName(name) if name != realName: