Mikaela/Limnoria
1
0
Fork 0
mirror of https://github.com/Mikaela/Limnoria.git synced 2024-11-23 02:49:27 +01:00
Code Issues Projects Releases Wiki Activity

MessageParser: Show error when the action has a syntax error

Browse Source 
Instead of being silent
This commit is contained in:
Valentin Lorentz 2021-06-28 23:10:21 +02:00
parent 6b72672a1e
commit c23227cdc7
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/MessageParser/plugin.py
View File

@ -129,8 +129,13 @@ class MessageParser(callbacks.Plugin, plugins.ChannelDBHandler):
def _runCommandFunction(self, irc, msg, command): def _runCommandFunction(self, irc, msg, command):
"""Run a command from message, as if command was sent over IRC.""" """Run a command from message, as if command was sent over IRC."""
try:
tokens = callbacks.tokenize(command, tokens = callbacks.tokenize(command,
channel=msg.channel, network=irc.network) channel=msg.channel, network=irc.network)
except SyntaxError as e:
# Emulate what callbacks.py does
self.log.debug('Error return: %s', utils.exnToString(e))
irc.error(str(e))
try: try:
self.Proxy(irc.irc, msg, tokens) self.Proxy(irc.irc, msg, tokens)
except Exception as e: except Exception as e:

5
plugins/MessageParser/test.py
View File

@ -85,6 +85,11 @@ class MessageParserTestCase(ChannelPluginTestCase):
self.assertResponse(' ', '$1') self.assertResponse(' ', '$1')
self.assertNotError('messageparser remove "this( .+)? a(.*)"') self.assertNotError('messageparser remove "this( .+)? a(.*)"')
def testSyntaxError(self):
self.assertNotError(r'messageparser add "test" "echo foo \" bar"')
self.feedMsg('test')
self.assertResponse(' ', 'Error: No closing quotation')
def testShow(self): def testShow(self):
self.assertNotError('messageparser add "stuff" "echo i saw some stuff"') self.assertNotError('messageparser add "stuff" "echo i saw some stuff"')
self.assertRegexp('messageparser show "nostuff"', 'there is no such regexp trigger') self.assertRegexp('messageparser show "nostuff"', 'there is no such regexp trigger')