From b03000ed42371b506b8a0ffe75af287dfd729817 Mon Sep 17 00:00:00 2001 From: Jeremy Fincher Date: Sat, 2 Oct 2004 18:28:58 +0000 Subject: [PATCH] If replies.success is empty, don't send a success message at all. --- src/callbacks.py | 7 +++++-- src/conf.py | 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/callbacks.py b/src/callbacks.py index 912501238..16477b4d6 100644 --- a/src/callbacks.py +++ b/src/callbacks.py @@ -414,8 +414,11 @@ class RichReplyMethods(object): def replySuccess(self, s='', **kwargs): v = self._getConfig(conf.supybot.replies.success) - s = self.__makeReply(v, s) - return self.reply(s, **kwargs) + if v: + s = self.__makeReply(v, s) + return self.reply(s, **kwargs) + else: + self.noReply() def replyError(self, s='', **kwargs): v = self._getConfig(conf.supybot.replies.error) diff --git a/src/conf.py b/src/conf.py index 29e22aa78..06a3c1881 100644 --- a/src/conf.py +++ b/src/conf.py @@ -421,7 +421,8 @@ registerGroup(supybot, 'replies') registerChannelValue(supybot.replies, 'success', registry.NormalizedString("""The operation succeeded.""", """Determines - what message the bot replies with when a command succeeded.""")) + what message the bot replies with when a command succeeded. If this + configuration variable is empty, no success message will be sent.""")) registerChannelValue(supybot.replies, 'error', registry.NormalizedString("""An error has occurred and has been logged.