Mikaela
/
Limnoria
mirror of https://github.com/Mikaela/Limnoria.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

irclib: Copy messages before echoing them 

Fixes a bug triggered by Relay when it relays between three or more networks.
This commit is contained in:
Valentin Lorentz 2021-04-01 19:08:54 +02:00
parent f390ade16d
commit 8b90884fa0
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/irclib.py
View File

@ -1406,8 +1406,16 @@ class Irc(IrcCommandDispatcher, log.Firewalled):
assert not msg.tagged('receivedAt')
if not world.testing:
assert not msg.tagged('emulatedEcho')
msg.tag('emulatedEcho', True)
self.feedMsg(msg, tag=False)
# Copy the msg before echoing it back. Without a copy, it
# can cause all sorts of issues if the msg is reused (eg. Relay
# sends the same message object to the same network, so when
# sending the msg for the second time, it would already be
# tagged with emulatedEcho and fail the assertion above)
echo_msg = ircmsgs.IrcMsg(msg=msg)
echo_msg.tag('emulatedEcho', True)
self.feedMsg(echo_msg, tag=False)
else:
# I don't think we should do this. Why should it matter? If it's
# something important, then the server will send it back to us,