From 895881e66e02542002c2a0aa6ecbb6c879ac5a46 Mon Sep 17 00:00:00 2001 From: Valentin Lorentz Date: Fri, 17 Jan 2020 19:49:16 +0100 Subject: [PATCH] Call super().setValue() before defaultHttpHeaders. To prevent infinite recursion on startup, because defaultHttpHeaders gets the value; which is unset, so 'registry._lastModified > self._lastModified' is True, so .set() is called, so .setValue() is called again. --- src/conf.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf.py b/src/conf.py index ba2db3678..d716bacc0 100644 --- a/src/conf.py +++ b/src/conf.py @@ -1318,14 +1318,15 @@ class HttpRequestLanguage(registry.String): """Must be a valid HTTP Accept-Language value.""" __slots__ = () def setValue(self, v): - utils.web.defaultHeaders = defaultHttpHeaders(None, None) super(HttpRequestLanguage, self).setValue(v) + utils.web.defaultHeaders = defaultHttpHeaders(None, None) registerChannelValue(supybot.protocols.http, 'requestLanguage', HttpRequestLanguage('', _("""If set, the Accept-Language HTTP header will be set to this value for requests. Useful for overriding the auto-detected language based on the server's location."""))) + ### # supybot.protocols.ssl ###