From 771c05c666fca3328378203cd1cc60440e18d514 Mon Sep 17 00:00:00 2001 From: Valentin Lorentz Date: Tue, 10 Nov 2020 09:47:36 +0100 Subject: [PATCH] irclib: Fix test failure FAIL: testMoreIsCaseInsensitive (Misc.test.MiscTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File /home/travis/virtualenv/python3.8-dev/lib/python3.8/site-packages/supybot/test.py, line 214, in runTest originalRunTest() File ./plugins/Misc/test.py, line 260, in testMoreIsCaseInsensitive self.assertNotError('more %s' % nick.upper()) File /home/travis/virtualenv/python3.8-dev/lib/python3.8/site-packages/supybot/test.py, line 355, in assertNotError m = self._feedMsg(query, **kwargs) File /home/travis/virtualenv/python3.8-dev/lib/python3.8/site-packages/supybot/test.py, line 526, in _feedMsg response = self.irc.takeMsg() File /home/travis/virtualenv/python3.8-dev/lib/python3.8/site-packages/supybot/log.py, line 368, in m return f(self, *args, **kwargs) File /home/travis/virtualenv/python3.8-dev/lib/python3.8/site-packages/supybot/irclib.py, line 1308, in takeMsg assert not msg.tagged('emulatedEcho') AssertionError I don't understand why it's happening or why it's only that specific test, but there we go. --- src/irclib.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/irclib.py b/src/irclib.py index 424d13da9..623dc1168 100644 --- a/src/irclib.py +++ b/src/irclib.py @@ -1305,7 +1305,8 @@ class Irc(IrcCommandDispatcher, log.Firewalled): # echo-message is not implemented by server; let's emulate it # here, just before sending it to the driver. assert not msg.tagged('receivedAt') - assert not msg.tagged('emulatedEcho') + if not world.testing: + assert not msg.tagged('emulatedEcho') msg.tag('emulatedEcho', True) self.feedMsg(msg, tag=False) else: