From 696d82ccfe6a2cbd30f35b4a4758d179c13460c6 Mon Sep 17 00:00:00 2001 From: Valentin Lorentz Date: Tue, 9 Nov 2021 22:01:59 +0100 Subject: [PATCH] Geography: Fix crash in nominatim.py when some results are not OSM objects --- plugins/Geography/nominatim.py | 4 +--- plugins/Geography/test.py | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/plugins/Geography/nominatim.py b/plugins/Geography/nominatim.py index b919e87d1..d244e5199 100644 --- a/plugins/Geography/nominatim.py +++ b/plugins/Geography/nominatim.py @@ -31,8 +31,6 @@ import json import time -import string -import datetime import threading import urllib.parse @@ -77,4 +75,4 @@ def search_osmids(query): on the query format""" data = _query_nominatim("/search", {"format": "json", "q": query}) - return [item["osm_id"] for item in data] + return [item["osm_id"] for item in data if item.get("osm_id")] diff --git a/plugins/Geography/test.py b/plugins/Geography/test.py index e16e54901..330fa6626 100644 --- a/plugins/Geography/test.py +++ b/plugins/Geography/test.py @@ -114,5 +114,4 @@ class GeographyNominatimTestCase(SupyTestCase): self.assertEqual(results[0], 450381, results) - # vim:set shiftwidth=4 tabstop=4 expandtab textwidth=79: