Mikaela/Limnoria
1
0
Fork 0
mirror of https://github.com/Mikaela/Limnoria.git synced 2024-12-26 12:43:09 +01:00
Code Issues Projects Releases Wiki Activity

Socket: Don't add instances twice in cls._instances.

Browse Source 
The connect() method already adds it, so it was in the list twice
(added both by __init__() and connect()).

This caused _select() to call _read() twice on the same instance,
except there is usually nothing to read on the second call,
so it blocks for up to conf.supybot.drivers.poll().
This commit is contained in:
Valentin Lorentz 2020-01-25 21:00:42 +01:00
parent b5beb5f981
commit 5efd2afa27
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/drivers/Socket.py
View File

@ -65,7 +65,6 @@ class SocketDriver(drivers.IrcDriver, drivers.ServersMixin):
_instances = [] _instances = []
_selecting = threading.Lock() _selecting = threading.Lock()
def __init__(self, irc): def __init__(self, irc):
self._instances.append(self)
assert irc is not None assert irc is not None
self.irc = irc self.irc = irc
drivers.IrcDriver.__init__(self, irc) drivers.IrcDriver.__init__(self, irc)