Mikaela/Limnoria
1
0
Fork 0
mirror of https://github.com/Mikaela/Limnoria.git synced 2025-01-24 02:54:05 +01:00
Code Issues Projects Releases Wiki Activity

Web: Fix code factorization (576a96fb71). Closes GH-1173.

Browse Source
This commit is contained in:
Valentin Lorentz 2015-10-17 15:41:20 +02:00
parent fb52b16429
commit 526ffb0ccb
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
plugins/Web/plugin.py
View File

@ -139,7 +139,7 @@ class Web(callbacks.PluginRegexp):
def noIgnore(self, irc, msg): def noIgnore(self, irc, msg):
return not self.registryValue('checkIgnored', msg.args[0]) return not self.registryValue('checkIgnored', msg.args[0])
def getTitle(self, url): def getTitle(self, url, raiseErrors):
size = conf.supybot.protocols.http.peekSize() size = conf.supybot.protocols.http.peekSize()
text = utils.web.getUrl(url, size=size) text = utils.web.getUrl(url, size=size)
try: try:
@ -149,12 +149,21 @@ class Web(callbacks.PluginRegexp):
pass pass
parser = Title() parser = Title()
if minisix.PY3 and isinstance(text, bytes): if minisix.PY3 and isinstance(text, bytes):
if raiseErrors:
irc.error(_('Could not guess the page\'s encoding. (Try ' irc.error(_('Could not guess the page\'s encoding. (Try '
'installing python-charade.)'), Raise=True) 'installing python-charade.)'), Raise=True)
else:
return None
parser.feed(text) parser.feed(text)
title = parser.title title = parser.title
if title: if title:
title = utils.web.htmlToText(parser.title.strip()) title = utils.web.htmlToText(parser.title.strip())
elif raiseErrors:
if len(text) < size:
irc.reply(_('That URL appears to have no HTML title.'))
else:
irc.reply(format(_('That URL appears to have no HTML title '
'within the first %S.'), size))
return title return title
@fetch_sandbox @fetch_sandbox
@ -172,7 +181,7 @@ class Web(callbacks.PluginRegexp):
if r and r.search(url): if r and r.search(url):
self.log.debug('Not titleSnarfing %q.', url) self.log.debug('Not titleSnarfing %q.', url)
return return
title = self.getTitle(url) title = self.getTitle(url, False)
if title: if title:
domain = utils.web.getDomain(fd.geturl() domain = utils.web.getDomain(fd.geturl()
if self.registryValue('snarferShowTargetDomain', channel) if self.registryValue('snarferShowTargetDomain', channel)
@ -283,17 +292,12 @@ class Web(callbacks.PluginRegexp):
if not self._checkURLWhitelist(url): if not self._checkURLWhitelist(url):
irc.error("This url is not on the whitelist.") irc.error("This url is not on the whitelist.")
return return
title = self.getTitle(url) title = self.getTitle(url, True)
if title: if title:
if not [y for x,y in optlist if x == 'no-filter']: if not [y for x,y in optlist if x == 'no-filter']:
for i in range(1, 4): for i in range(1, 4):
title = title.replace(chr(i), '') title = title.replace(chr(i), '')
irc.reply(title) irc.reply(title)
elif len(text) < size:
irc.reply(_('That URL appears to have no HTML title.'))
else:
irc.reply(format(_('That URL appears to have no HTML title '
'within the first %S.'), size))
title = wrap(title, [getopts({'no-filter': ''}), 'httpUrl']) title = wrap(title, [getopts({'no-filter': ''}), 'httpUrl'])
@internationalizeDocstring @internationalizeDocstring