Merge pull request #534 from nyuszika7h/fix/fd-leak

Fix file descriptor leaks

src/dbi.py

@@ -121,6 +121,8 @@ class DirMapping(MappingInterface):
             exn = NoRecordError(id)
             exn.realException = e
             raise exn
+        finally:
+            fd.close()
 
     def set(self, id, s):
         fd = open(self._makeFilename(id), 'w')
@@ -158,6 +160,8 @@ class FlatfileMapping(MappingInterface):
             self.maxSize = int(math.log10(maxSize))
             self.currentId = 0
             self._incrementCurrentId()
+        finally:
+            fd.close()
 
     def _canonicalId(self, id):
         if id is not None:

src/httpserver.py

@@ -157,10 +157,12 @@ set_default_templates(DEFAULT_TEMPLATES)
 def get_template(filename):
     path = conf.supybot.directories.data.web.dirize(filename)
     if os.path.isfile(path):
-        return open(path, 'r').read()
+        with open(path, 'r') as fd:
+            return fd.read()
     else:
         assert os.path.isfile(path + '.example'), path + '.example'
-        return open(path + '.example', 'r').read()
+        with open(path + '.example', 'r') as fd:
+            return fd.read()
 
 class RealSupyHTTPServer(HTTPServer):
     # TODO: make this configurable
@@ -364,6 +366,8 @@ class Favicon(SupyHTTPServerCallback):
                 found = True
             except IOError:
                 pass
+            finally:
+                icon.close()
         if found:
             response = icon.read()
             filename = file_path.rsplit(os.sep, 1)[1]

src/i18n.py

@@ -58,9 +58,10 @@ def getLocaleFromRegistryFilename(filename):
     """Called by the 'supybot' script. Gets the locale name before conf is
     loaded."""
     global currentLocale
-    for line in open(filename, 'r'):
+    with open(filename, 'r') as fd:
-        if line.startswith('supybot.language: '):
+        for line in fd:
-            currentLocale = line[len('supybot.language: '):]
+            if line.startswith('supybot.language: '):
+                currentLocale = line[len('supybot.language: '):]
 
 def import_conf():
     """Imports the conf into this module"""
@@ -163,6 +164,8 @@ class _PluginInternationalization:
             self._parse(translationFile)
         except (IOError, PluginNotFound): # The translation is unavailable
             pass
+        finally:
+            translationFile.close()
 
     def _parse(self, translationFile):
         """A .po files parser.

src/shlex.py

@@ -208,7 +208,8 @@ if __name__ == '__main__':
         lexer = shlex()
     else:
         file = sys.argv[1]
-        lexer = shlex(open(file), file)
+        with open(file) as fd:
+            lexer = shlex(fd, file)
     while 1:
         tt = lexer.get_token()
         if tt:

src/utils/file.py

@@ -38,7 +38,8 @@ from . import crypt
 from .iter import ifilter
 
 def contents(filename):
-    return open(filename).read()
+    with open(filename) as fd:
+        return fd.read()
 
 def open_mkdir(filename, mode='wb', *args, **kwargs):
     """filename -> file object.
@@ -62,6 +63,8 @@ def copy(src, dst):
     srcfd = open(src)
     dstfd = open_mkdir(dst, 'wb')
     shutil.copyfileobj(srcfd, dstfd)
+    srcfd.close()
+    dstfd.close()
 
 def writeLine(fd, line):
     fd.write(line)

src/utils/transaction.py

@@ -88,6 +88,7 @@ class TransactionMixin(python.Object):
             (command, rest) = line.split(None, 1)
             args = rest.split()
             yield (command, args)
+        journal.close()
         
 
 class Transaction(TransactionMixin):