Mikaela/Limnoria
1
0
Fork 0
mirror of https://github.com/Mikaela/Limnoria.git synced 2024-12-25 20:22:45 +01:00
Code Issues Projects Releases Wiki Activity

safeEval: Get rid of eval().

Browse Source 
It should be safe considering the AST sanity checks,
but I don't see any point in keeping it.
This commit is contained in:
Valentin Lorentz 2020-05-15 18:31:04 +02:00
parent 6f4e3a2dbd
commit 3d1e88cb68
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/utils/gen.py
View File

@ -202,12 +202,9 @@ def safeEval(s, namespace=None):
else: else:
return False return False
if checkNode(node): if checkNode(node):
if namespace is None: # Probably equivalent to eval() because checkNode(node) is True,
return eval(s, namespace, namespace) # but it's an extra security.
else: return ast.literal_eval(node)
# Probably equivalent to eval() because checkNode(node) is True,
# but it's an extra security.
return ast.literal_eval(node)
else: else:
raise ValueError(format('Unsafe string: %q', s)) raise ValueError(format('Unsafe string: %q', s))