From 3bedc864791ff37d1ab11ebdc473ab55fc07f61c Mon Sep 17 00:00:00 2001 From: Valentin Lorentz Date: Thu, 27 May 2021 00:08:02 +0200 Subject: [PATCH] Socket: Disable resolution when using a SOCKS proxy 1. Avoids leaking DNS queries 2. necessary for onion services --- src/drivers/Socket.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/drivers/Socket.py b/src/drivers/Socket.py index 63c73ab07..6db0bf226 100644 --- a/src/drivers/Socket.py +++ b/src/drivers/Socket.py @@ -269,6 +269,11 @@ class SocketDriver(drivers.IrcDriver, drivers.ServersMixin): log.error('Cannot use socks proxy (SocksiPy not installed), ' 'using direct connection instead.') socks_proxy = '' + if socks_proxy: + # Do not try to resolve, let the SOCKS proxy do it. + # (Avoids leaking DNS queries *and* is necessary for onion + # services) + address = self.currentServer.hostname else: try: address = utils.net.getAddressFromHostname(