From 393f78c5732f566197c11171a730e96c45d6f9c2 Mon Sep 17 00:00:00 2001 From: Valentin Lorentz Date: Sun, 5 Aug 2012 09:59:42 +0200 Subject: [PATCH] Use a boolean instead of hacky reference comparison in utils.iter.choice. --- src/utils/iter.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/utils/iter.py b/src/utils/iter.py index 079162a1a..a60672f77 100644 --- a/src/utils/iter.py +++ b/src/utils/iter.py @@ -98,13 +98,13 @@ def choice(iterable): return random.choice(iterable) else: n = 1 - m = new.module('') # Guaranteed unique value. - ret = m + found = False for x in iterable: if random.random() < 1/n: ret = x + found = True n += 1 - if ret is m: + if not found: raise IndexError return ret