Mikaela/Limnoria
1
0
Fork 0
mirror of https://github.com/Mikaela/Limnoria.git synced 2025-02-18 14:40:51 +01:00
Code Issues Projects Releases Wiki Activity

User: allow owners to change their own password

Browse Source 
I don't understand why this restriction exists. If someone gains access to someone else's owner account, they can do a lot worse damage than just changing the owner password.
People logging in via NickAuth or hostmasks should be able to change their passwords at will, even if the owner doesn't know his previous password.
This commit is contained in:
James Lu 2016-02-07 12:05:03 -08:00 committed by Valentin Lorentz
parent d4a71497c4
commit 3879f30d47
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/User/plugin.py
View File

@ -126,7 +126,7 @@ class User(callbacks.Plugin):
if u._checkCapability('owner'): if u._checkCapability('owner'):
addHostmask = False addHostmask = False
else: else:
irc.error(_('Your hostmask is already registered to %s') % irc.error(_('Your hostmask is already registered to %s') %
u.name) u.name)
return return
except KeyError: except KeyError:
@ -196,10 +196,9 @@ class User(callbacks.Plugin):
"""[<name>] <old password> <new password> """[<name>] <old password> <new password>
Sets the new password for the user specified by <name> to <new Sets the new password for the user specified by <name> to <new
password>. Obviously this message must be sent to the bot password>. Obviously this message must be sent to the bot
privately (not in a channel). If the requesting user is an owner privately (not in a channel). If the requesting user is an owner
user (and the user whose password is being changed isn't that same user, then <old password> needn't be correct.
owner user), then <old password> needn't be correct.
""" """
try: try:
u = ircdb.users.getUser(msg.prefix) u = ircdb.users.getUser(msg.prefix)
@ -210,7 +209,7 @@ class User(callbacks.Plugin):
irc.errorNotRegistered(Raise=True) irc.errorNotRegistered(Raise=True)
user = u user = u
if user.checkPassword(password) or \ if user.checkPassword(password) or \
(u and u._checkCapability('owner') and not u == user): (u and u._checkCapability('owner')):
user.setPassword(newpassword) user.setPassword(newpassword)
ircdb.users.setUser(user) ircdb.users.setUser(user)
irc.replySuccess() irc.replySuccess()