Mikaela/Limnoria
1
0
Fork 0
mirror of https://github.com/Mikaela/Limnoria.git synced 2024-11-20 01:19:26 +01:00
Code Issues Projects Releases Wiki Activity

actually implement reply.withNoticeWhenPrivate

Browse Source
This commit is contained in:
James Vega 2004-08-24 19:48:01 +00:00
parent 68feda2dc2
commit 2a040b475f
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/callbacks.py
View File

@ -151,6 +151,8 @@ def reply(msg, s, prefixName=True, private=None,
else:
target = to
# XXX: User value for reply.withNoticeWhenPrivate.
if getConfig(conf.supybot.reply.withNoticeWhenPrivate):
notice = True
if to is None:
to = msg.nick
# Ok, now let's make the payload:

15
test/test_callbacks.py
View File

@ -449,6 +449,9 @@ class WithPrivateNoticeTestCase(ChannelPluginTestCase):
def explicit(self, irc, msg, args):
irc.reply('should not be with private notice',
private=False, notice=False)
def implicit(self, irc, msg, args):
irc.reply('should be with notice due to private',
private=True)
def test(self):
self.irc.addCallback(self.WithPrivateNotice())
# Check normal behavior.
@ -473,7 +476,17 @@ class WithPrivateNoticeTestCase(ChannelPluginTestCase):
finally:
conf.supybot.reply.inPrivate.setValue(originalInPrivate)
conf.supybot.reply.withNotice.setValue(originalWithNotice)
orig = conf.supybot.reply.withNoticeWhenPrivate()
try:
conf.supybot.reply.withNoticeWhenPrivate.setValue(True)
m = self.assertNotError('implicit')
self.failUnless(m.command == 'NOTICE')
self.failIf(ircutils.isChannel(m.args[0]))
m = self.assertNotError('normal')
self.failIf(m.command == 'NOTICE')
self.failUnless(ircutils.isChannel(m.args[0]))
finally:
conf.supybot.reply.withNoticeWhenPrivate.setValue(orig)