diff --git a/docs/STYLE b/docs/STYLE index 2551fa124..fcc6f4d0f 100644 --- a/docs/STYLE +++ b/docs/STYLE @@ -75,6 +75,10 @@ statements in the code (commented out) so they can later be re-enabled. Remember that once code is buggy, it tends to have more bugs, and you'll probably need those print statements again. +While on the topic of logs, note that we do not use % with logged +strings; we simple pass the format parameters as additional +arguemnts. + SQL table names should be all-lowercase and include underscores to separate words. This is because SQL itself is case-insensitive. diff --git a/src/Misc.py b/src/Misc.py index 9ba8a6e8f..a77b4b58c 100755 --- a/src/Misc.py +++ b/src/Misc.py @@ -273,7 +273,7 @@ class Misc(callbacks.Privmsg): return s.split(None, 3)[2] except: self.log.exception('Getting %s module\'s revision number ' - 'from __revision__ string: %s'%(n, s)) + 'from __revision__ string: %s', n, s) if hasattr(module, '__revision__'): if 'supybot' in module.__file__: return getVersion(module.__revision__, name)