Prevent dice overflow #27

Georg · 2024-10-10T02:36:58+02:00

Georg commented

2024-10-10 02:36:58 +02:00

rand.Int() would panic when the max value is <= 0, which happens when big.NewInt() was fed with a too large number. Avoid this by validating the big.NewInt() return beforehand. Add error handling to all callers to both gracefully return to IRC and to log an error message.

Signed-off-by: Georg Pfuetzenreuter mail@georg-pfuetzenreuter.net

rand.Int() would panic when the max value is <= 0, which happens when big.NewInt() was fed with a too large number. Avoid this by validating the big.NewInt() return beforehand. Add error handling to all callers to both gracefully return to IRC and to log an error message. Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>

Georg added 1 commit 2024-10-10 02:36:59 +02:00

Prevent dice overflow 94d31e829e

rand.Int() would panic when the max value is <= 0, which happens when
big.NewInt() was fed with a too large number. Avoid this by validating
the big.NewInt() return beforehand. Add error handling to all callers to
both gracefully return to IRC and to log an error message.

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>

Georg force-pushed overflow from 94d31e829e to 5560c59614

2024-10-10 02:42:11 +02:00

Compare

Georg force-pushed overflow from 5560c59614 to 4dc94dc0cf

2024-10-10 02:46:52 +02:00

Compare

Georg changed title from ~~WIP: Prevent dice overflow~~ to Prevent dice overflow

2024-10-10 02:46:56 +02:00

Georg referenced this pull request

2024-10-10 02:47:05 +02:00

Crash on big numbers #6

Georg force-pushed overflow from 4dc94dc0cf to 930839ab58