From db343e31ced646f69bf1868e6d14989ee8c7606a Mon Sep 17 00:00:00 2001
From: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Date: Mon, 30 Jan 2023 02:07:03 +0100
Subject: [PATCH] Combined update

- follow ShellCheck advice:
  - use read -r
  - quote variables inside command substitution
- move dependency check to the beginning

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
---
 salt-keydiff.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
 mode change 100644 => 100755 salt-keydiff.sh

diff --git a/salt-keydiff.sh b/salt-keydiff.sh
old mode 100644
new mode 100755
index 92fb112..b4de6a9
--- a/salt-keydiff.sh
+++ b/salt-keydiff.sh
@@ -15,19 +15,19 @@ set -Ceu
 minion="${1:-null}"
 NOCOLOR="$(tput sgr0)"
 
-if [ "$minion" = 'null' ]
-then
-	printf 'Please specify the minion to diff against.\n'
-	exit 1
-fi
-
 if ! command -v jq >/dev/null || ! command -v salt-key >/dev/null
 then
 	printf 'Please ensure jq and salt-key are available.\n'
 	exit 1
 fi
 
-key_salt="$(salt-key --out json -f $minion | jq --arg minion $minion -r '.minions_pre[$minion]')"
+if [ "$minion" = 'null' ]
+then
+	printf 'Please specify the minion to diff against.\n'
+	exit 1
+fi
+
+key_salt="$(salt-key --out json -f "$minion" | jq --arg minion "$minion" -r '.minions_pre[$minion]')"
 
 if [ "$key_salt" = 'null' ]
 then
@@ -35,8 +35,8 @@ then
 	exit 2
 fi
 
-printf 'Enter fingerprint to diff against\n'
-read key_user
+printf 'Enter fingerprint to diff against (run `salt-call --local key.finger` on the minion)\n'
+read -r key_user
 
 if [ "$key_salt" = "$key_user" ]
 then